Uh oh!
There was an error while loading. Please reload this page.
bpo-40170: Convert PyIter_Check macro to a function - #24548
Conversation
erlend-aasland
commented
Feb 16, 2021
@vstinner Would you mind reviewing this? |
ec6687a to
7c03394Compare
vstinner
left a comment
There was a problem hiding this comment.
For macOS which doesn't use LTO compiler optimization, we added private static inline functions of some "Check" functions. But I don't think that it's worth it here (I don't think that the function is commonly called in "hot code").
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Victor Stinner <vstinner@python.org>
erlend-aasland
commented
Feb 16, 2021
CI is done; PTAL, @vstinner. |
vstinner
commented
Feb 16, 2021
Merged, thanks. |
bedevere-bot
commented
Feb 16, 2021
|
…to "C API" section
The macro accessed the
PyTypeObject.tp_iternextmember directly."Swap" macro variant with the function in order to hide implementation details.
(A function already existed, but it was not exposed.)
https://bugs.python.org/issue40170