Skip to content

bpo-20364: Improve sqlite3 placeholder docs - #25003

Merged
berkerpeksag merged 11 commits into
python:masterfrom
erlend-aasland:bpo-20364
Apr 14, 2021
Merged

bpo-20364: Improve sqlite3 placeholder docs#25003
berkerpeksag merged 11 commits into
python:masterfrom
erlend-aasland:bpo-20364

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Mar 23, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Co-authored-by: Terry J. Reedy

https://bugs.python.org/issue20364

@erlend-aasland

erlend-aasland commented Mar 23, 2021

Copy link
Copy Markdown
ContributorAuthor

@berkerpeksag, @terryjreedy: would you mind taking a look at this?

erlend-aasland
erlend-aasland commented Apr 2, 2021
View reviewed changes
Comment threadDoc/library/sqlite3.rst
Fidget-Spinner
Fidget-Spinner reviewed Apr 5, 2021
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an sqllite3 expert by any means, so I'll leave verifying the content's accuracy to someone else ;).

Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/library/sqlite3.rst Outdated
Erlend Egeberg Aasland@Fidget-Spinner
parametrized => parameterized
f19c531
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@erlend-aasland

erlend-aasland commented Apr 5, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing, @Fidget-Spinner, I appreciate your comments 😃

Fidget-Spinner
Fidget-Spinner approved these changes Apr 13, 2021
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for improving the docs :).

berkerpeksag
berkerpeksag requested changes Apr 14, 2021
View reviewed changes
Comment threadDoc/library/sqlite3.rst
Comment threadDoc/library/sqlite3.rst Outdated
Comment threadDoc/includes/sqlite3/execute_1.py Outdated
Comment threadDoc/library/sqlite3.rst
@bedevere-bot

bedevere-bot commented Apr 14, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

berkerpeksag
berkerpeksag reviewed Apr 14, 2021
View reviewed changes
Comment threadDoc/includes/sqlite3/execute_1.py Outdated
@erlend-aasland

erlend-aasland commented Apr 14, 2021

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Apr 14, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@berkerpeksag

berkerpeksag commented Apr 14, 2021

Copy link
Copy Markdown
Member

Ah, can you also fix the following error?

Warning, treated as error:
[library/sqlite3:98] ":name" found in "cur.execute("select * from lang where lang_name=:name and lang_age=:age","
Makefile:49: recipe for target 'build' failed

You'll probably need to update Doc/tools/susp-ignored.csv.

@erlend-aasland

erlend-aasland commented Apr 14, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

You'll probably need to update Doc/tools/susp-ignored.csv.

Oh, I've never seen this before :) c2366b5 did not fix it, but I discovered the make suspicious target in Doc. Fix comin' up pretty soon.

UPDATE: Done. Fixed in f3ed86e

@erlend-aasland

erlend-aasland commented Apr 14, 2021

Copy link
Copy Markdown
ContributorAuthor

Since this is a doc update, we'd want to backport it to 3.9 and 3.8, right?

@berkerpeksag
berkerpeksag merged commit 3386ca0 into python:masterApr 14, 2021
@miss-islington

miss-islington commented Apr 14, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@erlend-aasland
erlend-aasland deleted the bpo-20364 branch April 14, 2021 12:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 14, 2021
Erlend Egeberg Aasland@miss-islington
bpo-20364: Improve sqlite3 placeholder docs (pythonGH-25003)
8827074
(cherry picked from commit 3386ca0)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

bedevere-bot commented Apr 14, 2021

Copy link
Copy Markdown

GH-25402 is a backport of this pull request to the 3.9 branch.

@erlend-aasland

erlend-aasland commented Apr 14, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for reviewing, @berkerpeksag !

berkerpeksag pushed a commit that referenced this pull request Apr 14, 2021
@miss-islingtonErlend Egeberg Aasland
bpo-20364: Improve sqlite3 placeholder docs (GH-25003)
95e4431
(cherry picked from commit 3386ca0)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aaslanderlend-aasland mentioned this pull request May 10, 2021
Merged
@erlend-aaslanderlend-aasland mentioned this pull request Jul 27, 2022
Closed
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksagberkerpeksagberkerpeksag approved these changes
@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland@bedevere-bot@berkerpeksag@miss-islington@Fidget-Spinner@the-knights-who-say-ni