Skip to content

bpo-44106: Improve sqlite3 example database contents - #26027

Merged
berkerpeksag merged 9 commits into
python:mainfrom
erlend-aasland:sqlite-examples
May 19, 2021
Merged

bpo-44106: Improve sqlite3 example database contents#26027
berkerpeksag merged 9 commits into
python:mainfrom
erlend-aasland:sqlite-examples

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented May 10, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Use programming languages iso. politicians as example content.

https://bugs.python.org/issue44106

@erlend-aasland

erlend-aasland commented May 10, 2021

Copy link
Copy Markdown
ContributorAuthor

Ref. #25003 (comment)

berkerpeksag
berkerpeksag requested changes May 11, 2021
View reviewed changes
Comment threadDoc/includes/sqlite3/execsql_fetchonerow.py Outdated
Comment threadDoc/includes/sqlite3/createdb.py
Comment threadDoc/includes/sqlite3/simple_tableprinter.py Outdated
Comment threadMisc/NEWS.d/next/Documentation/2021-05-11-00-54-14.bpo-44106.grCmuu.rst Outdated
@bedevere-bot

bedevere-bot commented May 11, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

zware
zware reviewed May 11, 2021
View reviewed changes
Comment threadDoc/includes/sqlite3/ctx_manager.py Outdated
Comment threadDoc/includes/sqlite3/insert_more_people.py
@erlend-aasland

erlend-aasland commented May 11, 2021

Copy link
Copy Markdown
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented May 11, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

Fidget-Spinner
Fidget-Spinner approved these changes May 11, 2021
View reviewed changes

@Fidget-SpinnerFidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I learnt something new about programming languages while learning about sqllite :).

Comment threadDoc/includes/sqlite3/createdb.py
@erlend-aaslanderlend-aasland mentioned this pull request May 18, 2021
Merged
@berkerpeksag
berkerpeksag merged commit 92d1064 into python:mainMay 19, 2021
@miss-islington

miss-islington commented May 19, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented May 19, 2021

Copy link
Copy Markdown

GH-26232 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
Erlend Egeberg Aasland@miss-islington
bpo-44106: Improve sqlite3 example database contents (pythonGH-26027)
d92c7f4
(cherry picked from commit 92d1064)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2021
Erlend Egeberg Aasland@miss-islington
bpo-44106: Improve sqlite3 example database contents (pythonGH-26027)
3a0373e
(cherry picked from commit 92d1064)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

bedevere-bot commented May 19, 2021

Copy link
Copy Markdown

GH-26233 is a backport of this pull request to the 3.9 branch.

berkerpeksag pushed a commit that referenced this pull request May 19, 2021
@miss-islingtonErlend Egeberg Aasland
bpo-44106: Improve sqlite3 example database contents (GH-26027)
db20afe
(cherry picked from commit 92d1064)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
berkerpeksag pushed a commit that referenced this pull request May 19, 2021
@miss-islingtonErlend Egeberg Aasland
bpo-44106: Improve sqlite3 example database contents (GH-26027)
3185bc9
(cherry picked from commit 92d1064)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aaslanderlend-aasland mentioned this pull request May 19, 2021
Merged
@erlend-aasland
erlend-aasland deleted the sqlite-examples branch May 19, 2021 07:47
@pablogsalpablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zwarezwarezware left review comments
@berkerpeksagberkerpeksagberkerpeksag approved these changes
@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@erlend-aasland@bedevere-bot@miss-islington@berkerpeksag@zware@Fidget-Spinner@the-knights-who-say-ni