Uh oh!
There was an error while loading. Please reload this page.
bpo-45243: Expose SQLite connection limits as sqlite3.Connection attributes - #28790
Closed
erlend-aasland wants to merge 5 commits into
Closed
bpo-45243: Expose SQLite connection limits as sqlite3.Connection attributes#28790erlend-aasland wants to merge 5 commits into
sqlite3.Connection attributes#28790erlend-aasland wants to merge 5 commits into
Conversation
erlend-aasland
commented
Oct 7, 2021
ContributorAuthor
Proposed alternative to #28463. |
erlend-aaslandforce-pushed
the
sqlite-limits-as-attributes
branch
from
October 7, 2021 12:51
e0da443 to
a0c1251CompareContributorAuthor
There was a problem hiding this comment.
Casting the limit macros to void * and back again to int is perhaps a little bit too hackish. But it does allow for a single getter/setter.
erlend-aaslandforce-pushed
the
sqlite-limits-as-attributes
branch
from
October 7, 2021 12:56
a0c1251 to
f4b9fcdCompareerlend-aaslandforce-pushed
the
sqlite-limits-as-attributes
branch
from
October 7, 2021 13:29
5ec4adb to
d04794dCompareserhiy-storchaka
commented
Oct 7, 2021
Member
old=con.SQLITE_LIMIT_LENGTHcon.SQLITE_LIMIT_LENGTH=newdoes not look nice to me. If go this way, I would prefer old=con.limit.lengthcon.limit.length=newBut do we have precedences of such getters and setters in the stdlib? There are also disadvantages in comparison with traditional
|
erlend-aasland
commented
Oct 7, 2021
ContributorAuthor
erlend-aasland
commented
Oct 7, 2021
ContributorAuthor
This approach will be more tedious to maintain. I'm closing this in favour of GH-28463. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45243