Skip to content

bpo-45608: Document missing sqlite3 DB-API attributes and methods - #29219

Merged
ambv merged 7 commits into
python:mainfrom
erlend-aasland:sqlite-doc-dbapi
Oct 28, 2021
Merged

bpo-45608: Document missing sqlite3 DB-API attributes and methods#29219
ambv merged 7 commits into
python:mainfrom
erlend-aasland:sqlite-doc-dbapi

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Oct 25, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Document DB-API required attributes and methods:

  • sqlite3.apilevel
  • sqlite3.paramstyle
  • sqlite3.threadsafety
  • sqlite3.Cursor.setinputsizes()
  • sqlite3.Cursor.setoutputsize()

https://bugs.python.org/issue45608

@bedevere-botbedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 25, 2021
@erlend-aaslanderlend-aasland changed the title bpo-45608: Document missing sqlite3 DB-API attributesbpo-45608: Document missing sqlite3 DB-API attributes and methodsOct 25, 2021
pfmoore
pfmoore approved these changes Oct 26, 2021
View reviewed changes

@pfmoorepfmoore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with just one minor nitpick.

Comment threadDoc/library/sqlite3.rst Outdated
@erlend-aasland

erlend-aasland commented Oct 26, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

PTAL, @pfmoore. Thanks for reviewing!

I also pushed a small wording improvement in b087d3a

@erlend-aasland

erlend-aasland commented Oct 26, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks, Paul! @malemburg, does this look good to you?

@erlend-aaslanderlend-aasland mentioned this pull request Oct 26, 2021
Merged
@ambv
ambv merged commit 88d8a1a into python:mainOct 28, 2021
@miss-islington

miss-islington commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2021
Erlend Egeberg Aasland@miss-islington
bpo-45608: Document missingsqlite3DB-API attributes and methods (p…
13db640
…ythonGH-29219)
(cherry picked from commit 88d8a1a)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

bedevere-bot commented Oct 28, 2021

Copy link
Copy Markdown

GH-29281 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Oct 28, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 28, 2021
Erlend Egeberg Aasland@miss-islington
bpo-45608: Document missingsqlite3DB-API attributes and methods (p…
9787ff2
…ythonGH-29219)
(cherry picked from commit 88d8a1a)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot

bedevere-bot commented Oct 28, 2021

Copy link
Copy Markdown

GH-29282 is a backport of this pull request to the 3.9 branch.

@erlend-aasland
erlend-aasland deleted the sqlite-doc-dbapi branch October 28, 2021 19:37
@erlend-aasland

erlend-aasland commented Oct 28, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks, Łukasz!

ambv pushed a commit that referenced this pull request Oct 28, 2021
@miss-islingtonErlend Egeberg Aasland
bpo-45608: Document missingsqlite3DB-API attributes and methods (G…
1d88b2b
…H-29219) (GH-29281)
(cherry picked from commit 88d8a1a)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
ambv pushed a commit that referenced this pull request Oct 28, 2021
@miss-islingtonErlend Egeberg Aasland
bpo-45608: Document missingsqlite3DB-API attributes and methods (G…
020aa06
…H-29219) (GH-29282)
(cherry picked from commit 88d8a1a)
Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aaslanderlend-aasland mentioned this pull request May 16, 2022
Closed
@erlend-aaslanderlend-aasland mentioned this pull request Jul 27, 2022
Closed
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfmoorepfmoorepfmoore approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag
@malemburgmalemburgAwaiting requested review from malemburg
@willingcwillingcAwaiting requested review from willingc

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland@miss-islington@bedevere-bot@pfmoore@ambv@the-knights-who-say-ni