Skip to content

bpo-44133: Export Py_FrozenMain() symbol. - #29876

Closed
shihai1991 wants to merge 3 commits into
python:mainfrom
shihai1991:bpo_44133
Closed

bpo-44133: Export Py_FrozenMain() symbol.#29876
shihai1991 wants to merge 3 commits into
python:mainfrom
shihai1991:bpo_44133

Conversation

@shihai1991

@shihai1991shihai1991 commented Dec 1, 2021•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The Python binary now builds the libpython static library using
"-Wl,--whole-archive" or "-Wl,-all_load"linker option to
export all symbols exported by object files.
Previously, the "Py_FrozenMain" symbol was not exported.

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue44133

@shihai1991
test
0230c8b
@shihai1991
Merge branch 'main' into bpo_44133
b71b124
* main: (21 commits)
bpo-45876: Have stdev() also use decimal specific square root. (pythonGH-29869)
bpo-45876: Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)
bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)
bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)
bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)
bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)
bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)
Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)
no-issue: remove unused import from test_graphlib.py (pythonGH-29853)
bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)
bpo-45653: fix test_embed on windows (pythonGH-29814)
bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)
bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)
bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)
bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)
bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)
bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)
bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)
bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)
bpo-45847: Make socket module conditional (pythonGH-29769)
...
@encukouencukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 1, 2021
@bedevere-bot

bedevere-bot commented Dec 1, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit b71b124 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 1, 2021
@shihai1991

shihai1991 commented Dec 1, 2021

Copy link
Copy Markdown
MemberAuthor

I tested this PR in my centos vm and it has passed.
Due to lack of the MacOS, I haven't test the -all_load link option for lacking of macos.

@shihai1991shihai1991 mentioned this pull request Dec 1, 2021
Closed
tiran
tiran requested changes Dec 4, 2021
View reviewed changes
Comment threadconfigure
Comment threadconfigure Outdated
@bedevere-bot

bedevere-bot commented Dec 4, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@github-actions

github-actionsBot commented Jan 5, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsBot added the stale Stale PR or inactive for long period of time. label Jan 5, 2022
@shihai1991

shihai1991 commented Jan 11, 2022

Copy link
Copy Markdown
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Jan 11, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@vstinner

vstinner commented Jan 11, 2022

Copy link
Copy Markdown
Member

I suggest to not use libpython.a to build the python executable, but pass directly the long list of object filenames (.o).

@shihai1991

shihai1991 commented Jan 12, 2022

Copy link
Copy Markdown
MemberAuthor

I suggest to not use libpython.a to build the python executable, but pass directly the long list of object filenames (.o).

OK, it's would be more direct.

@vstinner

vstinner commented Jan 12, 2022•
edited
Loading

Copy link
Copy Markdown
Member

I wrote PR #30556 to propose my idea.

@vstinner

vstinner commented Jan 13, 2022

Copy link
Copy Markdown
Member

The problem of this approach is that the -Wl,--whole-archive flag is not portable. That's why you had to use -Wl,-all_load for example.

I wrote a different approach which simply skips the static Python library: GH-30556.

@vstinnervstinner mentioned this pull request Apr 29, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukouencukouAwaiting requested review from encukou
@vstinnervstinnerAwaiting requested review from vstinner
@tirantiranAwaiting requested review from tiran

Assignees

No one assigned

Labels

awaiting change reviewstaleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shihai1991@bedevere-bot@vstinner@tiran@encukou@the-knights-who-say-ni