Uh oh!
There was an error while loading. Please reload this page.
bpo-45711: Do not push/pop traceback on stack as part of exc_info - #29968
bpo-45711: Do not push/pop traceback on stack as part of exc_info#29968iritkatriel wants to merge 5 commits into
Conversation
iritkatriel
commented
Dec 7, 2021
Marked as draft because I still need to update the opcodes documentation |
| assert(exc_info->exc_value); | ||
| if (exc_info->exc_value != Py_None) { | ||
| exc_info->exc_traceback = PyException_GetTraceback(exc_info->exc_value); |
There was a problem hiding this comment.
The next step is to remove exc_traceback from exc_info and then this will not be here.
bedevere-bot
commented
Dec 7, 2021
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 98085fe 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
iritkatriel
commented
Dec 7, 2021
This clashes with the except* branch, and I'd rather merge that one first and update this one. |
markshannon
commented
Dec 8, 2021
I would rather merge this first. |
iritkatriel
commented
Dec 8, 2021
We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together. |
iritkatriel
commented
Dec 8, 2021
And that requires PR 29922. |
arhadthedev
left a comment
There was a problem hiding this comment.
Spacing between tokens is strange.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
iritkatriel
commented
Dec 15, 2021
Superseded by #30122 |
https://bugs.python.org/issue45711