Skip to content

bpo-45711: Do not push/pop traceback on stack as part of exc_info - #29968

Closed
iritkatriel wants to merge 5 commits into
python:mainfrom
iritkatriel:45711-no-traceback-in-stack
Closed

bpo-45711: Do not push/pop traceback on stack as part of exc_info#29968
iritkatriel wants to merge 5 commits into
python:mainfrom
iritkatriel:45711-no-traceback-in-stack

Conversation

@iritkatriel

@iritkatrieliritkatriel commented Dec 7, 2021

Copy link
Copy Markdown
Member

@iritkatriel

Copy link
Copy Markdown
MemberAuthor

Marked as draft because I still need to update the opcodes documentation

Comment threadPython/ceval.c

assert(exc_info->exc_value);
if (exc_info->exc_value != Py_None) {
exc_info->exc_traceback = PyException_GetTraceback(exc_info->exc_value);

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next step is to remove exc_traceback from exc_info and then this will not be here.

@iritkatrieliritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 7, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 98085fe 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 7, 2021
@iritkatriel
iritkatriel marked this pull request as ready for review December 7, 2021 18:15
@iritkatriel

Copy link
Copy Markdown
MemberAuthor

This clashes with the except* branch, and I'd rather merge that one first and update this one.

@markshannon

Copy link
Copy Markdown
Member

This clashes with the except* branch, and I'd rather merge that one first and update this one.

I would rather merge this first.
Apart from the trivial conflict in dis.rst this seems ready to merge. The except* branch is not.

@iritkatriel

Copy link
Copy Markdown
MemberAuthor

This clashes with the except* branch, and I'd rather merge that one first and update this one.

I would rather merge this first. Apart from the trivial conflict in dis.rst this seems ready to merge. The except* branch is not.

We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together.

@iritkatriel

Copy link
Copy Markdown
MemberAuthor

We won't see a speedup for this because of the get_exc_traceback calls. We should remove them before measuring, and probably merge the whole thing together.

And that requires PR 29922.

@arhadthedevarhadthedev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing between tokens is strange.

Comment threadPython/compile.c Outdated
Comment threadPython/ceval.c Outdated
Comment threadPython/ceval.c Outdated
@iritkatriel

Copy link
Copy Markdown
MemberAuthor

Superseded by #30122

@iritkatriel
iritkatriel deleted the 45711-no-traceback-in-stack branch January 13, 2022 15:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@iritkatriel@bedevere-bot@markshannon@arhadthedev@the-knights-who-say-ni