Uh oh!
There was an error while loading. Please reload this page.
bpo-45711: Remove type and traceback from exc_info - #30122
Conversation
Uh oh!
There was an error while loading. Please reload this page.
bedevere-bot
commented
Dec 15, 2021
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 9b04160 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
| /* number of items stored in the stack for each exception */ | ||
| #define PY_EXC_INFO_STACK_SIZE 1 |
There was a problem hiding this comment.
Is this necessary now?
I don't see why we would ever want to increase it, and I don't see how we could ever decrease it.
There was a problem hiding this comment.
The name is probably weird now, but I think it helps readability to have a macro. If we remove this we should find another way to make the code (particularly in compile.c) clear about where exceptions are showing up. Figuring out where to use this macro was the hardest part of making this change (because when you get it wrong it just segfaults before you finish make regen-all).
There was a problem hiding this comment.
On second thought there is no point in a macro for this unless we all agree on some kind of convention because it probably won't be updated correctly when people make changes. So I'll remove it.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
markshannon
commented
Dec 16, 2021
This is great. 🍾 Removes code, should make any exception handling code faster and reduces stack consumption; the perfect combination. |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
iritkatriel
commented
Dec 17, 2021
The windows test failure is unrelated File "D:\a\cpython\cpython\Lib\test\support_init_.py", line 197, in _force_run |
markshannon
commented
Dec 17, 2021
Excellent. |
https://bugs.python.org/issue45711