Uh oh!
There was an error while loading. Please reload this page.
gh-91265: Make old ctypes.macholib tests runned by python -m test - #32094
Conversation
python -m testpython -m testpython -m testMaxwellDupre
commented
Mar 26, 2022
After rebuild against this PR: tests: Or |
python -m testpython -m testarhadthedev
commented
Apr 12, 2022
Ping. This PR doesn't add extra logic, it just collects stuff into |
ronaldoussoren
left a comment
There was a problem hiding this comment.
I finally had some time to seriously look at this. The PR looks good to me, as the description says this moves some tests to explicit test files to ensure they are picked up by the regular test runs.
ronaldoussoren
commented
Apr 17, 2022
@arhadthedev : Sorry about the delay in reviewing, I had to find some time to seriously look at this and be sure that tests are correctly moved. Did you sign the CLA? The CLA check is blocking the merge of your PR. |
arhadthedev
commented
Apr 17, 2022
No worries! The issue needed the chance to collect feedback anyway.
Yes, both on the bpo (https://bugs.python.org/user40922) and after the migration (#91453 (comment), I'm one of authors there). So it's just a matter of waiting for the bot to be sorted out. P. S.: @ronaldoussoren (because I know that the "Mentioned" queue is an order of magnitude less that the "Participating" one). |
arhadthedev
commented
Apr 17, 2022
@ronaldoussoren I've reopened the PR to retrigger the bot; it worked. |
Some tests for
ctypes.macholib.dyldand all tests forctypes.macholib.dylibandctypes.macholib.frameworkare located outside of expectedctypes.testmodule and were not ported fromasserttounittestfacilities. This causes the following problems:python -m testso they are effectively deadpython -m ctypes.macholib.dyld,python -m ctypes.macholib.dylib, andpython -m ctypes.macholib.frameworkThis PR moves these tests into
ctypes.test.test_macholibsuit and wraps them asunittest.TestCase.I believe this PR should be backported to not export unintended features in unintended places.
FixesGH-91265.