Skip to content

gh-79156: Add start_tls() method to streams API - #91453

Merged
ambv merged 2 commits into
python:mainfrom
arhadthedev:asyncio-starttls
Apr 15, 2022
Merged

gh-79156: Add start_tls() method to streams API#91453
ambv merged 2 commits into
python:mainfrom
arhadthedev:asyncio-starttls

Conversation

@arhadthedev

@arhadthedevarhadthedev commented Apr 11, 2022

Copy link
Copy Markdown
Member

A reupload of gh-13143 with the ported whatsnew since the original author is waiting for three years already. For strange reason, the original branch is missing and the PR has no corresponding "{username} deleted the {branch} branch" notification line.

The PR is revived after a thread on python-dev:

Oleg Iarygin

Hi everyone,

Can PR gh-13143 be reopened and reviewed/merged when possible? It was closed in favor of the new asyncio streams API (gh-13251). Later, the API was cleanly removed (gh-16482) so the proposed PR became relevant again.

The added method allows to turn encryption on on demand (and off, as the author expressed his readiness). It's required for a CPython test suit, to port test.test_ftplib.DummyFTPServer from asyncore/asynchat before their removal according to PEP 594 (Removing dead batteries from the standard library).

Thank you in advance.

Jelle Zijlstra

I can't reopen the PR; I assume the branch was deleted. It's going to be easier to just open a new PR.

Linked to gh-79156; the original issue may be closed with the following stop_tls() PR.

Co-authored-by: Ian Good icgood@gmail.com

@icgood@arhadthedev
bpo-34975: Add start_tls() method to streams API
7df8b86
The existing event loop `start_tls()` method is not sufficient for
connections using the streams API. The existing StreamReader works
because the new transport passes received data to the original protocol.
The StreamWriter must then write data to the new transport, and the
StreamReaderProtocol must be updated to close the new transport
correctly.
The new StreamWriter `start_tls()` updates itself and the reader
protocol to the new SSL transport.
@ghost

ghost commented Apr 11, 2022•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@arhadthedev

arhadthedev commented Apr 11, 2022

Copy link
Copy Markdown
MemberAuthor

Ian Good signed the CLA before publishing the original PR.

@AlexWaygood

AlexWaygood commented Apr 11, 2022

Copy link
Copy Markdown
Member

Ian Good signed the CLA before publishing the original PR.

Cc. @ambv

@ambv

ambv commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

Sorry for the trouble! I'm off work now, I added this case to look at tomorrow morning.

@arhadthedev
arhadthedev marked this pull request as draft April 11, 2022 20:38
@arhadthedev
arhadthedev marked this pull request as ready for review April 12, 2022 06:00
@arhadthedev

arhadthedev commented Apr 12, 2022

Copy link
Copy Markdown
MemberAuthor

Fixed a usage of the loop parameter removed in 3.10. Ready for review.

@icgood

icgood commented Apr 15, 2022

Copy link
Copy Markdown
Contributor

Just noticed this -- @arhadthedev@ambv anything I can do to help?

@ambv

ambv commented Apr 15, 2022

Copy link
Copy Markdown
Contributor

@icgood, can you click on the red button in #91453 (comment) to re-sign the CLA?

@ambv
ambv merged commit 6217864 into python:mainApr 15, 2022
@arhadthedev
arhadthedev deleted the asyncio-starttls branch April 15, 2022 12:28
@arhadthedev

arhadthedev commented Apr 15, 2022

Copy link
Copy Markdown
MemberAuthor

@ambv Thank you a lot for merging!

The paired function, shutdown_tls is on the way. After that I'll close the issue.

kumaraditya303
kumaraditya303 reviewed Apr 15, 2022
View reviewed changes
Comment threadDoc/library/asyncio-stream.rst
handshake to complete before aborting the connection. ``60.0`` seconds
if ``None`` (default).

.. versionadded:: 3.8

@kumaraditya303kumaraditya303Apr 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 3.11 isn't it ?

@ambvambvApr 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, missed it. Good catch, @kumaraditya303. @arhadthedev, you could fix this while working on shutdown_tls.

@arhadthedevarhadthedev mentioned this pull request Apr 17, 2022
Merged
@kumaraditya303kumaraditya303 mentioned this pull request May 20, 2022
Closed
@ghostghost mentioned this pull request Aug 8, 2022
Open
2 tasks
@arhadthedevarhadthedev mentioned this pull request Oct 4, 2022
Closed
@gvanrossumgvanrossum mentioned this pull request Oct 4, 2022
Closed
@kumaraditya303kumaraditya303 mentioned this pull request Dec 17, 2025
Merged
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambvambvambv left review comments
@kumaraditya303kumaraditya303kumaraditya303 left review comments
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner
+1 more reviewer
@icgoodicgoodicgood approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@arhadthedev@AlexWaygood@ambv@icgood@kumaraditya303@bedevere-bot