Skip to content

gh-89301: Fix regression with bound values in traced SQLite statements - #92053

Merged
JelleZijlstra merged 3 commits into
python:mainfrom
erlend-aasland:sqlite-fix-trace
May 2, 2022
Merged

gh-89301: Fix regression with bound values in traced SQLite statements#92053
JelleZijlstra merged 3 commits into
python:mainfrom
erlend-aasland:sqlite-fix-trace

Conversation

@erlend-aasland

@erlend-aaslanderlend-aasland commented Apr 29, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Resolvesgh-89301

@erlend-aaslanderlend-aasland added needs backport to 3.10 only security fixes 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Apr 29, 2022
@bedevere-bot

bedevere-bot commented Apr 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit ab35f4b 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2022
@erlend-aasland
Make exception string greppable
4e9ef10
@erlend-aasland
Simplify test
e58797c
SQLite seems to have slightly inconsisten behaviour when it comes to
enforcing limits. It might have something to do with the SQLite compile
time options, or it may be a bug. Simplifying the test seems to work
in different environments.
@erlend-aaslanderlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 2, 2022
@bedevere-bot

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit e58797c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 2, 2022
@erlend-aasland
erlend-aasland marked this pull request as ready for review May 2, 2022 13:34
@erlend-aasland
erlend-aasland requested review from JelleZijlstra and removed request for berkerpeksagMay 2, 2022 13:34
@erlend-aasland

erlend-aasland commented May 2, 2022

Copy link
Copy Markdown
ContributorAuthor

FYI, AMD64 Fedora Stable Refleaks PR failed test_embed, so that looks unrelated.

@erlend-aasland

erlend-aasland commented May 2, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

FTR, this is pretty much the same as GH-28240, but with better tests and a more accurate NEWS entry.

@JelleZijlstra
JelleZijlstra merged commit 721aa96 into python:mainMay 2, 2022
@miss-islington

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 721aa96540bb96700f8c4bab0b4095b43491dca1 3.10

@erlend-aasland
erlend-aasland deleted the sqlite-fix-trace branch May 2, 2022 14:15
@erlend-aasland

erlend-aasland commented May 2, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks, I'll fix the backport.

@ZeroIntensityZeroIntensity removed the needs backport to 3.10 only security fixes label Feb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

Assignees

@JelleZijlstraJelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3 regression: bound values are not expanded in traced statements

5 participants

@erlend-aasland@bedevere-bot@miss-islington@JelleZijlstra@ZeroIntensity