gh-93243: Make smtpd private before porting its users by arhadthedev · Pull Request #93246 · python/cpython

arhadthedev · 2022-05-26T06:49:39Z

This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smtpd in a single PR).

Automerge-Triggered-By: GH:warsaw

AA-Turner

Some docs/wording comments:

A

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

hugovk · 2022-06-04T20:08:16Z

cc also PEP-594 co-author @brettcannon.

brettcannon

Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.

bedevere-bot · 2022-06-08T20:24:36Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

arhadthedev · 2022-06-08T21:17:37Z

I have made the requested changes; please review again.

bedevere-bot · 2022-06-08T21:17:41Z

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

arhadthedev · 2022-07-29T11:49:10Z

Probably need logging and email maintainers to sign off that they are okay with keeping smptd around for testing.

@vsajip @warsaw could you review and possibly merge this PR please? It deletes smtpd tests in advance and, for consistency, makes the module private by moving it into Lib/test/smtpd.py.

This is necessary to allow further reviewable-sized PRs (one for each SMTP* class moved into its consumer in test) without massive changes of Lib/test/test_smtpd.py for synchronization.

warsaw

I have a small rewording request.

bedevere-bot · 2022-08-04T18:41:48Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

arhadthedev · 2022-08-04T19:25:17Z

I have made the requested changes; please review again.

bedevere-bot · 2022-08-04T19:25:21Z

Thanks for making the requested changes!

@brettcannon, @warsaw: please review the changes made to this pull request.

Wording suggestion.

brettcannon · 2022-08-05T22:53:30Z

@warsaw not sure if this is showing up in your review queue as the GH UI is not letting me re-request your review.

Small reword suggestion.

warsaw · 2022-08-06T00:17:34Z

Thanks for the ping @brettcannon - I'm good with this, with my one edit to the source branch. I thought I'd pushed that through previously, but upon further review, it doesn't look like it stuck. Trying that again...

warsaw

Okay, this time it looks like my small wording edit got committed. Thanks for the contribution @arhadthedev ! Approving and setting the automerge label.

miss-islington · 2022-08-06T00:41:28Z

Status check is done, and it's a success ✅ .

…-93246) pythongh-93243 This PR is required to reduce diffs of the following porting (no need to either maintain documentation and tests consistent with each porting step, or try to port everything and remove smtpd in a single PR). Automerge-Triggered-By: GH:warsaw

pythongh-93243: Make smtpd private to port its users
021e85c

arhadthedev requested review from a team and vsajip as code owners May 26, 2022 06:49

bedevere-bot added the awaiting review label May 26, 2022

hugovk reviewed Jun 4, 2022
View reviewed changes

Comment threadPCbuild/lib.pyproj

arhadthedev added 4 commits June 4, 2022 16:24

Merge branch 'main' into privatize-smtpd
ed21b2b

Move smtpd to its only user for further porting to asyncio
18a5615

Point test_logging to the new smtpd location too
6f2c565

Remove smptd from standalone module lists
f5aee16

AA-Turner reviewed Jun 4, 2022
View reviewed changes

Comment threadDoc/whatsnew/3.12.rst Outdated
Comment threadDoc/whatsnew/3.12.rst Outdated
Comment threadLib/test/mock_socket.py Outdated
Comment threadLib/test/mock_socket.py Outdated
Comment threadMisc/NEWS.d/next/Library/2022-05-26-08-41-34.gh-issue-93243.uw6x5z.rst Outdated

arhadthedevand others added 4 commits June 4, 2022 19:01

Update Doc/whatsnew/3.12.rst
c7cb1e3
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Update Doc/whatsnew/3.12.rst
8180429
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Address the review of AA-Turner (using suggestion batching)
b70bf5a
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Remove non-working :mod:
4054ac2

AA-Turner reviewed Jun 4, 2022
View reviewed changes

Comment threadDoc/whatsnew/3.12.rst Outdated

Update Doc/whatsnew/3.12.rst
eb6ad56
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

brettcannon requested changes Jun 8, 2022
View reviewed changes

Comment threadLib/test/test_logging.py

bedevere-bot removed the awaiting review label Jun 8, 2022

bedevere-bot added the awaiting changes label Jun 8, 2022

Address@brettcannon's review
133735a

bedevere-bot added awaiting change review and removed awaiting changes labels Jun 8, 2022

bedevere-bot requested a review from brettcannon June 8, 2022 21:17

arhadthedev added 2 commits June 23, 2022 23:43

Merge branch 'main' into privatize-smtpd
38fd57b

Merge branch 'main' into privatize-smtpd
1f839b9

Merge branch 'main' into privatize-smtpd
7423617

warsaw requested changes Aug 4, 2022
View reviewed changes

Comment threadDoc/whatsnew/3.12.rst Outdated

bedevere-bot removed the awaiting change review label Aug 4, 2022

bedevere-bot added the awaiting changes label Aug 4, 2022

Address the Barry's review
815cb7c

bedevere-bot added awaiting change review and removed awaiting changes labels Aug 4, 2022

bedevere-bot requested a review from warsaw August 4, 2022 19:25

Update 3.12.rst
e351af3
Wording suggestion.

Update 3.12.rst
1d157ec
Small reword suggestion.

warsaw added the 🤖 automerge label Aug 6, 2022

warsaw approved these changes Aug 6, 2022
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Aug 6, 2022

miss-islington merged commit 56d16e8 into python:mainAug 6, 2022

bedevere-bot removed the awaiting merge label Aug 6, 2022

arhadthedev deleted the privatize-smtpd branch August 7, 2022 06:55

sobolevn mentioned this pull request Sep 5, 2022
gh-72719: Remove deprecated asyncore and asynchat modules #96580
Merged

arhadthedev mentioned this pull request Oct 6, 2022
tests still rely on the removed stdlib modules asyncore/asynchat #93243
Closed
12 tasks

hugovk mentioned this pull request Oct 28, 2022
Remove PCbuild/lib.pyproj #98817
Closed

vstinner mentioned this pull request Nov 8, 2022
Remove asyncore, asynchat and smtpd modules #72719
Closed

sobolevn mentioned this pull request Jan 21, 2024
gh-108303: Move smtpd to test.support#114368
Merged

Uh oh!

Uh oh!

Conversation

arhadthedev commented May 26, 2022• edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

AA-Turner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hugovk commented Jun 4, 2022

Uh oh!

brettcannon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Jun 8, 2022

Uh oh!

arhadthedev commented Jun 8, 2022

Uh oh!

bedevere-bot commented Jun 8, 2022

Uh oh!

arhadthedev commented Jul 29, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

warsaw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Aug 4, 2022

Uh oh!

arhadthedev commented Aug 4, 2022

Uh oh!

bedevere-bot commented Aug 4, 2022

Uh oh!

brettcannon commented Aug 5, 2022

Uh oh!

warsaw commented Aug 6, 2022

Uh oh!

warsaw left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Aug 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

arhadthedev commented May 26, 2022•
edited by miss-islington
Loading

arhadthedev commented Jul 29, 2022•
edited
Loading