gh-72719: Remove deprecated `asyncore` and `asynchat` modules by sobolevn · Pull Request #96580 · python/cpython

sobolevn · 2022-09-05T14:18:48Z

Several notes:

I followed the same path as smtpd in gh-93243: Make smtpd private before porting its users #93246 It was suggested in Remove asyncore, asynchat and smtpd modules #72719 (comment) by @vstinner
I've added TODO items about completely removing these modules in the future

Issue: Remove asyncore, asynchat and smtpd modules #72719

arhadthedev · 2022-09-25T05:09:33Z

I think it would be great to have this PR merged before 3.12.0a1 (3 October, 2022, after 7 days) to allow third party library maintainers and early adopters to report scenarios possible in asyncore but not in asyncio as soon as possible.

sobolevn · 2022-09-25T05:51:05Z

Ping @pablogsal as release manager 🙂

pablogsal · 2022-09-25T11:58:12Z

Ping @pablogsal as release manager 🙂

Thanks for checking with me! One note, the RM for 3.12 is @Yhg1s so he should probably also take a look

bedevere-bot · 2022-09-25T12:37:44Z

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 99e3de9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

arhadthedev · 2022-10-06T10:47:00Z

@Yhg1s Is there any chance to get this PR accepted into 3.12.0a1? It seems we've got some extra time until the release blockers are resolved.

…pzF3.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

vstinner · 2022-11-03T16:40:00Z

@@ -0,0 +1,3 @@
+Remove modules :mod:`asyncore` and :mod:`asynchat`, which were deprecated by :pep:`594`.
+
+They are temporarily moved to :mod:`test.support` so some other tests that rely on them keep working.


I suggest to remove the second sentence. I prefer to hide them as well as possible :-)

Done, thank you for the review!

vstinner

Please remove last references:

Doc/library/socketserver.rst
Doc/license.rst: update the module names

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

vstinner · 2022-11-07T16:45:16Z

When I removed the module last year (commit), I even renamed the asyncore module to test.support._asyncore. But I don't mind to call it test.support.asyncore.

giampaolo · 2022-11-07T16:50:43Z

@giampaolo: Would you be ok to be removed from github/CODEOWNERS for asyncore/asynchat, so these files should not longer be updated but just die?

sure, no problem

sobolevn · 2022-11-07T18:15:17Z

Done, all three - removed!

vstinner

Oh, there is now a conflict. Can you try to rebase your PR? Or try to merge main into your PR?

Please keep the license, files are still around, they are just moved somewhere else.

vstinner

LGTM.

vstinner · 2022-11-08T15:58:15Z

Merged, thanks. Let's see how it goes with Python 3.12.

sobolevn · 2022-11-08T16:55:48Z

Thank you for your guidance and help!
I feel happy now, removing old stuff is my kinda thing 😊 🎉

vstinner · 2022-11-08T17:00:25Z

See also the discussion: Collaboration on handling Python 3.12 incompatible changes (distutils removal, invalid escape escape, etc.).

sobolevn requested review from a team and vsajip as code owners September 5, 2022 14:18

bedevere-bot added the awaiting review label Sep 5, 2022

sobolevn commented Sep 5, 2022
View reviewed changes

Comment thread.github/CODEOWNERS

sobolevn force-pushed the issue-72719 branch 2 times, most recently from 92a5bab to 97d7bc8Compare September 5, 2022 14:29

sobolevn requested a review from giampaolo September 5, 2022 14:31

theLastOfCats reviewed Sep 5, 2022
View reviewed changes

Comment threadDoc/whatsnew/3.12.rst Outdated

pythongh-72719: Remove deprecatedasyncoreandasynchatmodules
99e3de9

sobolevn force-pushed the issue-72719 branch from 113731a to 99e3de9Compare September 5, 2022 14:55

sobolevn added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 25, 2022

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 25, 2022

arhadthedev mentioned this pull request Oct 3, 2022
tests still rely on the removed stdlib modules asyncore/asynchat #93243
Closed
12 tasks

JelleZijlstra reviewed Oct 7, 2022
View reviewed changes

Comment threadMisc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jUpzF3.rst Outdated

Update Misc/NEWS.d/next/Library/2022-09-05-17-08-56.gh-issue-72719.jU…
9a49615
…pzF3.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

hugovk reviewed Oct 28, 2022
View reviewed changes

Comment threadDoc/whatsnew/3.12.rst

Address review
4b7d32d

hugovk mentioned this pull request Oct 28, 2022
Remove PCbuild/lib.pyproj #98817
Closed

sobolevn mentioned this pull request Oct 29, 2022
asyncore and asynchat will be removed in 3.12 python/typeshed#9033
Merged

vstinner reviewed Nov 3, 2022
View reviewed changes

Address review
968ef31

bedevere-bot mentioned this pull request Nov 5, 2022
Remove asyncore, asynchat and smtpd modules #72719
Closed

vstinner reviewed Nov 7, 2022
View reviewed changes

Remove last mentions of modules
c50f6b7

sobolevn requested a review from ezio-melotti as a code owner November 7, 2022 18:15

vstinner reviewed Nov 7, 2022
View reviewed changes

Comment threadDoc/license.rst

sobolevn added 2 commits November 8, 2022 14:56

Merge main into issue-72719
c1b225b

Restore license
ecd04df

vstinner approved these changes Nov 8, 2022
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Nov 8, 2022

vstinner merged commit e56e33d into python:mainNov 8, 2022

bedevere-bot removed the awaiting merge label Nov 8, 2022

opoplawski mentioned this pull request Apr 1, 2023
[BR]: Fails to build with Python 3.12 - ModuleNotFoundError: No module named 'asynchat' fail2ban/fail2ban#3487
Closed

arhadthedev mentioned this pull request May 25, 2023
gh-82082: Make our test suite pass on an IPv6-only Linux host #26225
Closed

honglei mentioned this pull request Jun 18, 2023
asyncore and asynchat may be removed from python 3.11 stdlib giampaolo/pyftpdlib#560
Closed

thebeanogamer mentioned this pull request Jul 16, 2023
Use of Deprecated PySNMP Listener dell/omsdk#37
Open

This comment was marked as off-topic.
Sign in to view

		@@ -0,0 +1,3 @@
		Remove modules :mod:`asyncore` and :mod:`asynchat`, which were deprecated by :pep:`594`.

		They are temporarily moved to :mod:`test.support` so some other tests that rely on them keep working.

Uh oh!

Uh oh!

Conversation

sobolevn commented Sep 5, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arhadthedev commented Sep 25, 2022

Uh oh!

sobolevn commented Sep 25, 2022

Uh oh!

pablogsal commented Sep 25, 2022

Uh oh!

bedevere-bot commented Sep 25, 2022

Uh oh!

arhadthedev commented Oct 6, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinnerNov 3, 2022

Choose a reason for hiding this comment

Uh oh!

sobolevnNov 5, 2022

Choose a reason for hiding this comment

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Nov 7, 2022

Uh oh!

giampaolo commented Nov 7, 2022

Uh oh!

sobolevn commented Nov 7, 2022

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Nov 8, 2022

Uh oh!

sobolevn commented Nov 8, 2022

Uh oh!

vstinner commented Nov 8, 2022

Uh oh!

This comment was marked as off-topic.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

sobolevn commented Sep 5, 2022•
edited
Loading