Skip to content

Update translation/translators.rst - #1576

Merged
willingc merged 9 commits into
python:mainfrom
StanFromIreland:translating
Jun 20, 2025
Merged

Update translation/translators.rst#1576
willingc merged 9 commits into
python:mainfrom
StanFromIreland:translating

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Jun 16, 2025

Copy link
Copy Markdown
Member

This is a very rough draft that has been opened for the purpose of asking some questions and is subject to a lot of change, some of which I have already done locally.

There are some small changes to coordinating.rst in this pull request which came up as I was working on this.

cc @willingc


📚 Documentation preview 📚: https://cpython-devguide--1576.org.readthedocs.build/documentation/translations

Comment threaddocumentation/translations/translating.rst Outdated
Comment on lines +35 to +36
- `AFPy/python-docs-fr <https://git.afpy.org/AFPy/python-docs-fr/>`_
:github:`Mirror <python/python-docs-fr>`

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @JulienPalard Is this correct, it is what I gathered from the repositories though it is in French so I may be wrong?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. French translation happens at AFPy's Gitea and are simply mirrored to GitHub.

Instead of "GitHub" or "AFPy", there could be "repo" or "repository" text which links to the proper translation repository (for all rows in the table). Please add a comma before "Mirror"

Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment on lines +35 to +36
- `AFPy/python-docs-fr <https://git.afpy.org/AFPy/python-docs-fr/>`_
:github:`Mirror <python/python-docs-fr>`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. French translation happens at AFPy's Gitea and are simply mirrored to GitHub.

Instead of "GitHub" or "AFPy", there could be "repo" or "repository" text which links to the proper translation repository (for all rows in the table). Please add a comma before "Mirror"

Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threadcore-developers/experts.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
@StanFromIreland
StanFromIreland marked this pull request as ready for review June 17, 2025 10:20
rffontenelle
rffontenelle previously requested changes Jun 17, 2025
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated

@willingcwillingc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @StanFromIreland, I rereviewed. Thanks for putting together. I have only one small grammar nit and a question about max depth. Neither are blockers so I'm going to approve this PR. After I hear back from you or others, I am happy to merge.

Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/index.rst Outdated
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
@m-aciek

Copy link
Copy Markdown
Contributor

Thank you for your work on it! I've left some comments.

Comment threaddocumentation/translations/index.rst Outdated
Comment threaddocumentation/translations/translating.rst
Comment threaddocumentation/translations/translating.rst Outdated
@StanFromIreland
StanFromIreland requested review from JulienPalard and rffontenelle and removed request for rffontenelleJune 20, 2025 08:21

@m-aciekm-aciek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments, answering some of the replies.

Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst
hugovk
hugovk previously requested changes Jun 20, 2025
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst Outdated
Comment threaddocumentation/translations/translating.rst

@willingcwillingc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that we incorporate some of @hugovk's suggestions. Thanks @StanFromIreland.

Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst
@willingc

Copy link
Copy Markdown
Collaborator

@hugovk I'm leaving this in your capable hands to merge when your suggestions are incorporated. @StanFromIreland Thanks for working together with folks on the review. I'm loving how these docs are coming together.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@willingc
willingc dismissed stale reviews from hugovk and rffontenelleJune 20, 2025 19:26

Suggestions were added and #1585 added to address the build scripts suggestion.

@willingc
willingc merged commit 3a8b71e into python:mainJun 20, 2025
@willingc

Copy link
Copy Markdown
Collaborator

Thanks @StanFromIreland and to everyone who reviewed this PR. Working together we now have much clearer info for coordinators and translators. 🚀 Keep up the collaboration. ☀️

@StanFromIreland
StanFromIreland deleted the translating branch June 20, 2025 19:38
@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

Many thanks to everyone who reviewed!

@rffontenelle

Copy link
Copy Markdown
Contributor

Thanks @StanFromIreland and everyone that contributed for improving translation docs!

@hugovk

Copy link
Copy Markdown
Member

@StanFromIreland Please could you check the new warnings?

contrib/doc/translating.rst:12: WARNING: undefined label: 'translating' [ref.ref]
contrib/index.rst:78: WARNING: unknown document: 'documentation/translations' [ref.doc]
index.rst:179: WARNING: undefined label: 'translating' [ref.ref]

@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

@hugovk They are addressed in #1587 I can move them to a separate pr if you want?

@hugovk

Copy link
Copy Markdown
Member

It can wait, thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@StanFromIreland@m-aciek@willingc@rffontenelle@hugovk@nedbat