Skip to content

Update translations/coordinating.rst - #1587

Merged
encukou merged 10 commits into
python:mainfrom
StanFromIreland:coordinating
Aug 18, 2025
Merged

Update translations/coordinating.rst#1587
encukou merged 10 commits into
python:mainfrom
StanFromIreland:coordinating

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Jun 23, 2025

Copy link
Copy Markdown
Member

This page is aimed at coordinators, so I assume some git/gh knowledge etc.

Some things that need to be discussed:

closes#1586


📚 Documentation preview 📚: https://cpython-devguide--1587.org.readthedocs.build/

Comment threaddocumentation/translations/coordinating.rst Outdated
@StanFromIreland

StanFromIreland commented Jun 24, 2025

Copy link
Copy Markdown
MemberAuthor

While this has to wait for a pending issue, other discussion should continue. These are comments I left in the file in the format, XXX thought.

Requesting @rffontenelle and @m-aciek

@StanFromIreland
StanFromIreland marked this pull request as ready for review June 24, 2025 19:06

@rffontenellerffontenelle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs. Please find some notes below

Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

Thanks for the review.

I should have my editor highlight it in red:-)

Comment threaddocumentation/translations/coordinating.rst
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst
Comment threaddocumentation/translations/coordinating.rst
Comment threaddocumentation/translations/coordinating.rst
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
@StanFromIreland

StanFromIreland commented Aug 5, 2025

Copy link
Copy Markdown
MemberAuthor

Since this pr is taking a while (due to it's size already), we can leave the todos that need discussion to follow ups. Would it be possible to get a review @willingc?

Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Comment threaddocumentation/translations/coordinating.rst Outdated
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

Thanks for making them suggestions!

@willingc

Copy link
Copy Markdown
Collaborator

Thanks @hugovk for reviewing. I tried to review this morning and hit 500 errors from GitHub. Will review now.

@willingcwillingc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StanFromIreland for making these changes.

@StanFromIreland

Copy link
Copy Markdown
MemberAuthor

Anything left to do to get this merged?

@encukou
encukou merged commit b0aefe9 into python:mainAug 18, 2025
4 checks passed
@StanFromIreland
StanFromIreland deleted the coordinating branch August 18, 2025 14:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants

@StanFromIreland@willingc@hugovk@rffontenelle@m-aciek@ezio-melotti@encukou