Skip to content

Do not rebuild when it's not needed (like there's no updates). - #171

Merged
JulienPalard merged 8 commits into
python:mainfrom
JulienPalard:mdk-no-rerun
Oct 20, 2023
Merged

Do not rebuild when it's not needed (like there's no updates).#171
JulienPalard merged 8 commits into
python:mainfrom
JulienPalard:mdk-no-rerun

Conversation

@JulienPalard

@JulienPalardJulienPalard commented Oct 15, 2023

Copy link
Copy Markdown
Member

Beware it's based on the unmerged config branch...

@JulienPalardJulienPalard mentioned this pull request Oct 15, 2023
Merged
@egeakman

egeakman commented Oct 15, 2023

Copy link
Copy Markdown
Contributor

See #169

@JulienPalard
JulienPalardforce-pushed the mdk-no-rerun branch 2 times, most recently from 62226cb to c6c75d2CompareOctober 17, 2023 20:20
@JulienPalard

JulienPalard commented Oct 18, 2023

Copy link
Copy Markdown
MemberAuthor

The state file should also remember the release-cycle.json "content"/hash/whatever, because if this file change ALL release have to be built again in order to update the version picker and the sidebar of all versions.

@JulienPalardJulienPalard mentioned this pull request Oct 19, 2023
Open
@JulienPalardJulienPalard changed the title [WIP] Do not rebuild when it's not needed (like there's no updates).Do not rebuild when it's not needed (like there's no updates).Oct 19, 2023
@JulienPalard

JulienPalard commented Oct 19, 2023

Copy link
Copy Markdown
MemberAuthor

I'm running it successfully on my machine, even if it miss a few things like a full rebuild when version changes, I'd like to merge the current version to see it behave in real conditions.

It logs nicely, like:

INFO ja/3.11: Should rebuild: new translations (from 2ff0f1c8335c696c87310d38dee7e73dd8105e36 to 3ffb0b0eb9687707ffb0c2a01cb32bba7825b5d8)
INFO zh-tw/3.12: Should rebuild: Doc/ has changed (from 228b12493286a7cb959438cd5b1a018e0afb17a8 to e37d56e8ddb8a95ab71d0eaba98c5be326428061)
INFO tr/3.11: Nothing changed, no rebuild needed.
INFO pt-br/3.11: Nothing changed, no rebuild needed.

@egeakman

egeakman commented Oct 19, 2023

Copy link
Copy Markdown
Contributor

I agree, let's merge it and see how well it performs 👍

@JulienPalard
JulienPalard merged commit f27dbeb into python:mainOct 20, 2023
@JulienPalard
JulienPalard deleted the mdk-no-rerun branch October 20, 2023 12:12
This was referenced Oct 21, 2023
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JulienPalard@egeakman