Uh oh!
There was an error while loading. Please reload this page.
Move final detection for Enum in checker.py - #11984
Merged
Merged
Conversation
JukkaL
approved these changes
Jan 17, 2022
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good! It makes sense to do these checks during type checking. Left a few nits; feel to merge when you've addressed them (and fixed the merge conflict).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
Fixed merge conflicts, rebased, waiting for the CI to pass and merging 🎉 |
sobolevn
commented
Jan 18, 2022
MemberAuthor
@JukkaL I am going to use these guidelines for merging process: https://github.com/python/mypy/blob/master/CONTRIBUTING.md#core-developer-guidelines |
sobolevn
commented
Jan 18, 2022
MemberAuthor
Done! My first merged PR 🎉 |
JelleZijlstra
commented
Jan 18, 2022
Member
Congratulations! |
tushar-deepsource pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
finaldetection logic fromsemanal.pytochecker.py. Why? Because we need type checking! For example, methods, properties, and other descriptors are not counted asEnummembres.is_finalanymore. Why? It is too disruptive. Now this is a special-case forEnumonlyCloses#11850