Skip to content

Fix CI by allowing it to fail on 3.11 - #12003

Merged
JukkaL merged 2 commits into
masterfrom
fixes-ci-tox-typed-ast
Jan 18, 2022
Merged

Fix CI by allowing it to fail on 3.11#12003
JukkaL merged 2 commits into
masterfrom
fixes-ci-tox-typed-ast

Conversation

@sobolevn

Copy link
Copy Markdown
Member

Closes#12002
Refs #11984

@sobolevnsobolevn changed the title Update test.ymlFix CI by allowing it to fail on 3.11Jan 17, 2022
@sobolevnsobolevn mentioned this pull request Jan 17, 2022
@sobolevn

Copy link
Copy Markdown
MemberAuthor

It does not fail anymore, but is still broken: https://github.com/python/mypy/runs/4844006633?check_suite_focus=true

@sobolevn

Copy link
Copy Markdown
MemberAuthor

CC other CI committers: @hauntsaninja@97littleleaf11@ethanhs

This problem blocks other PRs to be merged. We have several options:

  1. This
  2. Remove 3.11 (I don't want to do that, because of how radical it is)
  3. Try to fix cpython / typed-ast (might be a long process)

@97littleleaf11

Copy link
Copy Markdown
Collaborator

The first two options are the same - they skip all the tests on Python 3.11. I prefer droping python nightly test for a while and just wait for fix on typed-ast.

@JukkaL

Copy link
Copy Markdown
Collaborator

I agree with @97littleleaf11. I think that it's best to disable Python nightly temporarily while typed-ast is broken.

@sobolevn

Copy link
Copy Markdown
MemberAuthor

Done! Thanks everyone! 👍

@JukkaLJukkaL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JukkaL
JukkaL merged commit 9b31477 into masterJan 18, 2022
@JukkaL
JukkaL deleted the fixes-ci-tox-typed-ast branch January 18, 2022 13:07
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
KotlinIsland referenced this pull request in KotlinIsland/basedmypy Jan 21, 2022
KotlinIsland referenced this pull request in KotlinIsland/basedmypy Jan 22, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@97littleleaf11@JukkaL