Skip to content

Fix issubclass() to narrow down types of type variables - #7930

Merged
ilevkivskyi merged 8 commits into
python:masterfrom
TH3CHARLie:fix-issubclass
Nov 14, 2019
Merged

Fix issubclass() to narrow down types of type variables#7930
ilevkivskyi merged 8 commits into
python:masterfrom
TH3CHARLie:fix-issubclass

Conversation

@TH3CHARLie

@TH3CHARLieTH3CHARLie commented Nov 12, 2019•
edited
Loading

Copy link
Copy Markdown
Collaborator

resolves#7920

Currently, no testcases break so I did not look into meet.py for further investigation

ilevkivskyi
ilevkivskyi reviewed Nov 12, 2019
View reviewed changes

@ilevkivskyiilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! Here I have few comments.

Comment threadmypy/checker.py Outdated
Comment threadtest-data/unit/check-classes.test Outdated
Comment threadtest-data/unit/check-classes.test
@TH3CHARLie

TH3CHARLie commented Nov 13, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Thanks for the detailed review! I patched it up in df62cbc
A short summary of what I did:

  • change the logic of how the code handles TypeVarType
  • refactor the issubclass logic into a helper function
  • modify testcase by using the one from the original issue which uses different base types

ilevkivskyi
ilevkivskyi reviewed Nov 13, 2019
View reviewed changes

@ilevkivskyiilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates! Here are some more comments.

Comment threadmypy/checker.py
if len(node.args) != 2: # the error will be reported elsewhere
return {}, {}
expr = node.args[0]
if literal(expr) == LITERAL_TYPE:

@ilevkivskyiilevkivskyiNov 13, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the above two lines in this function. To make the refactoring more 1-to-1.

Comment threadmypy/checker.py

def infer_issubclass_maps(self, node: CallExpr,
type_map: Dict[Expression, Type]
) -> Tuple[TypeMap, TypeMap]:

@ilevkivskyiilevkivskyiNov 13, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short docstring for the new function.

Comment threadtest-data/unit/check-classes.test
return other.field
return 0

[builtins fixtures/isinstancelist.pyi]

@ilevkivskyiilevkivskyiNov 13, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now the two classes don't look the same, but you didn't do what I asked, I wanted type variables with different upper bounds, like Type[SomeClass], not just type.

ilevkivskyi
ilevkivskyi reviewed Nov 13, 2019
View reviewed changes

@ilevkivskyiilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments here. Also please don't hurry, it is not a competition.

Comment threadmypy/checker.py Outdated
Comment threadmypy/checker.py Outdated
Comment threadtest-data/unit/check-classes.test Outdated
Comment threadtest-data/unit/check-classes.test
Comment threadtest-data/unit/check-classes.test Outdated
@TH3CHARLie

TH3CHARLie commented Nov 13, 2019•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

You are right and I shouldn't be in such a hurry.

I had some misunderstanding about this issue from the very beginning and that mistake continues in my testcase. I apologize for that and am trying my best to fill my knowledge gap on type systems(mainly by reading TAPL)

Now I look it again and realize Foo does not have to be there, so I believe this time the testcase is correct and serves its purpose

ilevkivskyi
ilevkivskyi approved these changes Nov 14, 2019
View reviewed changes

@ilevkivskyiilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@TH3CHARLie

TH3CHARLie commented Nov 14, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Thanks for the guidance! Again, quite an education on both software engineering and type system aspects and that means a lot to me.

@ilevkivskyi
ilevkivskyi merged commit 15280bf into python:masterNov 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyiilevkivskyiilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

issubclass() doesn't narrow down types of type variables

2 participants

@TH3CHARLie@ilevkivskyi