Uh oh!
There was an error while loading. Please reload this page.
Remove python 2 unicode compatible - #667
Open
sks444 wants to merge 2 commits into
Open
Conversation
pradyunsg
commented
Apr 15, 2020
Contributor
Do your thing Travis CI. |
Closed
sks444force-pushed
the
remove-python_2_unicode_compatible
branch
from
May 6, 2020 07:16
2926b01 to
35bb9e9Comparepradyunsg
commented
May 7, 2020
Contributor
Does anyone have concerns with this? |
palnabarun
commented
May 7, 2020
Member
Note: Putting a hold on the merge until the upgrade compatibility is tested |
palnabarun
commented
May 7, 2020
Member
@sks444 This is a good to go change for Python 3. Thank you! 🙂 |
ananyo2012
commented
Jun 7, 2020
Contributor
@sks444 Can you rebase the changes ? |
sks444force-pushed
the
remove-python_2_unicode_compatible
branch
from
June 7, 2020 16:09
6854c9e to
57d50e4Compareananyo2012
approved these changes
Jun 7, 2020
palnabarun
commented
Jun 7, 2020
Member
@sks444 -- can you please rebase the changes against master? |
sks444force-pushed
the
remove-python_2_unicode_compatible
branch
from
June 7, 2020 18:48
57d50e4 to
88ad96eCompare5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#666