Add black configuration

[sayanchowdhury]

No description provided.

[coveralls]

Coverage remained the same at 67.259% when pulling 832e633 on sayanchowdhury:add-poetery-config into 5d88e07 on pythonindia:master.

[palnabarun]

Thank you for cleaning this up!

One question, should we be removing that unicode thing for strings? The software stills run on Python 2 and we wouldn't want to break compatibility at this point of time.

[ananyo2012]

Also is this work overlapping with #667 ?

[sayanchowdhury]

No, this is not overlapping with the #667 work.

[ananyo2012]

@sayanchowdhury Why do we need poetry ?

[sayanchowdhury]

@sayanchowdhury Why do we need poetry ?

pyproject.toml is the new preferred way to package the project and poetry eases the use of it.

[pradyunsg]

It's not a "poetry configuration" file. The pyproject.toml file was standardized in PEP 518. poetry and black, utilize the "space" within that file that they are allowed to use (tool.pypi-name).

https://www.python.org/dev/peps/pep-0518/#tool-table

[sayanchowdhury]

It's not a "poetry configuration" file. The pyproject.toml file was standardized in PEP 518. poetry and black, utilize the "space" within that file that they are allowed to use (tool.pypi-name).

https://www.python.org/dev/peps/pep-0518/#tool-table

Right, that was the mistake on my part. That would not be poetry configuration rather the PEP. And going forward I plan to integrate poetry, and also possibly move everything from setup.cfg to pyproject.toml. I know there is an open ticket in isort to support this, which @pradyunsg created long back.

[ananyo2012]

If we are going for a dependency manager I would rather prefer pipenv.

…

On Thu, May 7, 2020 at 5:55 PM Sayan Chowdhury ***@***.***> wrote: It's not a "poetry configuration" file. The pyproject.toml file was standardized in PEP 518. poetry and black, utilize the "space" within that file that they are allowed to use (tool.pypi-name). https://www.python.org/dev/peps/pep-0518/#tool-table Right, that was the mistake on my part. That would not be poetry configuration rather the PEP. And going forward I plan to integrate poetry, and also possibly move everything from setup.cfg to pyproject.toml. I know there is an open ticket in isort to support this, which @pradyunsg <https://github.com/pradyunsg> created long back. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#670 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACQAER6HTIM4LSNGOIGU56TRQKSDPANCNFSM4MXT5SCA> .

[sayanchowdhury]

As of now this PR is for black configuration. If we have to migrate to another dependency manager we can have a discussion and let work accordingly

[palnabarun]

@sayanchowdhury Please squash the commits/rebase your branch to remove the merge commit.

[palnabarun]

Oops! Closing was a misclick.

[sayanchowdhury]

Closing in favour of #677