Skip to content

[5.1/ N] set_option/get_option API with {backend_name, backend options} only - #11877

Merged
cccclai merged 12 commits into
mainfrom
gh/cccclai/31/orig
Jun 24, 2025
Merged

[5.1/ N] set_option/get_option API with {backend_name, backend options} only#11877
cccclai merged 12 commits into
mainfrom
gh/cccclai/31/orig

Conversation

@pytorchbot

Copy link
Copy Markdown
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11865 by @cccclai
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/31/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/31/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/23/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/31/orig
@diff-train-skip-merge

Pull Request resolved: #11389
Introduce backend option as discussed in #10216
Step 1: Introducd Backend Option class
In later stage, it will be plugged in with the rest of the stack. BackendOptions is pretty much a list of BackendOption, and backend option is a key value pair. The key is a string, and the value can be 3 different types, including bool, string and int.
ghstack-source-id: 292257885
Differential Revision: [D75993712](https://our.internmc.facebook.com/intern/diff/D75993712/)
Pull Request resolved: #11390
For future needs without breacking API BC, in case we need to pass more information to the update API
ghstack-source-id: 292257886
Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/)
Pull Request resolved: #11391
Add update function in backend interface class. The update function will receive the backend options from dispatched by the ET runtime.
ET runtime's logic: loop over each backend and it's corresponding backend options, dispatch the backend options to the corresponding backend
Next step, will add update API in the method and then module
ghstack-source-id: 292257883
@exported-using-ghexport
Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/)
…s} only
Pull Request resolved: #11865
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
ghstack-source-id: 292257887
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
@pytorchbot
pytorchbot requested a review from cccclai as a code ownerJune 24, 2025 08:00
@pytorch-bot

pytorch-botBot commented Jun 24, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11877

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Cancelled Jobs, 1 Pending, 10 Unrelated Failures

As of commit 5d196fc with merge base 91c9ffa (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2025
Base automatically changed from gh/cccclai/23/orig to mainJune 24, 2025 17:22
@cccclaicccclai added the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label Jun 24, 2025
@cccclai
cccclai merged commit fafff0c into mainJun 24, 2025
@cccclai
cccclai deleted the gh/cccclai/31/orig branch June 24, 2025 22:50
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
…s} only (pytorch#11877)
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: pytorch#11865 by
@cccclai
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/cccclai/31/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/cccclai/31/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/cccclai/23/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/cccclai/31/orig
@diff-train-skip-merge
---------
Co-authored-by: Chen Lai <chenlai@fb.com>
Co-authored-by: cccclai <chenlai@meta.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: apiChanges to public facing apis (any interfaces, pybinded runtime methods, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pytorchbot@cccclai@facebook-github-bot