Skip to content

Always run build-presets workflow on PRs/pushes - #13243

Merged
GregoryComer merged 1 commit into
mainfrom
gh/GregoryComer/110/head
Aug 11, 2025
Merged

Always run build-presets workflow on PRs/pushes#13243
GregoryComer merged 1 commit into
mainfrom
gh/GregoryComer/110/head

Conversation

@GregoryComer

@GregoryComerGregoryComer commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

The build-presets workflow currently runs only when the workflow file itself is updated. As we update docs to recommend using presets, we should run this job on all PRs.

Note that the Windows preset is currently reporting success despite failing to actually build. I'm intending to resolve that shortly as a follow-up.

[ghstack-poisoned]
@pytorch-bot

pytorch-botBot commented Aug 8, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13243

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 94c4f20 with merge base 4ce7078 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: ac9fae7
ghstack-comment-id: 3169379934
Pull-Request: #13243
@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
@GregoryComerGregoryComer added the release notes: none Do not include this in the release notes label Aug 8, 2025
@GregoryComerGregoryComer changed the title Always run build-presets workflow on pushAlways run build-presets workflowAug 8, 2025
@GregoryComerGregoryComer changed the title Always run build-presets workflowAlways run build-presets workflow on pull/pushAug 8, 2025
@GregoryComerGregoryComer changed the title Always run build-presets workflow on pull/pushAlways run build-presets workflow on PRs/pushesAug 8, 2025
@GregoryComer

Copy link
Copy Markdown
ContributorAuthor

Tracking issue: #12962.

@GregoryComer
GregoryComer merged commit 9308d2c into mainAug 11, 2025
100 of 104 checks passed
@GregoryComer
GregoryComer deleted the gh/GregoryComer/110/head branch August 11, 2025 20:18
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
The build-presets workflow currently runs only when the workflow file
itself is updated. As we update docs to recommend using presets, we
should run this job on all PRs.
Note that the Windows preset is currently reporting success despite
failing to actually build. I'm intending to resolve that shortly as a
follow-up.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@GregoryComer@jathu