Skip to content

Fix error reporting in Windows preset build job - #13247

Merged
GregoryComer merged 12 commits into
mainfrom
gh/GregoryComer/111/head
Aug 25, 2025
Merged

Fix error reporting in Windows preset build job#13247
GregoryComer merged 12 commits into
mainfrom
gh/GregoryComer/111/head

Conversation

@GregoryComer

@GregoryComerGregoryComer commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Update the Windows preset build job to accurately report failure. Previously, it was silently failing.

I've updated the script to explicitly check the last exit code. I'm not entirely sure why ErrorActionPreference=Stop isn't doing this. I played around with the escaping a bit and also added PSNativeCommandUseErrorActionPreference = True, but haven't gotten it to fail on exit code. It might be possible to make this work, but I'm just adding an explicit check for now.

[ghstack-poisoned]
[ghstack-poisoned]
@pytorch-bot

pytorch-botBot commented Aug 8, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13247

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit e0a7a1d with merge base ffb47e3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: 5ec12b2
ghstack-comment-id: 3169485065
Pull-Request: #13247
@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: 342cdf8
ghstack-comment-id: 3169485065
Pull-Request: #13247
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: c16c822
ghstack-comment-id: 3169485065
Pull-Request: #13247
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: 8e73876
ghstack-comment-id: 3169485065
Pull-Request: #13247
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: 8d72955
ghstack-comment-id: 3169485065
Pull-Request: #13247
@GregoryComer
GregoryComer marked this pull request as ready for review August 9, 2025 00:03
@GregoryComer

Copy link
Copy Markdown
ContributorAuthor

Note that the Windows CI failure is expected, given the current state of the job.

@GregoryComer

Copy link
Copy Markdown
ContributorAuthor

Tracking issue: #12962.

Base automatically changed from gh/GregoryComer/110/head to mainAugust 11, 2025 20:18
[ghstack-poisoned]
@GregoryComerGregoryComer added the release notes: none Do not include this in the release notes label Aug 14, 2025
GregoryComerand others added 3 commits August 14, 2025 11:19
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer
GregoryComer merged commit 3ab2c2f into mainAug 25, 2025
100 of 104 checks passed
@GregoryComer
GregoryComer deleted the gh/GregoryComer/111/head branch August 25, 2025 22:52
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
Update the Windows preset build job to accurately report failure.
Previously, it was silently failing.
I've updated the script to explicitly check the last exit code. I'm not
entirely sure why ErrorActionPreference=Stop isn't doing this. I played
around with the escaping a bit and also added
PSNativeCommandUseErrorActionPreference = True, but haven't gotten it to
fail on exit code. It might be possible to make this work, but I'm just
adding an explicit check for now.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@GregoryComer@mergennachin@jathu