Skip to content

Disable tokenizers on Windows - #13667

Merged
GregoryComer merged 79 commits into
mainfrom
gh/GregoryComer/138/head
Aug 27, 2025
Merged

Disable tokenizers on Windows#13667
GregoryComer merged 79 commits into
mainfrom
gh/GregoryComer/138/head

Conversation

@GregoryComer

@GregoryComerGregoryComer commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Tokenizers currently does not build on Windows. I've filed as meta-pytorch/tokenizers#111 and intend to fix this shortly, but I'm disabling for now to allow us to set up functional Windows CI and prevent regressions as we progressively enable things.

GregoryComerand others added 30 commits August 8, 2025 14:44
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@pytorch-bot

pytorch-botBot commented Aug 25, 2025

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13667

Note: Links to docs will display an error until the docs builds have been completed.

❌ 19 New Failures, 89 Pending

As of commit a042a05 with merge base 96676dd (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/GregoryComer/136/head to gh/GregoryComer/141/headAugust 26, 2025 00:12
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 27, 2025
ghstack-source-id: 6a05df7
ghstack-comment-id: 3222019053
Pull-Request: #13667
@GregoryComer
GregoryComer changed the base branch from gh/GregoryComer/141/head to mainAugust 27, 2025 02:29
@GregoryComer
GregoryComer merged commit 5afe90d into mainAug 27, 2025
228 of 250 checks passed
@GregoryComer
GregoryComer deleted the gh/GregoryComer/138/head branch August 27, 2025 02:53
GregoryComer added a commit to GregoryComer/executorch that referenced this pull request Aug 28, 2025
GregoryComer added a commit that referenced this pull request Aug 28, 2025
This reverts commit 5afe90d.
This is due to an Meta-internal sync issue - it needs to be reverted and
re-merged.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@GregoryComer@JacobSzwejbka@jackzhxng