Skip to content

Fix build on Windows, re-enable Windows build CI job - #13672

Closed
GregoryComer wants to merge 76 commits into
mainfrom
gh/GregoryComer/141/head
Closed

Fix build on Windows, re-enable Windows build CI job#13672
GregoryComer wants to merge 76 commits into
mainfrom
gh/GregoryComer/141/head

Conversation

@GregoryComer

@GregoryComerGregoryComer commented Aug 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

CMake doesn't seem to like empty exclude patterns.

GregoryComerand others added 30 commits August 8, 2025 14:44
@GregoryComer
Update
94c4f20
[ghstack-poisoned]
@GregoryComer
Update
352c059
[ghstack-poisoned]
@GregoryComer
Update
d8f8b12
[ghstack-poisoned]
@GregoryComer
Update
8e8b78c
[ghstack-poisoned]
@GregoryComer
Update
9cfd2b6
[ghstack-poisoned]
@GregoryComer
Update
5b1330b
[ghstack-poisoned]
@GregoryComer
Update
378fcdd
[ghstack-poisoned]
@GregoryComer
Update
db12da0
[ghstack-poisoned]
@GregoryComer
Update
4ee5cd0
[ghstack-poisoned]
@GregoryComer
Update
b79f2e1
[ghstack-poisoned]
@GregoryComer
Update
0abe592
[ghstack-poisoned]
@GregoryComer
Update
34a1470
[ghstack-poisoned]
@GregoryComer
Update
923f43e
[ghstack-poisoned]
@GregoryComer
Update
1c0407a
[ghstack-poisoned]
@GregoryComer
Update
3b79e9d
[ghstack-poisoned]
@GregoryComer
Update
fc34c14
[ghstack-poisoned]
@GregoryComer
Update
fa3793a
[ghstack-poisoned]
@GregoryComer
Update
52b9ff1
[ghstack-poisoned]
@GregoryComer
Update
c045a60
[ghstack-poisoned]
@GregoryComer
Update
6e6ab75
[ghstack-poisoned]
@GregoryComer
Update
783cb51
[ghstack-poisoned]
@GregoryComer
Update
0dc6f36
[ghstack-poisoned]
@GregoryComer
Update
5fa2464
[ghstack-poisoned]
@GregoryComer
Update
597dddd
[ghstack-poisoned]
@GregoryComer
Update
d78731e
[ghstack-poisoned]
@GregoryComer
Update
7b45dac
[ghstack-poisoned]
@GregoryComer
Update
6e80b0c
[ghstack-poisoned]
@GregoryComer
Update
a4f0cd5
[ghstack-poisoned]
@GregoryComer
Update
4540ae8
[ghstack-poisoned]
@GregoryComer
Update
2d2fbc2
[ghstack-poisoned]
@GregoryComer
Update
9656f2d
[ghstack-poisoned]
@pytorch-bot

pytorch-botBot commented Aug 25, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13672

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 3a32779 with merge base 7dab7c1 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2025
This was referenced Aug 25, 2025
Merged
Merged
Merged
Merged
Closed
@GregoryComerGregoryComer added the release notes: none Do not include this in the release notes label Aug 26, 2025
GregoryComer
GregoryComer commented Aug 26, 2025
View reviewed changes
Comment threadCMakeLists.txt Outdated
PATTERN "*.h"
PATTERN ${data_loader_exclude_pattern} EXCLUDE
)
if (DEFINED data_loader_exclude_pattern)

@GregoryComerGregoryComerAug 26, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swolchok It looks like CMake complains when there's an exclude with an empty pattern (see https://github.com/pytorch/executorch/actions/runs/17222786697/job/48861521892, line 818). This is a bit of a pain as there doesn't seem to be an elegant solution to this. Do you have any preferences on this approach?

I suppose we could default the exclude pattern to some string that matches nothing, though that seems a little hacky. It looks like we could also maybe build a list of install args, including the "magic" keywords, though I haven't tried it.

@GregoryComer
Update
a8edd06
[ghstack-poisoned]
@GregoryComer
Update
472df91
[ghstack-poisoned]
@GregoryComer
Update
1326917
[ghstack-poisoned]
@GregoryComer
Update
488289b
[ghstack-poisoned]
@GregoryComer
Update
3a32779
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 26, 2025
@GregoryComer
Fix build on Windows, re-enable Windows build CI job
bddde13
ghstack-source-id: 251096e
ghstack-comment-id: 3222086254
Pull-Request: #13672
@GregoryComerGregoryComer changed the title Fix data loader build on Windows, re-enable Windows build CI jobFix build on Windows, re-enable Windows build CI jobAug 26, 2025
@GregoryComer
GregoryComer marked this pull request as draft August 26, 2025 05:35
@GregoryComerGregoryComer mentioned this pull request Aug 26, 2025
Merged
GregoryComer added a commit that referenced this pull request Aug 26, 2025
@GregoryComer
Re-enable Windows build CI (#13699)
034ff5d
The Windows CI build job was disabled in
#13669 due to a new Windows
build failure in #13485. Since
that diff was reverted in
#13685, we can re-enable the
job.
I started fixing the issue in
#13672, but dropped it due to
the revert. It's a simple change, so it can likely be bundled when the
affected PR is re-landed.
Test Plan:
The Build Preset / Windows job is passing on this PR.
@github-actions

github-actionsBot commented Nov 2, 2025

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actionsgithub-actionsBot added the Stale PRs inactive for over 60 days label Nov 2, 2025
@github-actions

github-actionsBot commented Jan 2, 2026

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

1 similar comment
@github-actions

github-actionsBot commented Mar 3, 2026

Copy link
Copy Markdown

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@swolchokswolchokAwaiting requested review from swolchok
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandales
@digantdesaidigantdesaiAwaiting requested review from digantdesaidigantdesai is a code owner

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notesStalePRs inactive for over 60 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GregoryComer