Skip to content

Re-enable Windows build CI - #13699

Merged
GregoryComer merged 1 commit into
mainfrom
gh/GregoryComer/143/head
Aug 26, 2025
Merged

Re-enable Windows build CI#13699
GregoryComer merged 1 commit into
mainfrom
gh/GregoryComer/143/head

Conversation

@GregoryComer

@GregoryComerGregoryComer commented Aug 26, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

The Windows CI build job was disabled in #13669 due to a new Windows build failure in #13485. Since that diff was reverted in #13685, we can re-enable the job.

I started fixing the issue in #13672, but dropped it due to the revert. It's a simple change, so it can likely be bundled when the affected PR is re-landed.

Test Plan:
The Build Preset / Windows job is passing on this PR.

@GregoryComer
Update
18f4ad6
[ghstack-poisoned]
@GregoryComer

GregoryComer commented Aug 26, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Aug 26, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13699

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 99 Pending

As of commit 18f4ad6 with merge base 130cafc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Aug 26, 2025
@GregoryComer
Re-enable Windows build CI
f9bb0d8
ghstack-source-id: 07b0158
ghstack-comment-id: 3225922167
Pull-Request: #13699
@meta-clameta-claBot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2025
@GregoryComerGregoryComer added the release notes: none Do not include this in the release notes label Aug 26, 2025
@GregoryComer
GregoryComer merged commit 034ff5d into mainAug 26, 2025
112 of 121 checks passed
@GregoryComer
GregoryComer deleted the gh/GregoryComer/143/head branch August 26, 2025 22:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachinmergennachinAwaiting requested review from mergennachin
@JacobSzwejbkaJacobSzwejbkaAwaiting requested review from JacobSzwejbka
1 more reviewer
@jackzhxngjackzhxngjackzhxng approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.release notes: noneDo not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GregoryComer@jackzhxng