Add platform-specific configurations for iOS and macOS ARM64 to prevent AVX code compilation on x64 macOS

[AkiSakurai]

• Updated Utils.cmake to set appropriate target_platforms_arg for iOS and macOS when building on ARM64.
• Added execution platforms ios-arm64 and macos-arm64 in shim/BUCK for specifying CPU and OS configurations.
• fixCannot build Apple frameworks on Intel Mac -- /executorch/extension/llm/custom_ops/spinquant/third-party/FFHT/fht_avx.c:54:25: error: unknown register name '%ymm0' in asm. #6691

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6731

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

• [DomainsOnly] Jobs fail with GLIBC version not found
• Failure to deploy Self-Hosted runners - High Queue Times and canceled jobs

❌ 3 New Failures

As of commit 4c1d38f with merge base 39e5b91 ():

NEW FAILURES - The following jobs have failed:

• pull / android / run-emulator (gh)
  adb: failed to install android-test-debug.apk: Failure [INSTALL_PARSE_FAILED_NOT_APK: Failed to parse /data/app/vmdl717881496.tmp/base.apk: Failed to load asset path /data/app/vmdl717881496.tmp/base.apk]
• pull / test-llama-runner-qnn-linux (fp32, qnn) / linux-job (gh)
  Invalid image name executorch-ubuntu-22.04-qnn-sdk
• pull / test-llava-runner-linux / linux-job (gh)
  test_prefill_logits

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[JacobSzwejbka]

@helunwencser@GregoryComer@larryliu0820 can you take a look

[larryliu0820]

Thanks for fixing the issue! Can you please add a unit test / CI job for this? Or maybe list out the repro commands so someone else can add the test.

[zcbenz]

@AkiSakurai I think I have met the opposite issue with yours in #6839, do you have an idea how to make cross-compilation to x64 from arm64 work? I would be happy to test.

[zcbenz]

Actually I tried apply this patch and #6839 also gets fixed with it:

diff --git a/build/Utils.cmake b/build/Utils.cmake
index bdda2b220..d81a2c8ef 100644
--- a/build/Utils.cmake+++ b/build/Utils.cmake@@ -206,6 +206,8 @@ function(extract_sources sources_file)
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
if(CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64")
set(target_platforms_arg "--target-platforms=shim//:macos-arm64")
+ elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64")+ set(target_platforms_arg "--target-platforms=shim//:macos-x86_64")
endif()
endif()
diff --git a/shim/BUCK b/shim/BUCK
index c4b0c91a0..fa0d8464b 100644
--- a/shim/BUCK+++ b/shim/BUCK@@ -90,3 +90,11 @@ execution_platform(
use_windows_path_separators = False,
visibility = ["PUBLIC"],
)
++execution_platform(+ name = "macos-x86_64",+ cpu_configuration = "prelude//cpu:x86_64",+ os_configuration = "prelude//os:macos",+ use_windows_path_separators = False,+ visibility = ["PUBLIC"],+)

Maybe include it in this PR?

[AkiSakurai]

Thanks for fixing the issue! Can you please add a unit test / CI job for this? Or maybe list out the repro commands so someone else can add the test.

To reproduce, run ./build/build_apple_frameworks.sh --coreml --custom --mps --optimized --portable --quantized --xnnpack on intel mac.

[shoumikhin]

@AkiSakurai do we still need this change? Please make sure the tests pass.

[AkiSakurai]

@AkiSakurai do we still need this change? Please make sure the tests pass.

No, it was fixed in #8346