Uh oh!
There was an error while loading. Please reload this page.
determine fht_avx.c/fht_neon.c based on CMake target processor - #8346
Merged
Conversation
ContributorAuthor
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8346
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 8df2f1d with merge base f3fc096 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 10, 2025
dbort
approved these changes
Feb 11, 2025
This was referenced Feb 12, 2025
swolchokforce-pushed
the
gh/swolchok/242/head
branch
from
February 12, 2025 21:41
773ff37 to
d4aaa36Compareswolchok
requested review from
GregoryComer, iseeyuan, jackzhxng and larryliu0820
as code ownersFebruary 22, 2025 00:26
GregoryComer
approved these changes
Feb 24, 2025
jackzhxng
approved these changes
Feb 24, 2025
| # Second clause is to pick up fht_neon.c/fht_avx.c from FFHT. TODO: | ||
| # remove filters and patch extract_sources.py's Buck query to fetch | ||
| # srcs; presumably filters is here to remove .h files. | ||
| "(.cpp$)|(fht.*\\.c$)", |
Contributor
There was a problem hiding this comment.
My comment is irrelevant since you are removing it, but this second regex seemed wrong?
ContributorAuthor
There was a problem hiding this comment.
Looks right to me. Dot is a regex metacharacter so we need to escape it with a backslash. Backslash is a string metacharacter so we need to escape it with a second backslash. Or is there a different problem I missed entirely?
kedarnath03 pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Might fix #6691. ghstack-source-id: ddd1a40 ghstack-comment-id: 2648965140 Pull Request resolved: pytorch/executorch#8346
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might fix#6691.