Remove ExecuTorch copy of Vectorized - #7042

Merged
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom
gh/swolchok/121/head
Jun 12, 2025
Merged

Remove ExecuTorch copy of Vectorized#7042
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom
gh/swolchok/121/head

Conversation

@swolchok

@swolchokswolchok commented Nov 23, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

All uses are outside ExecuTorch core, so we can just use ATen Vectorized.

Differential Revision: D66396016

@swolchok
Remove ExecuTorch copy of Vectorized
9a552c8
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@pytorch-bot

pytorch-botBot commented Nov 23, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7042

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit b8fffbc with merge base 4a14fdd (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2024
This was referenced Nov 23, 2024
Merged
Merged
@facebook-github-bot

facebook-github-bot commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

swolchok added a commit that referenced this pull request Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
45e70e6
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
ghstack-source-id: 255095942
Pull Request resolved: #7042
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
4af30de
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
6c87ea7
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255100702
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot

facebook-github-bot commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
cd2cc4e
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@swolchokswolchok mentioned this pull request Nov 23, 2024
Closed
@facebook-github-bot

facebook-github-bot commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

swolchok added a commit that referenced this pull request Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
486bffc
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255101543
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6c5f798
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

swolchok added a commit that referenced this pull request Nov 26, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
59a6029
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255547405
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
ff59c8b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
df9d3a2
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256068820
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot

facebook-github-bot commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
33d922b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
0752b3c
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256078544
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot

facebook-github-bot commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

@swolchok
rebase on "Remove ExecuTorch copy of Vectorized"
3610c35
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Dec 8, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
d466e4e
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 257038888
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot

facebook-github-bot commented Dec 8, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
aa58719
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

swolchok added a commit that referenced this pull request Dec 17, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
973d7c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 258553931
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
swolchok added a commit that referenced this pull request Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
17b6adf
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289276453
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot

facebook-github-bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6133476
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
432e251
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289279745
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot

facebook-github-bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

@swolchok
fix numerics for internal test on "Remove ExecuTorch copy of Vectorized"
b612e5b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jun 10, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
a7fed67
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289550079
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot

facebook-github-bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

@swolchok
swolchok marked this pull request as ready for review June 11, 2025 00:17
@swolchok

swolchok commented Jun 11, 2025

Copy link
Copy Markdown
ContributorAuthor

llava-runner-linux result is slightly different but wouldn't call it functionally incorrect. rerunning failed jobs but we may need to discuss whether this is landable. https://github.com/pytorch/executorch/actions/runs/15572676327/job/43851619080?pr=7042

@swolchok

swolchok commented Jun 11, 2025

Copy link
Copy Markdown
ContributorAuthor

yep, need to update test-llava-runner-linux output https://github.com/pytorch/executorch/actions/runs/15572676327/job/43855070881?pr=7042

@swolchok
shorten tested llava prefix due to output change due to slightly chan…
213d8c4
…ged numerics on "Remove ExecuTorch copy of Vectorized"
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jun 11, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
42888c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289754160
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot

facebook-github-bot commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

@swolchok

swolchok commented Jun 12, 2025

Copy link
Copy Markdown
ContributorAuthor

unittest-buck failures are because we can't use PyTorch in OSS buck. short-term we need to take the affected ops out of the set we test; long-term we need to fix being unable to use PyTorch in OSS buck.

@swolchok
band-aid unittest-buck on "Remove ExecuTorch copy of Vectorized"
b8fffbc
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jun 12, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
39091ef
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289984465
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot

facebook-github-bot commented Jun 12, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66396016

@swolchok

swolchok commented Jun 12, 2025

Copy link
Copy Markdown
ContributorAuthor

tests look good. failures on android / run-emulator, test-llama-runner-qnn-linux, and unittest-nxp-neutron appear to be unrelated.

@facebook-github-bot
facebook-github-bot merged commit 63aab8d into gh/swolchok/121/baseJun 12, 2025
@facebook-github-bot
facebook-github-bot deleted the gh/swolchok/121/head branch June 12, 2025 20:03
@pytorchbotpytorchbot mentioned this pull request Jun 12, 2025
Merged
swolchok added a commit that referenced this pull request Jun 12, 2025
@pytorchbot@swolchok
Remove ExecuTorch copy of Vectorized (#11613)
8895573
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #7042 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/orig
@diff-train-skip-merge
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jathujathuAwaiting requested review from jathujathu is a code owner
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandalesmanuelcandales is a code owner
@jackzhxngjackzhxngAwaiting requested review from jackzhxng
@iseeyuaniseeyuanAwaiting requested review from iseeyuaniseeyuan is a code owner
2 more reviewers
@dbortdbortdbort left review comments
@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@facebook-github-bot@dbort@kimishpatel
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Remove ExecuTorch copy of Vectorized - #7042
Merged
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Jun 12, 2025
Merged
Remove ExecuTorch copy of Vectorized#7042
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: D66396016
@swolchok
Remove ExecuTorch copy of Vectorized
9a552c8
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7042
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures
As of commit b8fffbc with merge base 4a14fdd (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024

This was referenced Nov 23, 2024
 Merged

 Merged

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
45e70e6
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
ghstack-source-id: 255095942
Pull Request resolved: #7042
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
4af30de
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
6c87ea7
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255100702
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
cd2cc4e
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
486bffc
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255101543
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6c5f798
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 26, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
59a6029
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255547405
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
ff59c8b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
df9d3a2
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256068820
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
33d922b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
0752b3c
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256078544
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
rebase on "Remove ExecuTorch copy of Vectorized"
3610c35
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 8, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
d466e4e
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 257038888
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
aa58719
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Dec 17, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
973d7c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 258553931
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
17b6adf
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289276453
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6133476
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
432e251
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289279745
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
fix numerics for internal test on "Remove ExecuTorch copy of Vectorized"
b612e5b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 10, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
a7fed67
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289550079
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 10, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
marked this pull request as ready for review
June 11, 2025 00:17
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
llava-runner-linux result is slightly different but wouldn't call it functionally incorrect. rerunning failed jobs but we may need to discuss whether this is landable. https://github.com/pytorch/executorch/actions/runs/15572676327/job/43851619080?pr=7042
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
yep, need to update test-llava-runner-linux output https://github.com/pytorch/executorch/actions/runs/15572676327/job/43855070881?pr=7042
@swolchok
shorten tested llava prefix due to output change due to slightly chan…
213d8c4
…ged numerics on "Remove ExecuTorch copy of Vectorized"
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 11, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
42888c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289754160
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 11, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
unittest-buck failures are because we can't use PyTorch in OSS buck. short-term we need to take the affected ops out of the set we test; long-term we need to fix being unable to use PyTorch in OSS buck.
@swolchok
band-aid unittest-buck on "Remove ExecuTorch copy of Vectorized"
b8fffbc
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
39091ef
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289984465
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
tests look good. failures on android / run-emulator, test-llama-runner-qnn-linux, and unittest-nxp-neutron appear to be unrelated.
@facebook-github-bot
facebook-github-bot
merged commit 63aab8d
into
gh/swolchok/121/baseJun 12, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/121/head

branch
June 12, 2025 20:03
@pytorchbotpytorchbot
mentioned this pull request
Jun 12, 2025
 Merged

swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@pytorchbot@swolchok
Remove ExecuTorch copy of Vectorized (#11613)
8895573
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #7042 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/orig
@diff-train-skip-merge
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jathujathuAwaiting requested review from jathujathu is a code owner
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandalesmanuelcandales is a code owner
@jackzhxngjackzhxngAwaiting requested review from jackzhxng
@iseeyuaniseeyuanAwaiting requested review from iseeyuaniseeyuan is a code owner

2 more reviewers

@dbortdbortdbort left review comments
@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@facebook-github-bot@dbort@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove ExecuTorch copy of Vectorized - #7042
Merged
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Jun 12, 2025
Merged
Remove ExecuTorch copy of Vectorized#7042
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: D66396016
@swolchok
Remove ExecuTorch copy of Vectorized
9a552c8
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7042
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures
As of commit b8fffbc with merge base 4a14fdd (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024

This was referenced Nov 23, 2024
 Merged

 Merged

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
45e70e6
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
ghstack-source-id: 255095942
Pull Request resolved: #7042
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
4af30de
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
6c87ea7
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255100702
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
cd2cc4e
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
486bffc
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255101543
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6c5f798
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 26, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
59a6029
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255547405
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
ff59c8b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
df9d3a2
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256068820
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
33d922b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
0752b3c
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256078544
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
rebase on "Remove ExecuTorch copy of Vectorized"
3610c35
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 8, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
d466e4e
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 257038888
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
aa58719
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Dec 17, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
973d7c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 258553931
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
17b6adf
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289276453
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6133476
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
432e251
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289279745
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
fix numerics for internal test on "Remove ExecuTorch copy of Vectorized"
b612e5b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 10, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
a7fed67
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289550079
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 10, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
marked this pull request as ready for review
June 11, 2025 00:17
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
llava-runner-linux result is slightly different but wouldn't call it functionally incorrect. rerunning failed jobs but we may need to discuss whether this is landable. https://github.com/pytorch/executorch/actions/runs/15572676327/job/43851619080?pr=7042
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
yep, need to update test-llava-runner-linux output https://github.com/pytorch/executorch/actions/runs/15572676327/job/43855070881?pr=7042
@swolchok
shorten tested llava prefix due to output change due to slightly chan…
213d8c4
…ged numerics on "Remove ExecuTorch copy of Vectorized"
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 11, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
42888c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289754160
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 11, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
unittest-buck failures are because we can't use PyTorch in OSS buck. short-term we need to take the affected ops out of the set we test; long-term we need to fix being unable to use PyTorch in OSS buck.
@swolchok
band-aid unittest-buck on "Remove ExecuTorch copy of Vectorized"
b8fffbc
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
39091ef
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289984465
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
tests look good. failures on android / run-emulator, test-llama-runner-qnn-linux, and unittest-nxp-neutron appear to be unrelated.
@facebook-github-bot
facebook-github-bot
merged commit 63aab8d
into
gh/swolchok/121/baseJun 12, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/121/head

branch
June 12, 2025 20:03
@pytorchbotpytorchbot
mentioned this pull request
Jun 12, 2025
 Merged

swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@pytorchbot@swolchok
Remove ExecuTorch copy of Vectorized (#11613)
8895573
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #7042 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/orig
@diff-train-skip-merge
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jathujathuAwaiting requested review from jathujathu is a code owner
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandalesmanuelcandales is a code owner
@jackzhxngjackzhxngAwaiting requested review from jackzhxng
@iseeyuaniseeyuanAwaiting requested review from iseeyuaniseeyuan is a code owner

2 more reviewers

@dbortdbortdbort left review comments
@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@facebook-github-bot@dbort@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove ExecuTorch copy of Vectorized - #7042
Merged
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Jun 12, 2025
Merged
Remove ExecuTorch copy of Vectorized#7042
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: D66396016
@swolchok
Remove ExecuTorch copy of Vectorized
9a552c8
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7042
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures
As of commit b8fffbc with merge base 4a14fdd (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024

This was referenced Nov 23, 2024
 Merged

 Merged

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
45e70e6
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
ghstack-source-id: 255095942
Pull Request resolved: #7042
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
4af30de
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
6c87ea7
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255100702
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
cd2cc4e
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
486bffc
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255101543
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6c5f798
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 26, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
59a6029
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255547405
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
ff59c8b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
df9d3a2
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256068820
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
33d922b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
0752b3c
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256078544
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
rebase on "Remove ExecuTorch copy of Vectorized"
3610c35
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 8, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
d466e4e
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 257038888
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
aa58719
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Dec 17, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
973d7c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 258553931
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
17b6adf
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289276453
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6133476
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
432e251
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289279745
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
fix numerics for internal test on "Remove ExecuTorch copy of Vectorized"
b612e5b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 10, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
a7fed67
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289550079
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 10, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
marked this pull request as ready for review
June 11, 2025 00:17
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
llava-runner-linux result is slightly different but wouldn't call it functionally incorrect. rerunning failed jobs but we may need to discuss whether this is landable. https://github.com/pytorch/executorch/actions/runs/15572676327/job/43851619080?pr=7042
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
yep, need to update test-llava-runner-linux output https://github.com/pytorch/executorch/actions/runs/15572676327/job/43855070881?pr=7042
@swolchok
shorten tested llava prefix due to output change due to slightly chan…
213d8c4
…ged numerics on "Remove ExecuTorch copy of Vectorized"
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 11, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
42888c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289754160
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 11, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
unittest-buck failures are because we can't use PyTorch in OSS buck. short-term we need to take the affected ops out of the set we test; long-term we need to fix being unable to use PyTorch in OSS buck.
@swolchok
band-aid unittest-buck on "Remove ExecuTorch copy of Vectorized"
b8fffbc
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
39091ef
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289984465
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
tests look good. failures on android / run-emulator, test-llama-runner-qnn-linux, and unittest-nxp-neutron appear to be unrelated.
@facebook-github-bot
facebook-github-bot
merged commit 63aab8d
into
gh/swolchok/121/baseJun 12, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/121/head

branch
June 12, 2025 20:03
@pytorchbotpytorchbot
mentioned this pull request
Jun 12, 2025
 Merged

swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@pytorchbot@swolchok
Remove ExecuTorch copy of Vectorized (#11613)
8895573
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #7042 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/orig
@diff-train-skip-merge
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jathujathuAwaiting requested review from jathujathu is a code owner
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandalesmanuelcandales is a code owner
@jackzhxngjackzhxngAwaiting requested review from jackzhxng
@iseeyuaniseeyuanAwaiting requested review from iseeyuaniseeyuan is a code owner

2 more reviewers

@dbortdbortdbort left review comments
@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@facebook-github-bot@dbort@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Remove ExecuTorch copy of Vectorized - #7042
Merged
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Jun 12, 2025
Merged
Remove ExecuTorch copy of Vectorized#7042
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: D66396016
@swolchok
Remove ExecuTorch copy of Vectorized
9a552c8
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7042
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures
As of commit b8fffbc with merge base 4a14fdd (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024

This was referenced Nov 23, 2024
 Merged

 Merged

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
45e70e6
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
ghstack-source-id: 255095942
Pull Request resolved: #7042
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
4af30de
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
6c87ea7
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255100702
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
cd2cc4e
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
486bffc
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255101543
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6c5f798
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 26, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
59a6029
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255547405
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
ff59c8b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
df9d3a2
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256068820
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
33d922b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
0752b3c
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256078544
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
rebase on "Remove ExecuTorch copy of Vectorized"
3610c35
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 8, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
d466e4e
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 257038888
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
aa58719
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Dec 17, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
973d7c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 258553931
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
17b6adf
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289276453
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6133476
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
432e251
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289279745
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
fix numerics for internal test on "Remove ExecuTorch copy of Vectorized"
b612e5b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 10, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
a7fed67
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289550079
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 10, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
marked this pull request as ready for review
June 11, 2025 00:17
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
llava-runner-linux result is slightly different but wouldn't call it functionally incorrect. rerunning failed jobs but we may need to discuss whether this is landable. https://github.com/pytorch/executorch/actions/runs/15572676327/job/43851619080?pr=7042
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
yep, need to update test-llava-runner-linux output https://github.com/pytorch/executorch/actions/runs/15572676327/job/43855070881?pr=7042
@swolchok
shorten tested llava prefix due to output change due to slightly chan…
213d8c4
…ged numerics on "Remove ExecuTorch copy of Vectorized"
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 11, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
42888c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289754160
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 11, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
unittest-buck failures are because we can't use PyTorch in OSS buck. short-term we need to take the affected ops out of the set we test; long-term we need to fix being unable to use PyTorch in OSS buck.
@swolchok
band-aid unittest-buck on "Remove ExecuTorch copy of Vectorized"
b8fffbc
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
39091ef
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289984465
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
tests look good. failures on android / run-emulator, test-llama-runner-qnn-linux, and unittest-nxp-neutron appear to be unrelated.
@facebook-github-bot
facebook-github-bot
merged commit 63aab8d
into
gh/swolchok/121/baseJun 12, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/121/head

branch
June 12, 2025 20:03
@pytorchbotpytorchbot
mentioned this pull request
Jun 12, 2025
 Merged

swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@pytorchbot@swolchok
Remove ExecuTorch copy of Vectorized (#11613)
8895573
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #7042 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/orig
@diff-train-skip-merge
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jathujathuAwaiting requested review from jathujathu is a code owner
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandalesmanuelcandales is a code owner
@jackzhxngjackzhxngAwaiting requested review from jackzhxng
@iseeyuaniseeyuanAwaiting requested review from iseeyuaniseeyuan is a code owner

2 more reviewers

@dbortdbortdbort left review comments
@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@facebook-github-bot@dbort@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove ExecuTorch copy of Vectorized - #7042
Merged
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Jun 12, 2025
Merged
Remove ExecuTorch copy of Vectorized#7042
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: D66396016
@swolchok
Remove ExecuTorch copy of Vectorized
9a552c8
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7042
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures
As of commit b8fffbc with merge base 4a14fdd (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024

This was referenced Nov 23, 2024
 Merged

 Merged

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
45e70e6
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
ghstack-source-id: 255095942
Pull Request resolved: #7042
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
4af30de
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
6c87ea7
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255100702
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
cd2cc4e
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
486bffc
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255101543
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6c5f798
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 26, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
59a6029
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255547405
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
ff59c8b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
df9d3a2
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256068820
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
33d922b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
0752b3c
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256078544
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
rebase on "Remove ExecuTorch copy of Vectorized"
3610c35
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 8, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
d466e4e
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 257038888
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
aa58719
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Dec 17, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
973d7c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 258553931
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
17b6adf
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289276453
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6133476
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
432e251
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289279745
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
fix numerics for internal test on "Remove ExecuTorch copy of Vectorized"
b612e5b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 10, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
a7fed67
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289550079
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 10, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
marked this pull request as ready for review
June 11, 2025 00:17
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
llava-runner-linux result is slightly different but wouldn't call it functionally incorrect. rerunning failed jobs but we may need to discuss whether this is landable. https://github.com/pytorch/executorch/actions/runs/15572676327/job/43851619080?pr=7042
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
yep, need to update test-llava-runner-linux output https://github.com/pytorch/executorch/actions/runs/15572676327/job/43855070881?pr=7042
@swolchok
shorten tested llava prefix due to output change due to slightly chan…
213d8c4
…ged numerics on "Remove ExecuTorch copy of Vectorized"
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 11, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
42888c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289754160
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 11, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
unittest-buck failures are because we can't use PyTorch in OSS buck. short-term we need to take the affected ops out of the set we test; long-term we need to fix being unable to use PyTorch in OSS buck.
@swolchok
band-aid unittest-buck on "Remove ExecuTorch copy of Vectorized"
b8fffbc
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
39091ef
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289984465
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
tests look good. failures on android / run-emulator, test-llama-runner-qnn-linux, and unittest-nxp-neutron appear to be unrelated.
@facebook-github-bot
facebook-github-bot
merged commit 63aab8d
into
gh/swolchok/121/baseJun 12, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/121/head

branch
June 12, 2025 20:03
@pytorchbotpytorchbot
mentioned this pull request
Jun 12, 2025
 Merged

swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@pytorchbot@swolchok
Remove ExecuTorch copy of Vectorized (#11613)
8895573
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #7042 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/orig
@diff-train-skip-merge
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jathujathuAwaiting requested review from jathujathu is a code owner
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandalesmanuelcandales is a code owner
@jackzhxngjackzhxngAwaiting requested review from jackzhxng
@iseeyuaniseeyuanAwaiting requested review from iseeyuaniseeyuan is a code owner

2 more reviewers

@dbortdbortdbort left review comments
@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@facebook-github-bot@dbort@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove ExecuTorch copy of Vectorized - #7042
Merged
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Jun 12, 2025
Merged
Remove ExecuTorch copy of Vectorized#7042
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: D66396016
@swolchok
Remove ExecuTorch copy of Vectorized
9a552c8
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7042
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures
As of commit b8fffbc with merge base 4a14fdd (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024

This was referenced Nov 23, 2024
 Merged

 Merged

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
45e70e6
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
ghstack-source-id: 255095942
Pull Request resolved: #7042
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
4af30de
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
6c87ea7
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255100702
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
cd2cc4e
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
486bffc
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255101543
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6c5f798
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 26, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
59a6029
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255547405
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
ff59c8b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
df9d3a2
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256068820
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
33d922b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
0752b3c
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256078544
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
rebase on "Remove ExecuTorch copy of Vectorized"
3610c35
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 8, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
d466e4e
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 257038888
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
aa58719
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Dec 17, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
973d7c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 258553931
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
17b6adf
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289276453
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6133476
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
432e251
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289279745
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
fix numerics for internal test on "Remove ExecuTorch copy of Vectorized"
b612e5b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 10, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
a7fed67
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289550079
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 10, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
marked this pull request as ready for review
June 11, 2025 00:17
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
llava-runner-linux result is slightly different but wouldn't call it functionally incorrect. rerunning failed jobs but we may need to discuss whether this is landable. https://github.com/pytorch/executorch/actions/runs/15572676327/job/43851619080?pr=7042
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
yep, need to update test-llava-runner-linux output https://github.com/pytorch/executorch/actions/runs/15572676327/job/43855070881?pr=7042
@swolchok
shorten tested llava prefix due to output change due to slightly chan…
213d8c4
…ged numerics on "Remove ExecuTorch copy of Vectorized"
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 11, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
42888c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289754160
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 11, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
unittest-buck failures are because we can't use PyTorch in OSS buck. short-term we need to take the affected ops out of the set we test; long-term we need to fix being unable to use PyTorch in OSS buck.
@swolchok
band-aid unittest-buck on "Remove ExecuTorch copy of Vectorized"
b8fffbc
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
39091ef
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289984465
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
tests look good. failures on android / run-emulator, test-llama-runner-qnn-linux, and unittest-nxp-neutron appear to be unrelated.
@facebook-github-bot
facebook-github-bot
merged commit 63aab8d
into
gh/swolchok/121/baseJun 12, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/121/head

branch
June 12, 2025 20:03
@pytorchbotpytorchbot
mentioned this pull request
Jun 12, 2025
 Merged

swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@pytorchbot@swolchok
Remove ExecuTorch copy of Vectorized (#11613)
8895573
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #7042 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/orig
@diff-train-skip-merge
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jathujathuAwaiting requested review from jathujathu is a code owner
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandalesmanuelcandales is a code owner
@jackzhxngjackzhxngAwaiting requested review from jackzhxng
@iseeyuaniseeyuanAwaiting requested review from iseeyuaniseeyuan is a code owner

2 more reviewers

@dbortdbortdbort left review comments
@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@facebook-github-bot@dbort@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Remove ExecuTorch copy of Vectorized - #7042
Merged
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Jun 12, 2025
Merged
Remove ExecuTorch copy of Vectorized#7042
facebook-github-bot merged 39 commits into
gh/swolchok/121/basefrom 
gh/swolchok/121/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: D66396016
@swolchok
Remove ExecuTorch copy of Vectorized
9a552c8
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7042
Note: Links to docs will display an error until the docs builds have been completed.
❌ 3 New Failures
As of commit b8fffbc with merge base 4a14fdd (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024

This was referenced Nov 23, 2024
 Merged

 Merged

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
45e70e6
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
ghstack-source-id: 255095942
Pull Request resolved: #7042
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
4af30de
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
6c87ea7
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255100702
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
cd2cc4e
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 23, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
486bffc
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255101543
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6c5f798
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Nov 26, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
59a6029
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 255547405
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
ff59c8b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
df9d3a2
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256068820
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
33d922b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 2, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
0752b3c
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 256078544
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
rebase on "Remove ExecuTorch copy of Vectorized"
3610c35
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Dec 8, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
d466e4e
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 257038888
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
aa58719
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
swolchok added a commit
that referenced
this pull request
Dec 17, 2024
@swolchok
Remove ExecuTorch copy of Vectorized
973d7c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 258553931
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
17b6adf
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289276453
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
Update on "Remove ExecuTorch copy of Vectorized"
6133476
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 9, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
432e251
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289279745
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 9, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
fix numerics for internal test on "Remove ExecuTorch copy of Vectorized"
b612e5b
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 10, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
a7fed67
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289550079
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 10, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
marked this pull request as ready for review
June 11, 2025 00:17
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
llava-runner-linux result is slightly different but wouldn't call it functionally incorrect. rerunning failed jobs but we may need to discuss whether this is landable. https://github.com/pytorch/executorch/actions/runs/15572676327/job/43851619080?pr=7042
@swolchok
swolchok
commented
Jun 11, 2025

Copy link


Copy Markdown

ContributorAuthor
yep, need to update test-llava-runner-linux output https://github.com/pytorch/executorch/actions/runs/15572676327/job/43855070881?pr=7042
@swolchok
shorten tested llava prefix due to output change due to slightly chan…
213d8c4
…ged numerics on "Remove ExecuTorch copy of Vectorized"
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 11, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
42888c3
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289754160
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 11, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
unittest-buck failures are because we can't use PyTorch in OSS buck. short-term we need to take the affected ops out of the set we test; long-term we need to fix being unable to use PyTorch in OSS buck.
@swolchok
band-aid unittest-buck on "Remove ExecuTorch copy of Vectorized"
b8fffbc
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
[ghstack-poisoned]
swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@swolchok
Remove ExecuTorch copy of Vectorized
39091ef
Pull Request resolved: #7042
All uses are outside ExecuTorch core, so we can just use ATen Vectorized.
ghstack-source-id: 289984465
@exported-using-ghexport
Differential Revision: [D66396016](https://our.internmc.facebook.com/intern/diff/D66396016/)
@facebook-github-bot
facebook-github-bot
commented
Jun 12, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66396016
@swolchok
swolchok
commented
Jun 12, 2025

Copy link


Copy Markdown

ContributorAuthor
tests look good. failures on android / run-emulator, test-llama-runner-qnn-linux, and unittest-nxp-neutron appear to be unrelated.
@facebook-github-bot
facebook-github-bot
merged commit 63aab8d
into
gh/swolchok/121/baseJun 12, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/121/head

branch
June 12, 2025 20:03
@pytorchbotpytorchbot
mentioned this pull request
Jun 12, 2025
 Merged

swolchok added a commit
that referenced
this pull request
Jun 12, 2025
@pytorchbot@swolchok
Remove ExecuTorch copy of Vectorized (#11613)
8895573
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #7042 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/121/orig
@diff-train-skip-merge
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jathujathuAwaiting requested review from jathujathu is a code owner
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@manuelcandalesmanuelcandalesAwaiting requested review from manuelcandalesmanuelcandales is a code owner
@jackzhxngjackzhxngAwaiting requested review from jackzhxng
@iseeyuaniseeyuanAwaiting requested review from iseeyuaniseeyuan is a code owner

2 more reviewers

@dbortdbortdbort left review comments
@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: buildChanges related to build, including dependency upgrades, build flags, optimizations, etc.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok@facebook-github-bot@dbort@kimishpatel