Reuse GELU implementation from PyTorch core - #7041

Merged
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom
gh/swolchok/120/head
Feb 7, 2025
Merged

Reuse GELU implementation from PyTorch core#7041
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom
gh/swolchok/120/head

Conversation

@swolchok

@swolchokswolchok commented Nov 23, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Stack from ghstack (oldest at bottom):

kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.

Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.

Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.

Differential Revision: D66335522

@swolchok
Reuse GELU implementation from PyTorch core
ef0a735
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@pytorch-bot

pytorch-botBot commented Nov 23, 2024•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7041

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 5dac4a5 with merge base 832f855 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2024
@facebook-github-bot

facebook-github-bot commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

This was referenced Nov 23, 2024
Merged
Merged
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
b3a0601
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1a59230
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@swolchokswolchok mentioned this pull request Nov 23, 2024
Closed
@facebook-github-bot

facebook-github-bot commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
9ce0708
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
ca0fa70
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
f5a9843
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
rebase on "Reuse GELU implementation from PyTorch core"
0b5f154
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Dec 8, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
abc7e4e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
8bb3c18
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c3002c6
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1576719
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c5acbdb
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@facebook-github-bot

facebook-github-bot commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
3590ed4
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
830e364
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
7d837ab
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
157df30
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Feb 4, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@swolchok

swolchok commented Feb 5, 2025

Copy link
Copy Markdown
ContributorAuthor

test-arm-reference-delegation failure is a known flake
test-llava-runner-linux failure might be real? CMake is failing to find Torch

Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
79defe2
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

swolchok pushed a commit that referenced this pull request Feb 5, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
e87700d
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 264847499
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e02f65e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

swolchok pushed a commit that referenced this pull request Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
3f314ef
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265115520
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e44c69c
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
swolchok pushed a commit that referenced this pull request Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
23ef028
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265149952
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
@facebook-github-bot

facebook-github-bot commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
5dac4a5
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot

facebook-github-bot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D66335522

@facebook-github-bot
facebook-github-bot merged commit 7c632b4 into gh/swolchok/120/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot deleted the gh/swolchok/120/head branch February 7, 2025 23:03
@pytorchbotpytorchbot mentioned this pull request Feb 7, 2025
Merged
swolchok pushed a commit that referenced this pull request Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
0d95292
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok pushed a commit that referenced this pull request Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
a33092f
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok added a commit that referenced this pull request Feb 12, 2025
@pytorchbotGithub Executorch@swolchok
Reuse GELU implementation from PyTorch core (#8322)
6727fea
* Reuse GELU implementation from PyTorch core
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
* apply @huydhn's fix to new code
* extra tweak from @huydhn
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: ops & kernelsChanges to the opset and any new / changed kernel implementations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@facebook-github-bot@kimishpatel
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Reuse GELU implementation from PyTorch core - #7041
Merged
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Feb 7, 2025
Merged
Reuse GELU implementation from PyTorch core#7041
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it

externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: D66335522
@swolchok
Reuse GELU implementation from PyTorch core
ef0a735
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7041
Note: Links to docs will display an error until the docs builds have been completed.
❌ 2 New Failures
As of commit 5dac4a5 with merge base 832f855 (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522

This was referenced Nov 23, 2024
 Merged

 Merged

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
b3a0601
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1a59230
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
9ce0708
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
ca0fa70
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
f5a9843
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
rebase on "Reuse GELU implementation from PyTorch core"
0b5f154
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
abc7e4e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
8bb3c18
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c3002c6
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1576719
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c5acbdb
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 20, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
3590ed4
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
830e364
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
7d837ab
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
157df30
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
swolchok
commented
Feb 5, 2025

Copy link


Copy Markdown

ContributorAuthor
test-arm-reference-delegation failure is a known flake

test-llava-runner-linux failure might be real? CMake is failing to find Torch
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
79defe2
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 5, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
e87700d
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 264847499
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e02f65e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
3f314ef
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265115520
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e44c69c
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
23ef028
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265149952
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
5dac4a5
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
merged commit 7c632b4
into
gh/swolchok/120/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/120/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
0d95292
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
a33092f
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok added a commit
that referenced
this pull request
Feb 12, 2025
@pytorchbotGithub Executorch@swolchok
Reuse GELU implementation from PyTorch core (#8322)
6727fea
* Reuse GELU implementation from PyTorch core
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
* apply @huydhn's fix to new code
* extra tweak from @huydhn
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: ops & kernelsChanges to the opset and any new / changed kernel implementations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@facebook-github-bot@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Reuse GELU implementation from PyTorch core - #7041
Merged
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Feb 7, 2025
Merged
Reuse GELU implementation from PyTorch core#7041
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it

externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: D66335522
@swolchok
Reuse GELU implementation from PyTorch core
ef0a735
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7041
Note: Links to docs will display an error until the docs builds have been completed.
❌ 2 New Failures
As of commit 5dac4a5 with merge base 832f855 (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522

This was referenced Nov 23, 2024
 Merged

 Merged

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
b3a0601
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1a59230
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
9ce0708
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
ca0fa70
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
f5a9843
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
rebase on "Reuse GELU implementation from PyTorch core"
0b5f154
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
abc7e4e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
8bb3c18
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c3002c6
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1576719
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c5acbdb
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 20, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
3590ed4
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
830e364
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
7d837ab
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
157df30
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
swolchok
commented
Feb 5, 2025

Copy link


Copy Markdown

ContributorAuthor
test-arm-reference-delegation failure is a known flake

test-llava-runner-linux failure might be real? CMake is failing to find Torch
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
79defe2
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 5, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
e87700d
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 264847499
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e02f65e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
3f314ef
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265115520
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e44c69c
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
23ef028
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265149952
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
5dac4a5
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
merged commit 7c632b4
into
gh/swolchok/120/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/120/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
0d95292
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
a33092f
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok added a commit
that referenced
this pull request
Feb 12, 2025
@pytorchbotGithub Executorch@swolchok
Reuse GELU implementation from PyTorch core (#8322)
6727fea
* Reuse GELU implementation from PyTorch core
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
* apply @huydhn's fix to new code
* extra tweak from @huydhn
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: ops & kernelsChanges to the opset and any new / changed kernel implementations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@facebook-github-bot@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Reuse GELU implementation from PyTorch core - #7041
Merged
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Feb 7, 2025
Merged
Reuse GELU implementation from PyTorch core#7041
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it

externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: D66335522
@swolchok
Reuse GELU implementation from PyTorch core
ef0a735
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7041
Note: Links to docs will display an error until the docs builds have been completed.
❌ 2 New Failures
As of commit 5dac4a5 with merge base 832f855 (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522

This was referenced Nov 23, 2024
 Merged

 Merged

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
b3a0601
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1a59230
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
9ce0708
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
ca0fa70
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
f5a9843
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
rebase on "Reuse GELU implementation from PyTorch core"
0b5f154
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
abc7e4e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
8bb3c18
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c3002c6
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1576719
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c5acbdb
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 20, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
3590ed4
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
830e364
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
7d837ab
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
157df30
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
swolchok
commented
Feb 5, 2025

Copy link


Copy Markdown

ContributorAuthor
test-arm-reference-delegation failure is a known flake

test-llava-runner-linux failure might be real? CMake is failing to find Torch
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
79defe2
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 5, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
e87700d
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 264847499
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e02f65e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
3f314ef
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265115520
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e44c69c
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
23ef028
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265149952
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
5dac4a5
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
merged commit 7c632b4
into
gh/swolchok/120/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/120/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
0d95292
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
a33092f
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok added a commit
that referenced
this pull request
Feb 12, 2025
@pytorchbotGithub Executorch@swolchok
Reuse GELU implementation from PyTorch core (#8322)
6727fea
* Reuse GELU implementation from PyTorch core
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
* apply @huydhn's fix to new code
* extra tweak from @huydhn
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: ops & kernelsChanges to the opset and any new / changed kernel implementations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@facebook-github-bot@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Reuse GELU implementation from PyTorch core - #7041
Merged
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Feb 7, 2025
Merged
Reuse GELU implementation from PyTorch core#7041
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it

externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: D66335522
@swolchok
Reuse GELU implementation from PyTorch core
ef0a735
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7041
Note: Links to docs will display an error until the docs builds have been completed.
❌ 2 New Failures
As of commit 5dac4a5 with merge base 832f855 (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522

This was referenced Nov 23, 2024
 Merged

 Merged

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
b3a0601
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1a59230
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
9ce0708
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
ca0fa70
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
f5a9843
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
rebase on "Reuse GELU implementation from PyTorch core"
0b5f154
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
abc7e4e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
8bb3c18
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c3002c6
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1576719
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c5acbdb
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 20, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
3590ed4
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
830e364
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
7d837ab
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
157df30
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
swolchok
commented
Feb 5, 2025

Copy link


Copy Markdown

ContributorAuthor
test-arm-reference-delegation failure is a known flake

test-llava-runner-linux failure might be real? CMake is failing to find Torch
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
79defe2
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 5, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
e87700d
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 264847499
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e02f65e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
3f314ef
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265115520
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e44c69c
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
23ef028
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265149952
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
5dac4a5
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
merged commit 7c632b4
into
gh/swolchok/120/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/120/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
0d95292
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
a33092f
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok added a commit
that referenced
this pull request
Feb 12, 2025
@pytorchbotGithub Executorch@swolchok
Reuse GELU implementation from PyTorch core (#8322)
6727fea
* Reuse GELU implementation from PyTorch core
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
* apply @huydhn's fix to new code
* extra tweak from @huydhn
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: ops & kernelsChanges to the opset and any new / changed kernel implementations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@facebook-github-bot@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Reuse GELU implementation from PyTorch core - #7041
Merged
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Feb 7, 2025
Merged
Reuse GELU implementation from PyTorch core#7041
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it

externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: D66335522
@swolchok
Reuse GELU implementation from PyTorch core
ef0a735
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7041
Note: Links to docs will display an error until the docs builds have been completed.
❌ 2 New Failures
As of commit 5dac4a5 with merge base 832f855 (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522

This was referenced Nov 23, 2024
 Merged

 Merged

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
b3a0601
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1a59230
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
9ce0708
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
ca0fa70
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
f5a9843
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
rebase on "Reuse GELU implementation from PyTorch core"
0b5f154
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
abc7e4e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
8bb3c18
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c3002c6
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1576719
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c5acbdb
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 20, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
3590ed4
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
830e364
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
7d837ab
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
157df30
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
swolchok
commented
Feb 5, 2025

Copy link


Copy Markdown

ContributorAuthor
test-arm-reference-delegation failure is a known flake

test-llava-runner-linux failure might be real? CMake is failing to find Torch
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
79defe2
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 5, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
e87700d
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 264847499
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e02f65e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
3f314ef
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265115520
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e44c69c
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
23ef028
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265149952
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
5dac4a5
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
merged commit 7c632b4
into
gh/swolchok/120/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/120/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
0d95292
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
a33092f
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok added a commit
that referenced
this pull request
Feb 12, 2025
@pytorchbotGithub Executorch@swolchok
Reuse GELU implementation from PyTorch core (#8322)
6727fea
* Reuse GELU implementation from PyTorch core
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
* apply @huydhn's fix to new code
* extra tweak from @huydhn
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: ops & kernelsChanges to the opset and any new / changed kernel implementations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@facebook-github-bot@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Reuse GELU implementation from PyTorch core - #7041
Merged
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Feb 7, 2025
Merged
Reuse GELU implementation from PyTorch core#7041
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it

externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: D66335522
@swolchok
Reuse GELU implementation from PyTorch core
ef0a735
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7041
Note: Links to docs will display an error until the docs builds have been completed.
❌ 2 New Failures
As of commit 5dac4a5 with merge base 832f855 (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522

This was referenced Nov 23, 2024
 Merged

 Merged

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
b3a0601
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1a59230
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
9ce0708
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
ca0fa70
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
f5a9843
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
rebase on "Reuse GELU implementation from PyTorch core"
0b5f154
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
abc7e4e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
8bb3c18
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c3002c6
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1576719
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c5acbdb
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 20, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
3590ed4
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
830e364
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
7d837ab
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
157df30
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
swolchok
commented
Feb 5, 2025

Copy link


Copy Markdown

ContributorAuthor
test-arm-reference-delegation failure is a known flake

test-llava-runner-linux failure might be real? CMake is failing to find Torch
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
79defe2
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 5, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
e87700d
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 264847499
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e02f65e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
3f314ef
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265115520
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e44c69c
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
23ef028
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265149952
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
5dac4a5
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
merged commit 7c632b4
into
gh/swolchok/120/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/120/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
0d95292
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
a33092f
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok added a commit
that referenced
this pull request
Feb 12, 2025
@pytorchbotGithub Executorch@swolchok
Reuse GELU implementation from PyTorch core (#8322)
6727fea
* Reuse GELU implementation from PyTorch core
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
* apply @huydhn's fix to new code
* extra tweak from @huydhn
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: ops & kernelsChanges to the opset and any new / changed kernel implementations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@facebook-github-bot@kimishpatel

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Reuse GELU implementation from PyTorch core - #7041
Merged
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Feb 7, 2025
Merged
Reuse GELU implementation from PyTorch core#7041
facebook-github-bot merged 45 commits into
gh/swolchok/120/basefrom 
gh/swolchok/120/head
Conversation
@swolchok
@swolchokswolchok
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Stack from ghstack (oldest at bottom):
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it

externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: D66335522
@swolchok
Reuse GELU implementation from PyTorch core
ef0a735
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@pytorch-bot
pytorch-botBot
commented
Nov 23, 2024•

edited

Loading

Copy link


Copy Markdown

🔗 Helpful Links
🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7041
Note: Links to docs will display an error until the docs builds have been completed.
❌ 2 New Failures
As of commit 5dac4a5 with merge base 832f855 (image):
NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-botfacebook-github-bot
added
the 
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Nov 23, 2024
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522

This was referenced Nov 23, 2024
 Merged

 Merged

@swolchok
Update on "Reuse GELU implementation from PyTorch core"
b3a0601
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1a59230
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@swolchokswolchok
mentioned this pull request
Nov 23, 2024
 Closed

@facebook-github-bot
facebook-github-bot
commented
Nov 23, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
9ce0708
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Nov 26, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
ca0fa70
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
f5a9843
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 2, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
rebase on "Reuse GELU implementation from PyTorch core"
0b5f154
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 8, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
abc7e4e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
8bb3c18
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 17, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c3002c6
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
1576719
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
c5acbdb
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Dec 20, 2024

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
3590ed4
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
Update on "Reuse GELU implementation from PyTorch core"
830e364
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Jan 30, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
7d837ab
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
157df30
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 4, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@swolchok
swolchok
commented
Feb 5, 2025

Copy link


Copy Markdown

ContributorAuthor
test-arm-reference-delegation failure is a known flake

test-llava-runner-linux failure might be real? CMake is failing to find Torch
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
79defe2
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 5, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 5, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
e87700d
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 264847499
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e02f65e
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
3f314ef
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265115520
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
e44c69c
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
swolchok pushed a commit
that referenced
this pull request
Feb 6, 2025
Github Executorch
Reuse GELU implementation from PyTorch core
23ef028
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265149952
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
@facebook-github-bot
facebook-github-bot
commented
Feb 6, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
Github Executorch
Update on "Reuse GELU implementation from PyTorch core"
5dac4a5
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
[ghstack-poisoned]
@facebook-github-bot
facebook-github-bot
commented
Feb 7, 2025

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D66335522
@facebook-github-bot
facebook-github-bot
merged commit 7c632b4
into
gh/swolchok/120/baseFeb 7, 2025
@facebook-github-bot
facebook-github-bot
deleted the

gh/swolchok/120/head

branch
February 7, 2025 23:03
@pytorchbotpytorchbot
mentioned this pull request
Feb 7, 2025
 Merged

swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
0d95292
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok pushed a commit
that referenced
this pull request
Feb 12, 2025
Github Executorch@swolchok
Reuse GELU implementation from PyTorch core
a33092f
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
swolchok added a commit
that referenced
this pull request
Feb 12, 2025
@pytorchbotGithub Executorch@swolchok
Reuse GELU implementation from PyTorch core (#8322)
6727fea
* Reuse GELU implementation from PyTorch core
Pull Request resolved: #7041
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch.
Note that, because we will pick up Sleef internally and ignore it
externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS.
Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break.
ghstack-source-id: 265190627
@exported-using-ghexport
Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/)
* apply @huydhn's fix to new code
* extra tweak from @huydhn
---------
Co-authored-by: Github Executorch <github_executorch@arm.com>
Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@kimishpatelkimishpatelkimishpatel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedrelease notes: ops & kernelsChanges to the opset and any new / changed kernel implementations

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok@facebook-github-bot@kimishpatel