Uh oh!
There was an error while loading. Please reload this page.
Add proper CMake build for extension_parallel - #8938
Merged
Conversation
swolchok
requested review from
GregoryComer, dbort and manuelcandales
as code ownersMarch 4, 2025 19:35
ContributorAuthor
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8938
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9fdebee with merge base 5dd96c3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok added a commit
that referenced
this pull request
Mar 4, 2025
Previously it was copied in several places per executorch_srcs.cmake. Needed for #8932 Test Plan: Compare cmake-out/executorch_srcs.cmake before/after for my usual testing cmake config with "all the CPU stuff" on; found that thread_parallel.cpp is now duplicated only in one place instead of multiple (it's in llama_runner, which needs a general fixup because it's duplicating several extensions). ghstack-source-id: 333d1c9 ghstack-comment-id: 2698715235 Pull Request resolved: #8938
larryliu0820
approved these changes
Mar 4, 2025
larryliu0820
left a comment
Contributor
There was a problem hiding this comment.
What is the difference between extension_threadpool and extension_parallel?
swolchok
commented
Mar 4, 2025
ContributorAuthor
extension_threadpool lives in extension/threadpool, and extension_parallel lives in extension/parallel. they're different code. |
swolchok
commented
Mar 4, 2025
ContributorAuthor
fixed tests -- forgot to |
swolchok added a commit
that referenced
this pull request
Mar 4, 2025
Previously it was copied in several places per executorch_srcs.cmake. Needed for #8932 Test Plan: Compare cmake-out/executorch_srcs.cmake before/after for my usual testing cmake config with "all the CPU stuff" on; found that thread_parallel.cpp is now duplicated only in one place instead of multiple (it's in llama_runner, which needs a general fixup because it's duplicating several extensions). ghstack-source-id: d491783 ghstack-comment-id: 2698715235 Pull Request resolved: #8938
kirklandsign
approved these changes
Mar 4, 2025
This was referenced Mar 4, 2025
swolchok added a commit
that referenced
this pull request
Mar 5, 2025
Previously it was copied in several places per executorch_srcs.cmake. Needed for #8932 Test Plan: Compare cmake-out/executorch_srcs.cmake before/after for my usual testing cmake config with "all the CPU stuff" on; found that thread_parallel.cpp is now duplicated only in one place instead of multiple (it's in llama_runner, which needs a general fixup because it's duplicating several extensions). ghstack-source-id: d09bf5e ghstack-comment-id: 2698715235 Pull Request resolved: #8938
zonglinpeng pushed a commit
that referenced
this pull request
Mar 6, 2025
Previously it was copied in several places per executorch_srcs.cmake. Needed for #8932 Test Plan: Compare cmake-out/executorch_srcs.cmake before/after for my usual testing cmake config with "all the CPU stuff" on; found that thread_parallel.cpp is now duplicated only in one place instead of multiple (it's in llama_runner, which needs a general fixup because it's duplicating several extensions).
This was referenced Mar 17, 2025
kedarnath03 pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Previously it was copied in several places per executorch_srcs.cmake. Needed for #8932 Test Plan: Compare cmake-out/executorch_srcs.cmake before/after for my usual testing cmake config with "all the CPU stuff" on; found that thread_parallel.cpp is now duplicated only in one place instead of multiple (it's in llama_runner, which needs a general fixup because it's duplicating several extensions). ghstack-source-id: d09bf5e ghstack-comment-id: 2698715235 Pull Request resolved: pytorch/executorch#8938
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was copied in several places per executorch_srcs.cmake.
Needed for #8932
Test Plan: Compare cmake-out/executorch_srcs.cmake before/after for my usual testing cmake config with "all the CPU stuff" on; found that thread_parallel.cpp is now duplicated only in one place instead of multiple (it's in llama_runner, which needs a general fixup because it's duplicating several extensions).