Skip to content

NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think it should be - #8948

Closed
swolchok wants to merge 25 commits into
mainfrom
gh/swolchok/309/head
Closed

NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think it should be#8948
swolchok wants to merge 25 commits into
mainfrom
gh/swolchok/309/head

Conversation

@swolchok

@swolchokswolchok commented Mar 4, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@swolchok
Update
d0b11e8
[ghstack-poisoned]
@swolchok
Update
9437be1
[ghstack-poisoned]
@swolchok
Update
643e10e
[ghstack-poisoned]
@swolchok
Update
6f2842b
[ghstack-poisoned]
@swolchok
Update
e47dfeb
[ghstack-poisoned]
@swolchok
Update
d4c7667
[ghstack-poisoned]
@swolchok

swolchok commented Mar 4, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Stack from ghstack (oldest at bottom):

@pytorch-bot

pytorch-botBot commented Mar 4, 2025•
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8948

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d556c38 with merge base cca6917 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Mar 4, 2025
Merged
Merged
Merged
swolchok added a commit that referenced this pull request Mar 4, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
cb309fb
…t should be
ghstack-source-id: 310b016
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2025
@swolchok
swolchok marked this pull request as draft March 4, 2025 22:57
@swolchok
Update
231ebc3
[ghstack-poisoned]
@swolchok
Update
296513c
[ghstack-poisoned]
@swolchok
Update
845a01e
[ghstack-poisoned]
@swolchok
Update
9fdba71
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
0342a25
…t should be
ghstack-source-id: 6d1de75
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
@swolchok
Update
a92958a
[ghstack-poisoned]
@swolchok
Update
3fa99d6
[ghstack-poisoned]
@swolchok
Update
a6c69a6
[ghstack-poisoned]
@swolchok
Update
dddebe0
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
4d868fc
…t should be
ghstack-source-id: 3cfa3ac
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
@swolchok
Update
3bd6437
[ghstack-poisoned]
@swolchok
Update
675f01b
[ghstack-poisoned]
@swolchok
Update
5f3a768
[ghstack-poisoned]
@swolchok
Update
6890f5e
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
349f645
…t should be
ghstack-source-id: 20e8cef
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
@swolchok
Update
9fdebee
[ghstack-poisoned]
@swolchok
Update
70a7096
[ghstack-poisoned]
@swolchok
Update
337dc23
[ghstack-poisoned]
@swolchok
Update
6e6b318
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
b51302d
…t should be
ghstack-source-id: 035e2db
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
@swolchok
Update
f388177
[ghstack-poisoned]
@swolchok
Update
2949daf
[ghstack-poisoned]
@swolchok
Update
d556c38
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
NOCOMMIT: fail CI if ET_USE_THREADPOOL isn't defined where we think i…
a6c79d0
…t should be
ghstack-source-id: 0e62bff
ghstack-comment-id: 2699165966
Pull Request resolved: #8948
@swolchok

swolchok commented Mar 5, 2025

Copy link
Copy Markdown
ContributorAuthor

noting that CI is 100% green in case I rebase

Base automatically changed from gh/swolchok/308/head to mainMarch 7, 2025 20:38
@github-actionsgithub-actionsBot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actionsgithub-actionsBot mentioned this pull request Mar 31, 2025
Open
@github-actionsgithub-actionsBot mentioned this pull request Apr 7, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackzhxngjackzhxngAwaiting requested review from jackzhxng
@iseeyuaniseeyuanAwaiting requested review from iseeyuan
@larryliu0820larryliu0820Awaiting requested review from larryliu0820larryliu0820 is a code owner
@kirklandsignkirklandsignAwaiting requested review from kirklandsignkirklandsign is a code owner
@lucylqlucylqAwaiting requested review from lucylq
@mergennachinmergennachinAwaiting requested review from mergennachinmergennachin will be requested when the pull request is marked ready for reviewmergennachin is a code owner
@psiddhpsiddhAwaiting requested review from psiddhpsiddh will be requested when the pull request is marked ready for reviewpsiddh is a code owner

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swolchok@facebook-github-bot