fix: Add runtime error when Metro config cannot be resolved

[huntie]

Summary:

Relates to:

• breaking: Update cli-plugin-metro to use defaults in app metro.config.js (RN 0.72) #1875
• RFC: Add @react-native/metro-config package react/react-native#36502
• Bump RN CLI, add @react-native/metro-config to template react/react-native#36623

While preparing react/react-native#36623, we discovered that (post monorepo) a few scripts in the React Native repo were starting RN CLI in directories outside of the project dir and weren't reading metro.config.js as expected — printing obscure errors due to missing config items.

This PR updates the CLI to throw a runtime error when resolveConfig fails for the target working directory (ctx.root). This is an important DevX enhancement, since a complete metro.config.js file will be required from React Native 0.72.

Test Plan:

Pre-steps:

• Run yarn link in local clone of RN CLI.
• Run yarn link @react-native-community/cli-plugin-metro inside packages/rn-tester (local facebook/react-native repo clone).

✅ Now throws for yarn start in packages/rn-tester.

• Previously, this would start Metro and throw harder-to-understand errors due to missing config items.

(Note: I'm open to suggestions for an improved error message/method of erroring to improve the CLI output.)

✅ Does not throw when yarn start command is fixed

• (I've added a local console.log() to print the config file name)

[szymonrybczak]

Thanks for the fix 🎉 I see that you changed the command from direct call ../react-native/scripts/packager.sh to react-native start, will you update that inside rn-tester?

[huntie]

@szymonrybczak Yes! This PR is basically a test plan for that package.json change haha:

• Fix paths in objc-test.sh, temporarily exclude /IntegrationTests react/react-native#36648

[szymonrybczak]

Cool! So in future we can get rid of launchPackager.command and packager.sh because they'll useless - nothing will use those scripts. (Since we have your PR, #1812, and I plan to remove calling this script in "Start packager" build phase).

[huntie]

Updated to address feedback. Ready to merge.

[thymikee]

@huntie I've updated the wording and replaced console.warn with logger.warn. LGTM

[tido64]

Hi folks, can we pick this into 11.x? Things are currently broken without it.

[zhiqingchen]

hi @huntie
Do you know why the reporter needs to be overridden again?

if(options.reporter){overrideConfig.reporter=options.reporter;}

loadConfig() already set reporter from options

loadConfig({cwd: ctx.root, ...options})

[huntie]

Summary:

Relates to:

• breaking: Update cli-plugin-metro to use defaults in app metro.config.js (RN 0.72) #1875
• RFC: Add @react-native/metro-config package react/react-native#36502
• Bump RN CLI, add @react-native/metro-config to template react/react-native#36623

While preparing react/react-native#36623, we discovered that (post monorepo) a few scripts in the React Native repo were starting RN CLI in directories outside of the project dir and weren't reading metro.config.js as expected — printing obscure errors due to missing config items.

This PR updates the CLI to throw a runtime error when resolveConfig fails for the target working directory (ctx.root). This is an important DevX enhancement, since a complete metro.config.js file will be required from React Native 0.72.

Test Plan:

Pre-steps:

• Run yarn link in local clone of RN CLI.
• Run yarn link @react-native-community/cli-plugin-metro inside packages/rn-tester (local facebook/react-native repo clone).

✅ Now throws for yarn start in packages/rn-tester.

• Previously, this would start Metro and throw harder-to-understand errors due to missing config items.

(Note: I'm open to suggestions for an improved error message/method of erroring to improve the CLI output.)

✅ Does not throw when yarn start command is fixed

• (I've added a local console.log() to print the config file name)

[szymonrybczak]

Thanks for the fix 🎉 I see that you changed the command from direct call ../react-native/scripts/packager.sh to react-native start, will you update that inside rn-tester?

[huntie]

@szymonrybczak Yes! This PR is basically a test plan for that package.json change haha:

• Fix paths in objc-test.sh, temporarily exclude /IntegrationTests react/react-native#36648

[szymonrybczak]

Cool! So in future we can get rid of launchPackager.command and packager.sh because they'll useless - nothing will use those scripts. (Since we have your PR, #1812, and I plan to remove calling this script in "Start packager" build phase).

[huntie]

Updated to address feedback. Ready to merge.

[thymikee]

@huntie I've updated the wording and replaced console.warn with logger.warn. LGTM

[tido64]

Hi folks, can we pick this into 11.x? Things are currently broken without it.

[zhiqingchen]

hi @huntie
Do you know why the reporter needs to be overridden again?

if(options.reporter){overrideConfig.reporter=options.reporter;}

loadConfig() already set reporter from options

loadConfig({cwd: ctx.root, ...options})

[huntie]

Summary:

Relates to:

• breaking: Update cli-plugin-metro to use defaults in app metro.config.js (RN 0.72) #1875
• RFC: Add @react-native/metro-config package react/react-native#36502
• Bump RN CLI, add @react-native/metro-config to template react/react-native#36623

While preparing react/react-native#36623, we discovered that (post monorepo) a few scripts in the React Native repo were starting RN CLI in directories outside of the project dir and weren't reading metro.config.js as expected — printing obscure errors due to missing config items.

This PR updates the CLI to throw a runtime error when resolveConfig fails for the target working directory (ctx.root). This is an important DevX enhancement, since a complete metro.config.js file will be required from React Native 0.72.

Test Plan:

Pre-steps:

• Run yarn link in local clone of RN CLI.
• Run yarn link @react-native-community/cli-plugin-metro inside packages/rn-tester (local facebook/react-native repo clone).

✅ Now throws for yarn start in packages/rn-tester.

• Previously, this would start Metro and throw harder-to-understand errors due to missing config items.

(Note: I'm open to suggestions for an improved error message/method of erroring to improve the CLI output.)

✅ Does not throw when yarn start command is fixed

• (I've added a local console.log() to print the config file name)

[szymonrybczak]

Thanks for the fix 🎉 I see that you changed the command from direct call ../react-native/scripts/packager.sh to react-native start, will you update that inside rn-tester?

[huntie]

@szymonrybczak Yes! This PR is basically a test plan for that package.json change haha:

• Fix paths in objc-test.sh, temporarily exclude /IntegrationTests react/react-native#36648

[szymonrybczak]

Cool! So in future we can get rid of launchPackager.command and packager.sh because they'll useless - nothing will use those scripts. (Since we have your PR, #1812, and I plan to remove calling this script in "Start packager" build phase).

[huntie]

Updated to address feedback. Ready to merge.

[thymikee]

@huntie I've updated the wording and replaced console.warn with logger.warn. LGTM

[tido64]

Hi folks, can we pick this into 11.x? Things are currently broken without it.

[zhiqingchen]

hi @huntie
Do you know why the reporter needs to be overridden again?

if(options.reporter){overrideConfig.reporter=options.reporter;}

loadConfig() already set reporter from options

loadConfig({cwd: ctx.root, ...options})

[huntie]

Summary:

Relates to:

• breaking: Update cli-plugin-metro to use defaults in app metro.config.js (RN 0.72) #1875
• RFC: Add @react-native/metro-config package react/react-native#36502
• Bump RN CLI, add @react-native/metro-config to template react/react-native#36623

While preparing react/react-native#36623, we discovered that (post monorepo) a few scripts in the React Native repo were starting RN CLI in directories outside of the project dir and weren't reading metro.config.js as expected — printing obscure errors due to missing config items.

This PR updates the CLI to throw a runtime error when resolveConfig fails for the target working directory (ctx.root). This is an important DevX enhancement, since a complete metro.config.js file will be required from React Native 0.72.

Test Plan:

Pre-steps:

• Run yarn link in local clone of RN CLI.
• Run yarn link @react-native-community/cli-plugin-metro inside packages/rn-tester (local facebook/react-native repo clone).

✅ Now throws for yarn start in packages/rn-tester.

• Previously, this would start Metro and throw harder-to-understand errors due to missing config items.

(Note: I'm open to suggestions for an improved error message/method of erroring to improve the CLI output.)

✅ Does not throw when yarn start command is fixed

• (I've added a local console.log() to print the config file name)

[szymonrybczak]

Thanks for the fix 🎉 I see that you changed the command from direct call ../react-native/scripts/packager.sh to react-native start, will you update that inside rn-tester?

[huntie]

@szymonrybczak Yes! This PR is basically a test plan for that package.json change haha:

• Fix paths in objc-test.sh, temporarily exclude /IntegrationTests react/react-native#36648

[szymonrybczak]

Cool! So in future we can get rid of launchPackager.command and packager.sh because they'll useless - nothing will use those scripts. (Since we have your PR, #1812, and I plan to remove calling this script in "Start packager" build phase).

[huntie]

Updated to address feedback. Ready to merge.

[thymikee]

@huntie I've updated the wording and replaced console.warn with logger.warn. LGTM

[tido64]

Hi folks, can we pick this into 11.x? Things are currently broken without it.

[zhiqingchen]

hi @huntie
Do you know why the reporter needs to be overridden again?

if(options.reporter){overrideConfig.reporter=options.reporter;}

loadConfig() already set reporter from options

loadConfig({cwd: ctx.root, ...options})

[huntie]

Summary:

Relates to:

• breaking: Update cli-plugin-metro to use defaults in app metro.config.js (RN 0.72) #1875
• RFC: Add @react-native/metro-config package react/react-native#36502
• Bump RN CLI, add @react-native/metro-config to template react/react-native#36623

While preparing react/react-native#36623, we discovered that (post monorepo) a few scripts in the React Native repo were starting RN CLI in directories outside of the project dir and weren't reading metro.config.js as expected — printing obscure errors due to missing config items.

This PR updates the CLI to throw a runtime error when resolveConfig fails for the target working directory (ctx.root). This is an important DevX enhancement, since a complete metro.config.js file will be required from React Native 0.72.

Test Plan:

Pre-steps:

• Run yarn link in local clone of RN CLI.
• Run yarn link @react-native-community/cli-plugin-metro inside packages/rn-tester (local facebook/react-native repo clone).

✅ Now throws for yarn start in packages/rn-tester.

• Previously, this would start Metro and throw harder-to-understand errors due to missing config items.

(Note: I'm open to suggestions for an improved error message/method of erroring to improve the CLI output.)

✅ Does not throw when yarn start command is fixed

• (I've added a local console.log() to print the config file name)

[szymonrybczak]

Thanks for the fix 🎉 I see that you changed the command from direct call ../react-native/scripts/packager.sh to react-native start, will you update that inside rn-tester?

[huntie]

@szymonrybczak Yes! This PR is basically a test plan for that package.json change haha:

• Fix paths in objc-test.sh, temporarily exclude /IntegrationTests react/react-native#36648

[szymonrybczak]

Cool! So in future we can get rid of launchPackager.command and packager.sh because they'll useless - nothing will use those scripts. (Since we have your PR, #1812, and I plan to remove calling this script in "Start packager" build phase).

[huntie]

Updated to address feedback. Ready to merge.

[thymikee]

@huntie I've updated the wording and replaced console.warn with logger.warn. LGTM

[tido64]

Hi folks, can we pick this into 11.x? Things are currently broken without it.

[zhiqingchen]

hi @huntie
Do you know why the reporter needs to be overridden again?

if(options.reporter){overrideConfig.reporter=options.reporter;}

loadConfig() already set reporter from options

loadConfig({cwd: ctx.root, ...options})

[huntie]

Summary:

Relates to:

• breaking: Update cli-plugin-metro to use defaults in app metro.config.js (RN 0.72) #1875
• RFC: Add @react-native/metro-config package react/react-native#36502
• Bump RN CLI, add @react-native/metro-config to template react/react-native#36623

While preparing react/react-native#36623, we discovered that (post monorepo) a few scripts in the React Native repo were starting RN CLI in directories outside of the project dir and weren't reading metro.config.js as expected — printing obscure errors due to missing config items.

This PR updates the CLI to throw a runtime error when resolveConfig fails for the target working directory (ctx.root). This is an important DevX enhancement, since a complete metro.config.js file will be required from React Native 0.72.

Test Plan:

Pre-steps:

• Run yarn link in local clone of RN CLI.
• Run yarn link @react-native-community/cli-plugin-metro inside packages/rn-tester (local facebook/react-native repo clone).

✅ Now throws for yarn start in packages/rn-tester.

• Previously, this would start Metro and throw harder-to-understand errors due to missing config items.

(Note: I'm open to suggestions for an improved error message/method of erroring to improve the CLI output.)

✅ Does not throw when yarn start command is fixed

• (I've added a local console.log() to print the config file name)

[szymonrybczak]

Thanks for the fix 🎉 I see that you changed the command from direct call ../react-native/scripts/packager.sh to react-native start, will you update that inside rn-tester?

[huntie]

@szymonrybczak Yes! This PR is basically a test plan for that package.json change haha:

• Fix paths in objc-test.sh, temporarily exclude /IntegrationTests react/react-native#36648

[szymonrybczak]

Cool! So in future we can get rid of launchPackager.command and packager.sh because they'll useless - nothing will use those scripts. (Since we have your PR, #1812, and I plan to remove calling this script in "Start packager" build phase).

[huntie]

Updated to address feedback. Ready to merge.

[thymikee]

@huntie I've updated the wording and replaced console.warn with logger.warn. LGTM

[tido64]

Hi folks, can we pick this into 11.x? Things are currently broken without it.

[zhiqingchen]

hi @huntie
Do you know why the reporter needs to be overridden again?

if(options.reporter){overrideConfig.reporter=options.reporter;}

loadConfig() already set reporter from options

loadConfig({cwd: ctx.root, ...options})

[huntie]

Summary:

Relates to:

• breaking: Update cli-plugin-metro to use defaults in app metro.config.js (RN 0.72) #1875
• RFC: Add @react-native/metro-config package react/react-native#36502
• Bump RN CLI, add @react-native/metro-config to template react/react-native#36623

While preparing react/react-native#36623, we discovered that (post monorepo) a few scripts in the React Native repo were starting RN CLI in directories outside of the project dir and weren't reading metro.config.js as expected — printing obscure errors due to missing config items.

This PR updates the CLI to throw a runtime error when resolveConfig fails for the target working directory (ctx.root). This is an important DevX enhancement, since a complete metro.config.js file will be required from React Native 0.72.

Test Plan:

Pre-steps:

• Run yarn link in local clone of RN CLI.
• Run yarn link @react-native-community/cli-plugin-metro inside packages/rn-tester (local facebook/react-native repo clone).

✅ Now throws for yarn start in packages/rn-tester.

• Previously, this would start Metro and throw harder-to-understand errors due to missing config items.

(Note: I'm open to suggestions for an improved error message/method of erroring to improve the CLI output.)

✅ Does not throw when yarn start command is fixed

• (I've added a local console.log() to print the config file name)

[szymonrybczak]

Thanks for the fix 🎉 I see that you changed the command from direct call ../react-native/scripts/packager.sh to react-native start, will you update that inside rn-tester?

[huntie]

@szymonrybczak Yes! This PR is basically a test plan for that package.json change haha:

• Fix paths in objc-test.sh, temporarily exclude /IntegrationTests react/react-native#36648

[szymonrybczak]

Cool! So in future we can get rid of launchPackager.command and packager.sh because they'll useless - nothing will use those scripts. (Since we have your PR, #1812, and I plan to remove calling this script in "Start packager" build phase).

[huntie]

Updated to address feedback. Ready to merge.

[thymikee]

@huntie I've updated the wording and replaced console.warn with logger.warn. LGTM

[tido64]

Hi folks, can we pick this into 11.x? Things are currently broken without it.

[zhiqingchen]

hi @huntie
Do you know why the reporter needs to be overridden again?

if(options.reporter){overrideConfig.reporter=options.reporter;}

loadConfig() already set reporter from options

loadConfig({cwd: ctx.root, ...options})

[huntie]

Summary:

Relates to:

• breaking: Update cli-plugin-metro to use defaults in app metro.config.js (RN 0.72) #1875
• RFC: Add @react-native/metro-config package react/react-native#36502
• Bump RN CLI, add @react-native/metro-config to template react/react-native#36623

While preparing react/react-native#36623, we discovered that (post monorepo) a few scripts in the React Native repo were starting RN CLI in directories outside of the project dir and weren't reading metro.config.js as expected — printing obscure errors due to missing config items.

This PR updates the CLI to throw a runtime error when resolveConfig fails for the target working directory (ctx.root). This is an important DevX enhancement, since a complete metro.config.js file will be required from React Native 0.72.

Test Plan:

Pre-steps:

• Run yarn link in local clone of RN CLI.
• Run yarn link @react-native-community/cli-plugin-metro inside packages/rn-tester (local facebook/react-native repo clone).

✅ Now throws for yarn start in packages/rn-tester.

• Previously, this would start Metro and throw harder-to-understand errors due to missing config items.

(Note: I'm open to suggestions for an improved error message/method of erroring to improve the CLI output.)

✅ Does not throw when yarn start command is fixed

• (I've added a local console.log() to print the config file name)

[szymonrybczak]

Thanks for the fix 🎉 I see that you changed the command from direct call ../react-native/scripts/packager.sh to react-native start, will you update that inside rn-tester?

[huntie]

@szymonrybczak Yes! This PR is basically a test plan for that package.json change haha:

• Fix paths in objc-test.sh, temporarily exclude /IntegrationTests react/react-native#36648

[szymonrybczak]

Cool! So in future we can get rid of launchPackager.command and packager.sh because they'll useless - nothing will use those scripts. (Since we have your PR, #1812, and I plan to remove calling this script in "Start packager" build phase).

[huntie]

Updated to address feedback. Ready to merge.

[thymikee]

@huntie I've updated the wording and replaced console.warn with logger.warn. LGTM

[tido64]

Hi folks, can we pick this into 11.x? Things are currently broken without it.

[zhiqingchen]

hi @huntie
Do you know why the reporter needs to be overridden again?

if(options.reporter){overrideConfig.reporter=options.reporter;}

loadConfig() already set reporter from options

loadConfig({cwd: ctx.root, ...options})