Skip to content

Fix paths in objc-test.sh, temporarily exclude /IntegrationTests - #36648

Closed
huntie wants to merge 1 commit into
react:mainfrom
huntie:export-D44416533
Closed

Fix paths in objc-test.sh, temporarily exclude /IntegrationTests#36648
huntie wants to merge 1 commit into
react:mainfrom
huntie:export-D44416533

Conversation

@huntie

@huntiehuntie commented Mar 27, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary:
Changelog: [Internal]

Blocker for #36623. The test-ios job in CI was misconfigured following the monorepo migration — and becomes load-bearing with the incoming version of React Native CLI.

  • Update objc-test.sh to run in packages/rn-tester, and exclude tests under /IntegrationTests which are outside of a Metro project directory (before the monorepo changes, this was logically inside packages/react-native).
    • This is temporary — a task has been created to move/split up/otherwise restore tests in IntegrationTests, which @cipolleschi is following up (thanks!).
  • Also fix yarn start script in packages/rn-tester.

Differential Revision: D44416533

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 27, 2023
@facebook-github-bot

facebook-github-bot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44416533

@analysis-bot

analysis-bot commented Mar 27, 2023•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,519,412+0
androidhermesarmeabi-v7a7,835,707+0
androidhermesx868,998,551+0
androidhermesx86_648,854,715+0
androidjscarm64-v8a9,140,564+0
androidjscarmeabi-v7a8,332,777+0
androidjscx869,194,234+0
androidjscx86_649,453,310+0

Base commit: 04df252
Branch: main

@facebook-github-bot

facebook-github-bot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44416533

3 similar comments
@facebook-github-bot

facebook-github-bot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44416533

@facebook-github-bot

facebook-github-bot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44416533

@facebook-github-bot

facebook-github-bot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44416533

@huntiehuntie mentioned this pull request Mar 27, 2023
Merged
@huntie@facebook-github-bot
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests (#36648
387c218
)
Summary:
Pull Request resolved: #36648
Changelog: [Internal]
Blocker for #36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI.
- Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory.
- **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!).
- Also fix `yarn start` script in `packages/rn-tester`.
Reviewed By: cipolleschi
Differential Revision: D44416533
fbshipit-source-id: 2b1709b05f315630af3cd3b8dcfa1afd13116e0b
@facebook-github-bot

facebook-github-bot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44416533

@huntiehuntie closed this by deleting the head repository Mar 27, 2023
@facebook-github-bot

facebook-github-bot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D44416533

@huntiehuntie reopened this Mar 27, 2023
@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Mar 27, 2023
@facebook-github-bot

facebook-github-bot commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

This pull request has been merged in 32e836d.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntie@facebook-github-bot@analysis-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests by huntie · Pull Request #36648 · react/react-native · GitHub
Skip to content
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests - #36648
Closed
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Closed
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests#36648
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Conversation
@huntie
@huntiehuntie
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Summary:

Changelog: [Internal]
Blocker for #36623. The test-ios job in CI was misconfigured following the monorepo migration — and becomes load-bearing with the incoming version of React Native CLI.
  • Update objc-test.sh to run in packages/rn-tester, and exclude tests under /IntegrationTests which are outside of a Metro project directory (before the monorepo changes, this was logically inside packages/react-native).

    • This is temporary — a task has been created to move/split up/otherwise restore tests in IntegrationTests, which @cipolleschi is following up (thanks!).
  • Also fix yarn start script in packages/rn-tester.
Differential Revision: D44416533
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@analysis-bot
analysis-bot
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,519,412+0
androidhermesarmeabi-v7a7,835,707+0
androidhermesx868,998,551+0
androidhermesx86_648,854,715+0
androidjscarm64-v8a9,140,564+0
androidjscarmeabi-v7a8,332,777+0
androidjscx869,194,234+0
androidjscx86_649,453,310+0
Base commit: 04df252

Branch: main
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533

3 similar comments

@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
mentioned this pull request
Mar 27, 2023
 Merged

@huntie@facebook-github-bot
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests (#36648
387c218
)
Summary:
Pull Request resolved: #36648
Changelog: [Internal]
Blocker for #36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI.
- Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory.
- **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!).
- Also fix `yarn start` script in `packages/rn-tester`.
Reviewed By: cipolleschi
Differential Revision: D44416533
fbshipit-source-id: 2b1709b05f315630af3cd3b8dcfa1afd13116e0b
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
closed this by deleting the head repository
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
reopened this
Mar 27, 2023
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in 32e836d.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@huntie@facebook-github-bot@analysis-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests by huntie · Pull Request #36648 · react/react-native · GitHub
Skip to content
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests - #36648
Closed
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Closed
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests#36648
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Conversation
@huntie
@huntiehuntie
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Summary:

Changelog: [Internal]
Blocker for #36623. The test-ios job in CI was misconfigured following the monorepo migration — and becomes load-bearing with the incoming version of React Native CLI.
  • Update objc-test.sh to run in packages/rn-tester, and exclude tests under /IntegrationTests which are outside of a Metro project directory (before the monorepo changes, this was logically inside packages/react-native).

    • This is temporary — a task has been created to move/split up/otherwise restore tests in IntegrationTests, which @cipolleschi is following up (thanks!).
  • Also fix yarn start script in packages/rn-tester.
Differential Revision: D44416533
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@analysis-bot
analysis-bot
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,519,412+0
androidhermesarmeabi-v7a7,835,707+0
androidhermesx868,998,551+0
androidhermesx86_648,854,715+0
androidjscarm64-v8a9,140,564+0
androidjscarmeabi-v7a8,332,777+0
androidjscx869,194,234+0
androidjscx86_649,453,310+0
Base commit: 04df252

Branch: main
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533

3 similar comments

@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
mentioned this pull request
Mar 27, 2023
 Merged

@huntie@facebook-github-bot
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests (#36648
387c218
)
Summary:
Pull Request resolved: #36648
Changelog: [Internal]
Blocker for #36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI.
- Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory.
- **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!).
- Also fix `yarn start` script in `packages/rn-tester`.
Reviewed By: cipolleschi
Differential Revision: D44416533
fbshipit-source-id: 2b1709b05f315630af3cd3b8dcfa1afd13116e0b
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
closed this by deleting the head repository
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
reopened this
Mar 27, 2023
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in 32e836d.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@huntie@facebook-github-bot@analysis-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests by huntie · Pull Request #36648 · react/react-native · GitHub
Skip to content
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests - #36648
Closed
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Closed
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests#36648
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Conversation
@huntie
@huntiehuntie
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Summary:

Changelog: [Internal]
Blocker for #36623. The test-ios job in CI was misconfigured following the monorepo migration — and becomes load-bearing with the incoming version of React Native CLI.
  • Update objc-test.sh to run in packages/rn-tester, and exclude tests under /IntegrationTests which are outside of a Metro project directory (before the monorepo changes, this was logically inside packages/react-native).

    • This is temporary — a task has been created to move/split up/otherwise restore tests in IntegrationTests, which @cipolleschi is following up (thanks!).
  • Also fix yarn start script in packages/rn-tester.
Differential Revision: D44416533
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@analysis-bot
analysis-bot
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,519,412+0
androidhermesarmeabi-v7a7,835,707+0
androidhermesx868,998,551+0
androidhermesx86_648,854,715+0
androidjscarm64-v8a9,140,564+0
androidjscarmeabi-v7a8,332,777+0
androidjscx869,194,234+0
androidjscx86_649,453,310+0
Base commit: 04df252

Branch: main
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533

3 similar comments

@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
mentioned this pull request
Mar 27, 2023
 Merged

@huntie@facebook-github-bot
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests (#36648
387c218
)
Summary:
Pull Request resolved: #36648
Changelog: [Internal]
Blocker for #36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI.
- Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory.
- **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!).
- Also fix `yarn start` script in `packages/rn-tester`.
Reviewed By: cipolleschi
Differential Revision: D44416533
fbshipit-source-id: 2b1709b05f315630af3cd3b8dcfa1afd13116e0b
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
closed this by deleting the head repository
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
reopened this
Mar 27, 2023
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in 32e836d.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@huntie@facebook-github-bot@analysis-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests by huntie · Pull Request #36648 · react/react-native · GitHub
Skip to content
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests - #36648
Closed
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Closed
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests#36648
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Conversation
@huntie
@huntiehuntie
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Summary:

Changelog: [Internal]
Blocker for #36623. The test-ios job in CI was misconfigured following the monorepo migration — and becomes load-bearing with the incoming version of React Native CLI.
  • Update objc-test.sh to run in packages/rn-tester, and exclude tests under /IntegrationTests which are outside of a Metro project directory (before the monorepo changes, this was logically inside packages/react-native).

    • This is temporary — a task has been created to move/split up/otherwise restore tests in IntegrationTests, which @cipolleschi is following up (thanks!).
  • Also fix yarn start script in packages/rn-tester.
Differential Revision: D44416533
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@analysis-bot
analysis-bot
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,519,412+0
androidhermesarmeabi-v7a7,835,707+0
androidhermesx868,998,551+0
androidhermesx86_648,854,715+0
androidjscarm64-v8a9,140,564+0
androidjscarmeabi-v7a8,332,777+0
androidjscx869,194,234+0
androidjscx86_649,453,310+0
Base commit: 04df252

Branch: main
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533

3 similar comments

@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
mentioned this pull request
Mar 27, 2023
 Merged

@huntie@facebook-github-bot
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests (#36648
387c218
)
Summary:
Pull Request resolved: #36648
Changelog: [Internal]
Blocker for #36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI.
- Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory.
- **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!).
- Also fix `yarn start` script in `packages/rn-tester`.
Reviewed By: cipolleschi
Differential Revision: D44416533
fbshipit-source-id: 2b1709b05f315630af3cd3b8dcfa1afd13116e0b
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
closed this by deleting the head repository
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
reopened this
Mar 27, 2023
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in 32e836d.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@huntie@facebook-github-bot@analysis-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests by huntie · Pull Request #36648 · react/react-native · GitHub
Skip to content
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests - #36648
Closed
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Closed
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests#36648
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Conversation
@huntie
@huntiehuntie
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Summary:

Changelog: [Internal]
Blocker for #36623. The test-ios job in CI was misconfigured following the monorepo migration — and becomes load-bearing with the incoming version of React Native CLI.
  • Update objc-test.sh to run in packages/rn-tester, and exclude tests under /IntegrationTests which are outside of a Metro project directory (before the monorepo changes, this was logically inside packages/react-native).

    • This is temporary — a task has been created to move/split up/otherwise restore tests in IntegrationTests, which @cipolleschi is following up (thanks!).
  • Also fix yarn start script in packages/rn-tester.
Differential Revision: D44416533
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@analysis-bot
analysis-bot
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,519,412+0
androidhermesarmeabi-v7a7,835,707+0
androidhermesx868,998,551+0
androidhermesx86_648,854,715+0
androidjscarm64-v8a9,140,564+0
androidjscarmeabi-v7a8,332,777+0
androidjscx869,194,234+0
androidjscx86_649,453,310+0
Base commit: 04df252

Branch: main
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533

3 similar comments

@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
mentioned this pull request
Mar 27, 2023
 Merged

@huntie@facebook-github-bot
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests (#36648
387c218
)
Summary:
Pull Request resolved: #36648
Changelog: [Internal]
Blocker for #36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI.
- Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory.
- **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!).
- Also fix `yarn start` script in `packages/rn-tester`.
Reviewed By: cipolleschi
Differential Revision: D44416533
fbshipit-source-id: 2b1709b05f315630af3cd3b8dcfa1afd13116e0b
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
closed this by deleting the head repository
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
reopened this
Mar 27, 2023
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in 32e836d.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@huntie@facebook-github-bot@analysis-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests by huntie · Pull Request #36648 · react/react-native · GitHub
Skip to content
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests - #36648
Closed
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Closed
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests#36648
huntie wants to merge 1 commit into
react:mainfrom 
huntie:export-D44416533
Conversation
@huntie
@huntiehuntie
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

Collaborator
Summary:

Changelog: [Internal]
Blocker for #36623. The test-ios job in CI was misconfigured following the monorepo migration — and becomes load-bearing with the incoming version of React Native CLI.
  • Update objc-test.sh to run in packages/rn-tester, and exclude tests under /IntegrationTests which are outside of a Metro project directory (before the monorepo changes, this was logically inside packages/react-native).

    • This is temporary — a task has been created to move/split up/otherwise restore tests in IntegrationTests, which @cipolleschi is following up (thanks!).
  • Also fix yarn start script in packages/rn-tester.
Differential Revision: D44416533
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner

fb-exported

labels
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@analysis-bot
analysis-bot
commented
Mar 27, 2023•

edited

Loading

Copy link


Copy Markdown

PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,519,412+0
androidhermesarmeabi-v7a7,835,707+0
androidhermesx868,998,551+0
androidhermesx86_648,854,715+0
androidjscarm64-v8a9,140,564+0
androidjscarmeabi-v7a8,332,777+0
androidjscx869,194,234+0
androidjscx86_649,453,310+0
Base commit: 04df252

Branch: main
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533

3 similar comments

@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
mentioned this pull request
Mar 27, 2023
 Merged

@huntie@facebook-github-bot
Fix paths in objc-test.sh, temporarily exclude /IntegrationTests (#36648
387c218
)
Summary:
Pull Request resolved: #36648
Changelog: [Internal]
Blocker for #36623. The `test-ios` job in CI was misconfigured following the monorepo migration — and this becomes load-bearing with the incoming version of React Native CLI.
- Update `objc-test.sh` to run in `packages/rn-tester`, and exclude tests under `/IntegrationTests` which are outside of a Metro project directory.
- **This is temporary** — a task has been created to move/split up/otherwise restore tests in `IntegrationTests`, which cipolleschi is following up (thanks!).
- Also fix `yarn start` script in `packages/rn-tester`.
Reviewed By: cipolleschi
Differential Revision: D44416533
fbshipit-source-id: 2b1709b05f315630af3cd3b8dcfa1afd13116e0b
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
closed this by deleting the head repository
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request was exported from Phabricator. Differential Revision: D44416533
@huntiehuntie
reopened this
Mar 27, 2023
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Mar 27, 2023
@facebook-github-bot
facebook-github-bot
commented
Mar 27, 2023

Copy link


Copy Markdown

Contributor
This pull request has been merged in 32e836d.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMergedThis PR has been merged.p: FacebookPartner: FacebookPartner

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@huntie@facebook-github-bot@analysis-bot