fix(macCatalyst): construct correct path for macCatalyst build

[mikehardy]

Summary:

Hi there! I have a demo script I use to test ios + android builds in both debug+release on rc candidates to make sure react-native-firebase will work with upcoming releases

I'm testing the 0.74-rc series now

It also tests macCatalyst builds, and since that's a pretty niche build setup I frequently find little issues.

I believe I found a little issue here, where after the build (which did work...) there was no ability to launch the macCatalyst app because the path construction for the macCatalyst build was very subtly incorrect

---

Related but not completely related:

I actually have a separate issue with macCatalyst builds in that it is impossible without a hacky-patch to target macCatalyst from the command line but I'm not sure what to do with that. Explanation here in the patch

---

Test Plan:

This was tested via patch-package applying this patch to the build code for the cli-platform-package package in node_modules in an automated build harness that I have here (this is pointing to the 0.74 rc testing branch: https://github.com/mikehardy/rnfbdemo/blob/rn74/make-demo.sh)

Checklist

• Documentation is up to date to reflect these changes.
• Follows commit message convention described in CONTRIBUTING.md

[szymonrybczak]

Thank you for fixing! Ah, as always small details introduces bugs :D I've introduced while doing a refactor #2234 😅 Will make sure that it will land in the next RC 🙌

[szymonrybczak]

I actually have a separate issue with macCatalyst builds in that it is impossible without a hacky-patch to target macCatalyst from the command line but I'm not sure what to do with that. Explanation here in the patch

Could you please create a separate issue with this problem? 🙏 I would love to help:)

[mikehardy]

I actually have a separate issue with macCatalyst builds in that it is impossible without a hacky-patch to target macCatalyst from the command line but I'm not sure what to do with that. Explanation here in the patch

Could you please create a separate issue with this problem? 🙏 I would love to help:)

Sure - I've got the issue well identified at least but....I'm not even sure how to handle it so it would be nice to have a collaborator. Normally the solution is obvious and I'll just post a PR but right now what I've got is a hack. Anyway, I'll make an issue.

Thanks for shepherding this fix in this PR though though :-)

[cortinico]

@szymonrybczak can we get this merged and shipped in a CLI point release, otherwise this won't make it inside 0.74

[cortinico]

@szymonrybczak this change is not included in any release of the CLI. Can we release it in a point release so we can include inside RC4?

[thymikee]

Released in v13.6.2, thanks!

[cortinico]

Released in v13.6.2, thanks!

@thymikee@szymonrybczak can one of you bump the CLI against the release branch and against main?

[thymikee]

@cortinico released main as 14.0.0-alpha.0 ✨

[szymonrybczak]

Released in v13.6.2, thanks!

@thymikee@szymonrybczak can one of you bump the CLI against the release branch and against main?

0.74-stable -> react/react-native#43414

main -> react/react-native#43415