Skip to content

chore: remove "rnpm" - #790

Merged
thymikee merged 32 commits into
nextfrom
feat/remove-link
Oct 17, 2019
Merged

chore: remove "rnpm"#790
thymikee merged 32 commits into
nextfrom
feat/remove-link

Conversation

@grabbou

@grabbougrabbou commented Oct 14, 2019•
edited
Loading

Copy link
Copy Markdown
Member

This PR removes all rnpm configuration files and related code. Everything was already deprecated and messages were being displayed.

This will ship with the next React Native.

Removed:

  • link
  • unlink
  • install
  • uninstall
  • hooks, params and assets (now taken care by autolinking or not supported)
  • linkConfig + extraneous config properties
  • RNPM migration guides from documentation

Updated:

  • Documentation to use TypeScript instead of Flow in the interface breakdown

This implements react-native-community/discussions-and-proposals#96

@grabbougrabbou changed the title chore: remove deprecated old linkchore: remove "rnpm"Oct 15, 2019
@grabbou

grabbou commented Oct 15, 2019

Copy link
Copy Markdown
MemberAuthor

e2e tests are also working now because install and uninstall were flaky (now removed).

@grabbou

grabbou commented Oct 15, 2019

Copy link
Copy Markdown
MemberAuthor

On that note, we should add "e2e" tests for autolinking too.

@grabbou

grabbou commented Oct 15, 2019

Copy link
Copy Markdown
MemberAuthor

@thymikee I don't think I have removed anything that would make #791 not work. In that case, we will re-add them once you rebase your PR.

thymikee
thymikee reviewed Oct 15, 2019
View reviewed changes
Comment threaddocs/configuration.md
thymikee
thymikee reviewed Oct 15, 2019
View reviewed changes
Comment threaddocs/dependencies.md Outdated
thymikee
thymikee reviewed Oct 15, 2019
View reviewed changes
Comment threaddocs/dependencies.md Outdated
Comment threaddocs/projects.md Outdated
Comment threaddocs/platforms.md Outdated
Comment threaddocs/projects.md
@grabbou@thymikee
Update docs/dependencies.md
41f8dde
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
@elicwhite

elicwhite commented Oct 17, 2019

Copy link
Copy Markdown
Contributor

Awesome!

When you say that these commands are removed now, do you mean that they will throw an exception when called?

It might be nice if the commands still existed but give a nice message and link to something. With all the older libraries with readmes that say to run link I can imagine people getting confused if those start erroring.

FWIW, I haven’t read the code. I’m on mobile and it’s too big to scroll and look for those related changes. So hopefully this isn’t a stupid question :-)

@grabbou

grabbou commented Oct 17, 2019

Copy link
Copy Markdown
MemberAuthor

@TheSavior, I like this idea! I will bring these commands back and print an appropriate message

@grabbou

grabbou commented Oct 17, 2019

Copy link
Copy Markdown
MemberAuthor

I will send a follow-up PR with better assets support. Removing them from documentation now because we don't support it and that the documentation will change.

This will be a non-breaking change.

thymikee
thymikee reviewed Oct 17, 2019
View reviewed changes
Comment threadpackages/cli/src/tools/config/index.ts
const haste = config.haste || {
const haste = {
providesModuleNodeModules: isPlatform ? [dependencyName] : [],
platforms: Object.keys(config.platforms),

@thymikeethymikeeOct 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to provide haste anymore since 0.61?

@grabbougrabbouOct 17, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing it down and will send a follow-up PR to remove it.

thymikee
thymikee reviewed Oct 17, 2019
View reviewed changes
Comment threadpackages/platform-ios/src/config/findPodspec.ts Outdated
thymikee
thymikee approved these changes Oct 17, 2019
View reviewed changes

@thymikeethymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @acoates-ms this will likely affect RN for Windows. If you haven't adopted autolinking yet, please prioritize it if possible. This change will land with RN 0.62 or later

thymikee
thymikee reviewed Oct 17, 2019
View reviewed changes
Comment threadpackages/platform-android/src/config/findManifest.ts Outdated
thymikee
thymikee reviewed Oct 17, 2019
View reviewed changes
Comment threadpackages/platform-android/src/config/index.ts Outdated
@thymikee
thymikee merged commit 69fd285 into nextOct 17, 2019
@thymikee
thymikee deleted the feat/remove-link branch October 17, 2019 17:23
@acoates-msacoates-ms mentioned this pull request Oct 17, 2019
Closed
@acoates-msacoates-ms mentioned this pull request Oct 28, 2019
Open
thymikee pushed a commit that referenced this pull request Nov 20, 2019
@grabbou@thymikee
chore: remove "rnpm" (#790)
f631c65
* Remove legacy link
* Clean up ios config
* Remove install/uninstall
* Update comments
* Update test on iOS
* Clean up iOS dependencies
* Type iOS config and set proper return types
* Update scheme
* Update schema
* Not all projects need native code
* No assumptions on CocoaPods, different package managers might be used
* Fix type errors
* Update snapshots to reflect missing config properties
* Void is not undefined
* Clean up Android configuration
* Update schema
* Serious rnpm/documentation removals and cleaned up tests
* Remove remaining props
* Update snapshots for some of the tests
* Fix last test - fixture was broken
* Update docs/dependencies.md
Co-Authored-By: Michał Pierzchała <thymikee@gmail.com>
* Fix type for scriptPhases
* Update to | undefined instead of elvis
* Add deprecated commands
* Add deprecation links
* Move undefined to null
* Add documentation back
* clean up
* chore
* Update snapshots
* And update unit test back to null
@grabbougrabbou mentioned this pull request Jan 17, 2022
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thymikeethymikeethymikee approved these changes
@EsemesekEsemesekAwaiting requested review from Esemesek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grabbou@elicwhite@thymikee