feat: use config inside run-android

[thymikee]

Summary:

Defer reading as much as possible from the shared config.
Details:

• removed root option in favor of deriving it from config.
• (possibly breaking) changed sourceDir to only look for android/ directory, which is a Gradle root project – this aligns sourceDir to iOS and allows for greater flexibility, because android/app was a hardcoded name for a default appFolder, which would likely break stuff when somebody started using appFolder flag
• remove --appFolder and --appId flags
• add android.project.appName to compensate for appFolder
• fix running app with appIdSuffix, when app uses flavors

Fixes#781.

Test Plan:

Updated tests.

[grabbou]

LGTM. Left some commends and ideas, open to discussions :) Good job!

[grabbou]

Shouldn't we throw here?

TIP: This codeebase hasn't been touched in a while, I am pretty sure it has some wild logger.error instead of CLIError in few places.

Good opportunity to update.

[grabbou]

It's not related to the PR, we can take it separately under "improving error messags and handling inside run-android". Whatever makes more sense!

[grabbou]

One more thing, don't we already have a packageName in the configuration?

I would also consider returning manifestPath from the configuration as well, as we already use it to derive packageName.

Otherwise, we risk using two different AndroidManifests which might be dangerous.

[grabbou]

I see we load AndroidManifest here based on args.appFolder, which by default is "app" (that's what configuration uses here https://github.com/react-native-community/cli/blob/next/packages/platform-android/src/config/findAndroidAppFolder.ts).

My proposal:

• make AndroidProjectParams accept appFolder with default value being app
• here, in this code, check if args.appFolder is provided and then, call projectConfig with {...androidProjectConfig, appFolder: args.appFolder} to get a "refreshed" configuration.

Would keep this unified I think. What you think?

[thymikee]

Yes we have, but the tricky thing is the appFolder. Gradle has a concept of root project (where root build.gradle is) and sub projects (e.g. app, core, ui). In a typical RN app, in settings.gradle we only include app project. But technically, in an Android-first project, there could be many gradle sub projects – and hence appFolder. Our configuration doesn't have this as an option. We could add it, but even when overwritten through a flag, the npx react-native config won't know about it. This is likely a super edge-case or even not happening, but we still support it.

That's why I can't really use the packageName or even appId from the configuration – because they only refer to a single project.

[grabbou]

Any update on this PR? The tests are failing, not reviewing at this point.

[thymikee]

Didn't have time to revisit yet

[thymikee]

Superseded by #1029