Uh oh!
There was an error while loading. Please reload this page.
chore: fix windows sdk test - #994
Merged
Merged
Conversation
thymikeeforce-pushed
the
chore/fix-windows-sdk-test
branch
from
February 20, 2020 08:28
e97ee57 to
a38a14fComparethymikee
commented
Feb 20, 2020
MemberAuthor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Windows CI sets
$CWDtoD:\, which is not where the project exists. To not alter the source code too much, I mocked thefindProjectRootso that it returns a local path. A proper fix would be reading the root (and, in turn, gradle.build path) from the config passed to the command. See #791 for referenceTest Plan:
Green windows CI