run npm 5.4.0 in CI by viankakrisna · Pull Request #3026 · react/create-react-app

viankakrisna · 2017-08-29T17:17:38Z

in response to #2792 (comment)

viankakrisna · 2017-08-29T17:36:07Z

Timer · 2017-08-29T17:42:37Z

I restarted it, might be a Travis flake.

I noticed npm cache clear needs to be ran with --force now, is that something we should do?

Timer · 2017-08-29T17:47:37Z

Nope, it's dead. 🤷‍♀️

I'd be interested in hearing what this AppVeyor failure is about, though.

viankakrisna · 2017-08-29T17:48:50Z

retrying with npm cache clean --force

viankakrisna · 2017-08-29T17:51:18Z

@Timer
ENOENT: no such file or directory, open 'C:\c\projects\create-react-app-a3khu\packages\babel-preset-react-app'
the path seems weird...

Timer · 2017-08-29T17:53:56Z

I glazed right over that; npm@5 must not like npm install file:/c/projects/create-react-app-a3khu/packages/babel-preset-react-app; is there a newer format?

viankakrisna · 2017-08-29T18:02:58Z

the previous code is using npm link, i'll revert that changes.

viankakrisna · 2017-08-29T18:11:52Z

npm/npm#15900
seems like the new format is link: i'll try that when this fails.

Also, facebook/flow#4733

gaearon · 2017-08-29T22:23:45Z

We can also just cp things if npm link is broken.

viankakrisna · 2017-08-30T05:46:42Z

Sorry i've fallen asleep... Seems like npm link works correctly, any caveat relying on it for e2e?

viankakrisna · 2017-08-30T17:44:16Z

soo (maybe) the remaining issue to get green npm 5++ in CI is for flow-bin to get a proper permission.

Timer · 2017-09-07T03:23:06Z

5.4.1 has resolved executable permissions.

viankakrisna · 2017-09-07T08:45:13Z

updated the code for accuracy :)

gaearon · 2017-09-07T09:48:05Z

Yaaaay!

This reverts commit fcb6dc5.

…react-app * 'master' of https://github.com/facebookincubator/create-react-app: Resolved issue react#2971 (react#2989) Revert "run npm 5.4.0 in CI (react#3026)" (react#3107) Updated react-error-overlay to latest Flow (0.54.0) (react#3065) Auto-detect running editor on Linux for error overlay (react#3077) Clean target directory before compiling overlay (react#3102) Rerun prettier and pin version (react#3058) Reload the page when an error has occurred (react#3098) run npm 5.4.0 in CI (react#3026) Unmapper Windows compatibility (react#3079) Update eslint-config npm install command (react#3072) Set travis config to use 'precise' ci environment Publish Changelog for 1.0.13 Add missing slash Make error overlay filename configurable (react#3028) provide empty mock for child_process so importing libraries with it works (react#3033) Rename Overlay to ErrorOvelay (react#3051) Strip hash from chunk file name (react#3049) Fix error overlay 'Object.assign' issue in IE by including polyfills before webpack client (react#3046)

* run npm 5.4.0 in CI * run npm cache clean with --force in CI * use link instead of install * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-simple.sh

This reverts commit fcb6dc5.

* run npm 5.4.0 in CI * run npm cache clean with --force in CI * use link instead of install * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-simple.sh

This reverts commit fcb6dc5.

* run npm 5.4.0 in CI * run npm cache clean with --force in CI * use link instead of install * Update e2e-installs.sh * Update e2e-kitchensink.sh * Update e2e-simple.sh

This reverts commit fcb6dc5.

…pescript * 'master' of https://github.com/wmonk/create-react-app-typescript: (265 commits) fix typo in changelog Update README For 2.13.0 v2.13.0 Remove tslint-loader from prod build (again) Include TypeScript as devDependency in boilerplate output Documented how to define custom module formats for the TypeScript compiler so that you can import images and other files (references wmonk#172) v2.12.0 Update README For 2.12.0 Update typescript to 2.6.2 v2.11.0 Update changelog for 2.11.0 Fixed problem with tsconfig.json baseUrl and paths Update createJestConfig.js Update changelog for 2.10.0 v2.10.0 Readd transformIgnorePatterns Update react-dev-utils Update package.json dependencies Readd Missing raf Package Update JestConfig Creation Fix Fix Missing Variable Fix package.json Merge pull request wmonk#204 from StefanSchoof/patch-1 Merge pull request wmonk#201 from StefanSchoof/patch-1 Merge pull request wmonk#199 from DorianGrey/master Merge pull request wmonk#165 from johnnyreilly/master Publish Add 1.0.17 changelog (#3402) Use new WebpackDevServer option (#3401) Fix grammar in README (#3394) Add link to VS Code troubleshooting guide (#3399) Update VS Code debug configuration (#3400) Update README.md (#3392) Publish Reorder publishing instructions Changelog for 1.0.16 (#3376) Update favicon description (#3374) Changelog for 1.0.15 (#3357) Replace template literal; fixes #3367 (#3368) CLI@1.4.2 Publish Add preflight CWD check for npm (#3355) Stop using `npm link` in tests (#3345) Fix for add .gitattributes file #3080 (#3122) Mention that start_url needs to be "." for client side routing start using npm-run-all to build scss and js (#2957) Updating the Service Worker opt-out documentation (#3108) Remove an useless negation in registerServiceWorker.js (#3150) Remove output.path from dev webpack config (#3158) Add `.mjs` support (#3239) Add documentation for Enzyme 3 integration (#3286) Make uglify work in Safari 10.0 - fixes #3280 (#3281) Fix favicon sizes value in manifest (#3287) Bump dependencies (#3342) recommend react-snap; react-snapshot isn't upgraded for React 16 (#3328) Update appveyor.cleanup-cache.txt Polyfill rAF in test environment (#3340) Use React 16 in development Use a simpler string replacement for the overlay Clarify the npm precompilation advice --no-edit Update `eslint-plugin-react` (#3146) Add jest coverage configuration docs (#3279) Update link to Jest Expect docs (#3303) Update README.md Fix dead link to Jest "expect" docs (#3289) v2.8.0 Use production React version for bundled overlay (#3267) Add warning when using `react-error-overlay` in production (#3264) Add external links to deployment services (#3265) `react-error-overlay` has no dependencies now (#3263) Add click-to-open support for build errors (#3100) Update style-loader and disable inclusion of its HMR code in builds (#3236) Update url-loader to 0.6.2 for mime ReDoS vuln (#3246) Make error overlay to run in the context of the iframe (#3142) Upgrade to typescript 2.5.3 Fix Windows compatibility (#3232) Fix package management link in README (#3227) Watch for changes in `src/**/node_modules` (#3230) More spec compliant HTML template (#2914) Minor change to highlight dev proxy behaviour (#3075) Correct manual proxy documentation (#3185) Improve grammar in README (#3211) Publish Fix license comments Changelog for 1.0.14 BSD+Patents -> MIT (#3189) Add link to active CSS modules discussion (#3163) Update webpack-dev-server to 2.8.2 (#3157) Part of class fields to stage 3 (#2908) Update unclear wording in webpack config docs (#3160) Display pid in already running message (#3131) Link local react-error-overlay package in kitchensink test Resolved issue #2971 (#2989) Revert "run npm 5.4.0 in CI (#3026)" (#3107) Updated react-error-overlay to latest Flow (0.54.0) (#3065) Auto-detect running editor on Linux for error overlay (#3077) Clean target directory before compiling overlay (#3102) Rerun prettier and pin version (#3058) ...

run npm 5.4.0 in CI
26197e7

facebook-github-bot added the CLA Signed label Aug 29, 2017

run npm cache clean with --force in CI
503223c

use link instead of install
9f55eec

viankakrisna force-pushed the npm540 branch 3 times, most recently from 70329a3 to 9f55eecCompare September 1, 2017 09:47

viankakrisna added 3 commits September 7, 2017 15:41

Update e2e-installs.sh
93649a8

Update e2e-kitchensink.sh
be460db

Update e2e-simple.sh
e56ac75

gaearon merged commit fcb6dc5 into react:masterSep 7, 2017

This was referenced Sep 10, 2017
Use Babel for react-dev-utils #2755
Closed
normalize the e2e behavior for npm link in npm 5 and below #3105
Closed

viankakrisna added a commit to viankakrisna/create-react-app that referenced this pull request Sep 11, 2017
Revert "run npm 5.4.0 in CI (react#3026)"
c8d3ac9
This reverts commit fcb6dc5.

tharakawj mentioned this pull request Sep 11, 2017
Add click-to-open support for build errors #3100
Merged

Timer pushed a commit that referenced this pull request Sep 12, 2017
Revert "run npm 5.4.0 in CI (#3026)" (#3107)
0e064b3
This reverts commit fcb6dc5.

thongdong7 pushed a commit to thongdong7/create-react-app that referenced this pull request Sep 24, 2017
Revert "run npm 5.4.0 in CI (react#3026)" (react#3107)
8035b51
This reverts commit fcb6dc5.

thongdong7 pushed a commit to thongdong7/create-react-app that referenced this pull request Sep 24, 2017
Revert "run npm 5.4.0 in CI (react#3026)" (react#3107)
8decd96
This reverts commit fcb6dc5.

kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017
Revert "run npm 5.4.0 in CI (react#3026)" (react#3107)
2141dac
This reverts commit fcb6dc5.

lockBot locked and limited conversation to collaborators Jan 20, 2019

Uh oh!

Uh oh!

Conversation

viankakrisna commented Aug 29, 2017

Uh oh!

viankakrisna commented Aug 29, 2017

Uh oh!

Timer commented Aug 29, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Timer commented Aug 29, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

viankakrisna commented Aug 29, 2017

Uh oh!

viankakrisna commented Aug 29, 2017

Uh oh!

Timer commented Aug 29, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

viankakrisna commented Aug 29, 2017

Uh oh!

viankakrisna commented Aug 29, 2017

Uh oh!

gaearon commented Aug 29, 2017

Uh oh!

viankakrisna commented Aug 30, 2017

Uh oh!

viankakrisna commented Aug 30, 2017

Uh oh!

Timer commented Sep 7, 2017

Uh oh!

viankakrisna commented Sep 7, 2017

Uh oh!

gaearon commented Sep 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Timer commented Aug 29, 2017•
edited
Loading

Timer commented Aug 29, 2017•
edited
Loading

Timer commented Aug 29, 2017•
edited
Loading