Use Babel for react-dev-utils by viankakrisna · Pull Request #2755 · react/create-react-app

viankakrisna · 2017-07-09T22:29:05Z

viankakrisna · 2017-07-10T00:43:26Z

I'm lost on how to make lerna works when there's a build dependency between packages -.-' will sleep on it...

viankakrisna · 2017-07-12T13:14:45Z

Ready for review 👍

gaearon · 2017-07-12T13:17:11Z

 my-app*
 packages/react-scripts/template
 packages/react-scripts/fixtures
+packages/react-dev-utils/FileSizeReporter.js


This seems unfortunate. Can we just ignore every file in the root folder?

gaearon · 2017-07-12T13:17:33Z

@@ -0,0 +1,19 @@
+/FileSizeReporter.js


Same here, I'd prefer we just ignore all JS files in the root folder.

viankakrisna · 2017-07-12T13:23:40Z

I forgot we can do wildcard for ignoring files 😄

gaearon

LGTM

viankakrisna · 2017-07-12T15:33:04Z

Somehow, Travis is hanging on node 8's kitchensink. Maybe need a restart?

viankakrisna · 2017-08-05T16:34:43Z

@gaearon rebased, anything more to get this merged?

miraage · 2017-08-07T07:55:48Z

No newline here. Is it intended?

have it here, I think GitHub truncate it?

miraage · 2017-08-07T07:56:35Z

No newline here. Is it intended? [2]

same as above

viankakrisna · 2017-09-10T18:13:47Z

seems like related to http://codetunnel.io/npm-5-changes-to-npm-link/

Timer · 2017-09-10T18:18:48Z

Do we need to switch away from npm@5 for CI?

viankakrisna · 2017-09-10T18:22:40Z

need to find out why exactly it's green on #3104 and #3026 but not here

viankakrisna · 2017-11-19T06:25:14Z

@Timer @gaearon can we get this in?

remove build artifacts move babel-cli babel-preset-react-app and cross-env to devDependencies remove unused deps

andriy-f · 2018-01-13T06:45:45Z

It would be nice to merge this, it holds several other important issues

gaearon · 2018-01-13T13:13:43Z

@andriy-f which issues?

gaearon · 2018-01-13T13:15:11Z

I’m not 100% convinced we need to increase complexity here because we can tell users Node 8 is required, figure out our node_modules compilation story, and then in both cases ES6 will work fine. So maybe we should focus on that instead.

viankakrisna · 2018-01-13T13:26:19Z

Yea, the idea is for this PR is that we want to extract service worker code to react-dev-utils, but I see what you mean.

facebook-github-bot added the CLA Signed label Jul 9, 2017

gaearon added the tag: internal label Jul 10, 2017

gaearon reviewed Jul 12, 2017
View reviewed changes

gaearon approved these changes Jul 12, 2017
View reviewed changes

gaearon added this to the 1.0.11 milestone Jul 12, 2017

viankakrisna mentioned this pull request Jul 12, 2017
add toast for warnings #2777
Closed

viankakrisna force-pushed the react-dev-utils/babel branch from bdbb216 to 2237356Compare August 5, 2017 15:21

miraage reviewed Aug 7, 2017
View reviewed changes

Timer modified the milestones: 1.0.x, 1.0.11 Aug 9, 2017

viankakrisna force-pushed the react-dev-utils/babel branch from 2237356 to 0aff591Compare August 23, 2017 13:48

viankakrisna force-pushed the react-dev-utils/babel branch 3 times, most recently from 972cddb to 7c3875eCompare September 10, 2017 09:03

viankakrisna mentioned this pull request Sep 10, 2017
normalize the e2e behavior for npm link in npm 5 and below #3105
Closed

viankakrisna force-pushed the react-dev-utils/babel branch 2 times, most recently from 2816dc1 to f36b6e6Compare September 14, 2017 17:42

viankakrisna force-pushed the react-dev-utils/babel branch from f36b6e6 to 987bb57Compare September 27, 2017 17:35

viankakrisna mentioned this pull request Oct 18, 2017
Toast for Service Worker #2426
Closed

viankakrisna force-pushed the react-dev-utils/babel branch from 987bb57 to ea843fcCompare November 10, 2017 16:07

viankakrisna force-pushed the react-dev-utils/babel branch 2 times, most recently from ca4de75 to 1462aa1Compare November 12, 2017 16:41

viankakrisna mentioned this pull request Jan 3, 2018
Preparing the next release #3672
Closed

viankakrisna force-pushed the react-dev-utils/babel branch from 1462aa1 to 7ae04c4Compare January 11, 2018 16:21

use babel for react-dev-utils
f18b828
remove build artifacts move babel-cli babel-preset-react-app and cross-env to devDependencies remove unused deps

viankakrisna force-pushed the react-dev-utils/babel branch from 7ae04c4 to f18b828Compare January 11, 2018 16:25

viankakrisna closed this Jan 13, 2018

lockBot locked and limited conversation to collaborators Jan 20, 2019

Uh oh!

Uh oh!

Conversation

viankakrisna commented Jul 9, 2017

Uh oh!

viankakrisna commented Jul 10, 2017

Uh oh!

viankakrisna commented Jul 12, 2017

Uh oh!

gaearonJul 12, 2017

Choose a reason for hiding this comment

Uh oh!

gaearonJul 12, 2017

Choose a reason for hiding this comment

Uh oh!

viankakrisna commented Jul 12, 2017

Uh oh!

gaearon left a comment

Choose a reason for hiding this comment

Uh oh!

viankakrisna commented Jul 12, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

viankakrisna commented Aug 5, 2017

Uh oh!

miraageAug 7, 2017

Choose a reason for hiding this comment

Uh oh!

viankakrisnaAug 23, 2017

Choose a reason for hiding this comment

Uh oh!

miraageAug 7, 2017

Choose a reason for hiding this comment

Uh oh!

viankakrisnaAug 23, 2017

Choose a reason for hiding this comment

Uh oh!

viankakrisna commented Sep 10, 2017

Uh oh!

Timer commented Sep 10, 2017

Uh oh!

viankakrisna commented Sep 10, 2017

Uh oh!

viankakrisna commented Nov 19, 2017

Uh oh!

andriy-f commented Jan 13, 2018

Uh oh!

gaearon commented Jan 13, 2018

Uh oh!

gaearon commented Jan 13, 2018

Uh oh!

viankakrisna commented Jan 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

viankakrisna commented Jul 12, 2017•
edited
Loading