Skip to content

add link to deployment docs after build - #3104

Merged
gaearon merged 3 commits into
react:masterfrom
viankakrisna:deployment-instructions
Jan 10, 2018
Merged

add link to deployment docs after build#3104
gaearon merged 3 commits into
react:masterfrom
viankakrisna:deployment-instructions

Conversation

@viankakrisna

Copy link
Copy Markdown
Contributor

screen shot 2017-09-11 at 1 05 18 am

@react-scripts-dangerous

Copy link
Copy Markdown

Hello! I'm a bot that helps facilitate testing pull requests.

Your pull request (commit 18855a4) has been released on npm for testing purposes.

npm i react-scripts-dangerous@1.0.15-18855a4.0
# or
yarn add react-scripts-dangerous@1.0.15-18855a4.0
# or
create-react-app --scripts-version=react-scripts-dangerous@1.0.15-18855a4.0 folder/

Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk!

Thanks for your contribution!

@gaearongaearon added this to the 1.0.18 milestone Jan 10, 2018
@gaearon
gaearon merged commit 7fd37d3 into react:masterJan 10, 2018
@gaearon

Copy link
Copy Markdown
Contributor

Looks good, thanks!

@viankakrisna

Copy link
Copy Markdown
ContributorAuthor

mm, actually i haven't tested this on my local after resolving on github 😅

screen shot 2018-01-11 at 00 12 51

I think the link for deployment should be on the bottom

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@viankakrisna@react-scripts-dangerous@gaearon@facebook-github-bot