Webpack 4 by andriijas · Pull Request #4077 · react/create-react-app

andriijas · 2018-02-26T08:55:03Z

simonkberg · 2018-02-26T15:12:11Z

For now you can reference the documentation of tapable. I believe you want to use tapAsync in this case.

Thanks @simonkberg! While thinking about it, since the plugin isnt doing any async should be valid to use .tap, return early where possible then just throw the error instead of passing it to the callback? What do you think?

andriijas · 2018-02-26T08:58:35Z

Moved below HtmlWebpackPlugin otherwise the tapable hooks are not available for tapping

This is down one line too far outside the closing bracket for plugins:[...]

@thephw thanks, fixed!

viankakrisna · 2018-02-26T08:59:48Z

i think we should just use the built-in uglifyjs now that we use webpack 4 https://github.com/webpack-contrib/uglifyjs-webpack-plugin#uglifyjs-webpack-plugin

I agree but the info on the link is obsolete. (Error: webpack.optimize.UglifyJsPlugin has been removed, please use config.optimization.minimize instead.)
I will move it to config.optimization when the webpack 4 doc is released.

i see, thanks for the info!

mnemanja · 2018-02-26T11:33:32Z

https://medium.com/webpack/webpack-4-released-today-6cdb994702d4 :)

simonkberg · 2018-02-26T15:12:11Z

For now you can reference the documentation of tapable. I believe you want to use tapAsync in this case.

pmdarrow · 2018-02-28T15:53:05Z

@andriijas it looks like you're upgrading a lot of dependencies in this PR unrelated to Webpack, what's the reason for that?

pmdarrow · 2018-02-28T21:01:19Z

I’m thinking you might want to in order to keep the noise low in the diff and make it easier to review. If you want to bump versions, I’d do that in a separate PR.

…

On Wed, Feb 28, 2018 at 4:17 PM Andreas Cederström ***@***.***> wrote: @pmdarrow <https://github.com/pmdarrow> actually no particular other than just bumping. i can revert everything except plugins and loaders if you want to? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4077 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAj0MOWJ6kod_aOWfPWvpmwjJQnj_uFcks5tZbRNgaJpZM4SS3n5> .

langpavel · 2018-02-28T23:36:38Z

Maybe we should have one config now that we are using webpack 4 mode option: #4030

Yes, definitely :-) Now, I have app which should support SSR (Server Side Rendering).
This should not be a big deal, but it is now and it will be for future bees 🐝 too.

In addition I propose to think forward.. You for example can create one webpack.config.client.js and prepare configuration to be easily extensible to multi-target after eject:

Example of my current webpack.config.js:

constgetEnvironment=require('./env');constrawEnv=getEnvironment().raw;constisDevelopment=rawEnv.NODE_ENV==='development';constisProduction=rawEnv.NODE_ENV==='production';if(!(isDevelopment||isProduction)){thrownewError('The NODE_ENV environment variable must be "development" or "production".');}// https://webpack.js.org/configuration/configuration-types/#exporting-multiple-configurationsmodule.exports=[(isProduction
? require('./webpack.config.client.prod')
: require('./webpack.config.client.dev')),(isProduction
? require('./webpack.config.server.prod')
: require('./webpack.config.server.dev')),];

Thanks for the hard work! ❤️

andriijas · 2018-03-01T09:47:28Z

update

now using new release of html-webpack-plugin
working with maintainers of precache and manifest plugins to get releases out

@pmdarrow actually i updated to try to pin point which dependency that spits out

(node:79963) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:79963) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead

but i havent managed to figure out which dependency still uses the old webpack plugin api.

@langpavel Looking at the configs in CRA i think there are equally many differences as similarities. Merging the files, there will be a lot of branching/if statements checking which env we are targeting.
I read somewhere that with webpack 5 released later this year extract text plugin will be deprecated,from what I can see by comparing dev and prod configs it will be easier to merge them then. But hey, if you really want it, you can pop a PR when webpack 4 gets in :)

miraage · 2018-03-01T14:37:51Z

optimize.splitChuks should be configurable via .env files if you ask me.

AubreyHewes · 2018-03-02T00:20:55Z

nice job @andriijas 🥇

FYI from my mirror of your analysis (things I figured out before I found your PR);

DeprecationWarning: Tapable.plugin is deprecated. Use new API on .hooks instead
DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly

both warnings seem to stem from html-webpack-plugin

The warnings are emitted via package tapable; the webpack compiler is an extension of Tapable
https://github.com/webpack/webpack/blob/v4.0.1/lib/webpack.js#L37

Reproducible with at least one plugin html-webpack-plugin (3.0.3 sic 3.0.2)

`node --trace-deprecation scripts/build.js `

Creating an optimized production build...
(node:4413) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
at HtmlWebpackPlugin.apply (/app/node_modules/html-webpack-plugin/index.js:65:14)
at webpack (/app/node_modules/webpack/lib/webpack.js:37:12)
at build (/app/client/scripts/build.js:46:20)
at measureFileSizesBeforeBuild.then (/app/client/scripts/build.js:101:12)
at <anonymous>
(node:4413) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
at Object.compileTemplate (/app/node_modules/html-webpack-plugin/lib/compiler.js:47:17)
at compiler.plugin (/app/node_modules/html-webpack-plugin/index.js:67:42)
at AsyncParallelHook.eval [as callAsync] (eval at create (/app/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:13:1)
at AsyncParallelHook.lazyCompileHook [as _callAsync] (/app/node_modules/tapable/lib/Hook.js:35:21)
at hooks.beforeCompile.callAsync.err (/app/node_modules/webpack/lib/Compiler.js:459:20)
at AsyncSeriesHook.eval [as callAsync] (eval at create (/app/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:6:1)
at AsyncSeriesHook.lazyCompileHook [as _callAsync] (/app/node_modules/tapable/lib/Hook.js:35:21)
at Compiler.compile (/app/node_modules/webpack/lib/Compiler.js:452:28)
at readRecords.err (/app/node_modules/webpack/lib/Compiler.js:200:11)
at Compiler.readRecords (/app/node_modules/webpack/lib/Compiler.js:322:11)
at hooks.run.callAsync.err (/app/node_modules/webpack/lib/Compiler.js:197:10)
at AsyncSeriesHook.eval [as callAsync] (eval at create (/app/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:6:1)
at AsyncSeriesHook.lazyCompileHook [as _callAsync] (/app/node_modules/tapable/lib/Hook.js:35:21)
at hooks.beforeRun.callAsync.err (/app/node_modules/webpack/lib/Compiler.js:194:19)
at AsyncSeriesHook.eval [as callAsync] (eval at create (/app/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:15:1)
at AsyncSeriesHook.lazyCompileHook [as _callAsync] (/app/node_modules/tapable/lib/Hook.js:35:21)
Compiled successfully.

my 2 pennies

andriijas · 2018-03-02T09:12:34Z

@AubreyHewes you are right, while html-webpack-plugin added support for the new webpack plugin api they didnt remove/upgrade all deprecated calls to compiler.plugin.

thephw · 2018-03-04T10:13:03Z

FWIW, the associated issue on html-webpack-plugin is already open, digging through the same issues myself at the moment.

jantimon/html-webpack-plugin#874

andriijas · 2018-03-06T13:58:11Z

Update 6/3/18

PR approaching ready status
All blockers except external dependencies resolved (precache plugin author promised release later this week or next week, PR pending with manifest, extract text plugin in beta status)
Tested on medium size SPA locally, works great, about same compile time as with webpack 3 though :( but total bundle size shrunk from 1.6 to 1.4mb :)

TheLarkInn · 2018-05-12T21:40:28Z

@andriijas let me see if I can help out :) I've cloned your branch and will see what I find.

TheLarkInn · 2018-05-13T11:07:20Z

@andriijas I may have done merge commit wrong PR'ing into your branch, but let's see how this turns out. andriijas#2

TheLarkInn · 2018-05-13T11:07:45Z

This is just resolving conflicts and running CI again. Is there any way to run kitchen sink tests locally?

andriijas · 2018-05-13T11:16:44Z

Thx @TheLarkInn - I'm spending the day in the car. It should be possible. Eventually need to install node 8 to reproduce the specific error locally. Not sure. The merge commit might be because I've yet to rebase the latest changes from next. We can resolve that later.

iansu · 2018-05-13T16:12:44Z

@TheLarkInn Unfortunately the e2e tests don't work reliably when run locally. They install some global packages and mess with your yarn and npm settings so you probably don't want to run them on your machine. There's a Docker version that someone contributed but that's also broken right now. 😞

TheLarkInn · 2018-05-13T16:50:33Z

So I ran Node 8 and didn't see this problem crop up from running both dev and production builds. If anyone has a few repro steps it will make patching manifest-webpack-plugin (if needed) way easier.

petetnt · 2018-05-13T17:03:13Z

If I'd have to guess something is screwy with process.env.PUBLIC_URL in the CI

bugzpodder · 2018-05-13T19:14:54Z

@TheLarkInn I was able to get a repro.

[--- EDIT: this PR was merged to the create-react-app's next branch ---]
You'll need to apply the following patch:
#4454
[--- EDIT: this PR was merged to the create-react-app's next branch ---]

and run "yarn e2e:docker --interactive --test-suite kitchensink"

$ react-scripts build Creating an optimized production build...
WARNING: The `text-hide()` mixin has been deprecated as of v4.1.0. It will be removed entirely in v5.
on line 10 of node_modules/bootstrap/scss/mixins/_text-hide.scss, in mixin `text-hide`
from line 57 of node_modules/bootstrap/scss/utilities/_text.scss
from line 14 of node_modules/bootstrap/scss/_utilities.scss
from line 41 of node_modules/bootstrap/scss/bootstrap.scss
from line 1 of stdin
path.js:7
throw new TypeError('Path must be a string. Received ' + inspect(path));
^
TypeError: Path must be a string. Received undefined
at assertPath (path.js:7:11)
at Object.basename (path.js:1361:5)
at moduleAsset (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack-manifest-plugin/lib/plugin.js:45:12)
at SyncHook.eval (eval at create (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/tapable/lib/HookCodeFactory.js:51:12), <anonymous>:7:1)
at Compilation.createModuleAssets (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compilation.js:1768:29)
at hooks.optimizeTree.callAsync.err (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compilation.js:939:9)
at AsyncSeriesHook.eval [as callAsync] (eval at create (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:6:1)
at AsyncSeriesHook.lazyCompileHook [as _callAsync] (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/tapable/lib/Hook.js:35:21)
at Compilation.seal (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compilation.js:890:27)
at hooks.make.callAsync.err (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compiler.js:481:17)
at _done (eval at create (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:9:1)
at _err1 (eval at create (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:32:22)
at _addModuleChain (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compilation.js:758:12)
at processModuleDependencies.err (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compilation.js:697:9)
at _combinedTickCallback (internal/process/next_tick.js:73:7)
at process._tickCallback (internal/process/next_tick.js:104:9)
error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ++ set +x
e2e-kitchensink.sh: ERROR! An error was encountered executing line 128.
Cleaning up.
yarn config v1.6.0 success Set "registry" to "https://registry.yarnpkg.com". Done in 0.09s. Exiting with error.

TheLarkInn · 2018-05-14T00:27:06Z

Jack, thanks a lot! This should give me something to work with. I'll report back once I take a crack at it tonight.

…

On Sun, May 13, 2018, 12:16 PM Jack Zhao ***@***.***> wrote: @TheLarkInn <https://github.com/TheLarkInn> I was able to get a repro. You'll need to apply the following patch: ***@***.*** <bugzpodder/create-react-app@9a5bd5d> and run "yarn e2e:docker --interactive --test-suite kitchensink" $ react-scripts build Creating an optimized production build... WARNING: The `text-hide()` mixin has been deprecated as of v4.1.0. It will be removed entirely in v5. on line 10 of node_modules/bootstrap/scss/mixins/_text-hide.scss, in mixin `text-hide` from line 57 of node_modules/bootstrap/scss/utilities/_text.scss from line 14 of node_modules/bootstrap/scss/_utilities.scss from line 41 of node_modules/bootstrap/scss/bootstrap.scss from line 1 of stdin path.js:7 throw new TypeError('Path must be a string. Received ' + inspect(path)); ^ TypeError: Path must be a string. Received undefined at assertPath (path.js:7:11) at Object.basename (path.js:1361:5) at moduleAsset (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack-manifest-plugin/lib/plugin.js:45:12) at SyncHook.eval (eval at create (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/tapable/lib/HookCodeFactory.js:51:12), <anonymous>:7:1) at Compilation.createModuleAssets (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compilation.js:1768:29) at hooks.optimizeTree.callAsync.err (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compilation.js:939:9) at AsyncSeriesHook.eval [as callAsync] (eval at create (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:6:1) at AsyncSeriesHook.lazyCompileHook [as _callAsync] (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/tapable/lib/Hook.js:35:21) at Compilation.seal (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compilation.js:890:27) at hooks.make.callAsync.err (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compiler.js:481:17) at _done (eval at create (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:9:1) at _err1 (eval at create (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:32:22) at _addModuleChain (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compilation.js:758:12) at processModuleDependencies.err (/tmp/tmp.tgGgDwkWWZ/test-kitchensink/node_modules/webpack/lib/Compilation.js:697:9) at _combinedTickCallback (internal/process/next_tick.js:73:7) at process._tickCallback (internal/process/next_tick.js:104:9) error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ++ set +x e2e-kitchensink.sh: ERROR! An error was encountered executing line 128. Cleaning up. yarn config v1.6.0 success Set "registry" to "https://registry.yarnpkg.com". Done in 0.09s. Exiting with error. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4077 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADQBMFKf1o41yFnjsr6wurxBCVVOwUxoks5tyIaCgaJpZM4SS3n5> .

DanProudfoot · 2018-05-15T12:48:43Z

Just a little thing I've seen in playing with this - and I don't know if this is a webpack 4 thing, a more general CRA 2.0 thing, or something I've done - but I've found that importing libraries that bundle both frontend and node code seems to pick the node version in some cases.

I've found this problem with both firebase and socket.io, but I think there may be others.

gaearon · 2018-05-15T12:58:42Z

@DanProudfoot File a new issue pls?

- [x] Utilize webpack 4 development and production modes - [x] Upgrade webpack dev server - [x] Webpack 4 compatible release of thread-loader - [x] Webpack 4 compatible release of HtmlWebpackPlugin - [x] Webpack 4 compatible release of SwPrecacheWebpackPlugin - [x] Webpack 4 compatible release of WebpackManifestPlugin - [x] Update README - [x] Update WebpackDevServerUtils - [x] Update InterpolateHtmlPlugin - [x] Update ModuleScopePlugin - [x] Update WatchMissingNodeModulesPlugin - [x] Move UglifyJS options to webpack 4 optimize - [x] Move InterpolateHtmlPlugin to make it tapable on HtmlWebpackPlugin - [x] vendor splitting via splitChunks.splitChunks (https://twitter.com/wSokra/status/969633336732905474) - [x] long term caching via splitChunks.runtimeChunk (https://twitter.com/wSokra/status/969679223278505985) - [x] Make sure process.env.NODE_ENV is proxied correctly to `react-error-overlay` - [x] Implicit webpack.NamedModulesPlugin in dev config as its default in webpack 4 - [x] Disable webpack performance hints as we have our own filesize reporter - [x] Replace ExtractTextPlugin with MiniCssExtractPlugin - [x] Switch to css whole file minification via OptimizeCSSAssetsPlugin rather than per module css minification to gain performance

andriijas · 2018-05-15T13:23:29Z

@bugzpodder i dont have docker available right now - can you debug why the manifest gets path undefined? thanks 🥂

DanProudfoot · 2018-05-15T15:39:25Z

~~@gaearon I've forked and mucked around with things so much, I'm not totally confident it's not my fault. I guess I should have caveated that more.~~

~~I guess I should probably ask, has anyone using this in a more "stock" config experienced something similar?~~

Sorry all, it was my own stupid fault - I was using directory-named-webpack-plugin, and that breaks things if I don't set honorPackage: false

Sorry all!

bugzpodder · 2018-05-15T18:39:22Z

Did a bit of debugging.
You'll want to remove this line: rm -rf "$temp_app_path" "$temp_module_path" || $CI
from the e2e-kitchensink script before trying to run yarn e2e:docker --interactive --test-suite kitchensink so you get your temp dir preserved.
You may also want to remove absoluteLoad import before trying yarn build as it seem to be an unrelated issue (src/features/env/NodePath.js) otherwise set the NODE_PATH correctly before building.

For the actual manifest plugin issue from webpack build,

concatenateModules option is on by default in production
import in SvgComponent produces ConcatenatedModule (rather than a NormalModule).
ConcatenatedModule doesn't have userRequest field for webpack-manifest-plugin, which crashes. I have no idea how to fix it but hopefully this helps someone @andriijas @TheLarkInn @iansu
Not sure what caused the regression (the tests were passing three months ago).

Creating an optimized production build...
/tmp/tmp.VwSgCdpDNy/test-kitchensink/build /tmp/tmp.VwSgCdpDNy/test-kitchensink/build/asset-manifest.json asset-manifest.json
static/media/logo.5d5d9eef.svg /tmp/tmp.VwSgCdpDNy/test-kitchensink/src/features/webpack/assets/logo.svg
WARNING: The `text-hide()` mixin has been deprecated as of v4.1.0. It will be removed entirely in v5.
on line 10 of node_modules/bootstrap/scss/mixins/_text-hide.scss, in mixin `text-hide`
from line 57 of node_modules/bootstrap/scss/utilities/_text.scss
from line 14 of node_modules/bootstrap/scss/_utilities.scss
from line 41 of node_modules/bootstrap/scss/bootstrap.scss
from line 1 of stdin
static/media/aFileWithExt.9753d3ac.unknown /tmp/tmp.VwSgCdpDNy/test-kitchensink/src/features/webpack/assets/aFileWithExt.unknown
static/media/logo.5d5d9eef.svg /tmp/tmp.VwSgCdpDNy/test-kitchensink/src/features/webpack/assets/logo.svg (this is NomalModule, its userRequest field is the second token being outputted) static/media/aFileWithoutExt.cb7eb057.bin /tmp/tmp.VwSgCdpDNy/test-kitchensink/src/features/webpack/assets/aFileWithoutExt
static/media/logo.5d5d9eef.svg undefined (this is ConcatenatedModule, its userRequest field is undefined) -- this is from src/features/webpack/SvgComponent.js
path.js:7
throw new TypeError('Path must be a string. Received ' + inspect(path));
^
TypeError: Path must be a string. Received undefined

gaearon · 2018-05-20T17:22:38Z

more fixes coming in Webpack4 #4490

gaearon · 2018-05-20T17:45:54Z

I filed #4492 for follow-up discussion.
Please post your thoughts!

marcofugaro · 2018-05-21T08:59:30Z

Great job! 🎉
Could you publish the updated react-dev-utils on the 6.0.0-next tag?

wregis · 2018-05-21T11:32:01Z

Well done, guys!
Any idea when it will be available on npm?

Ayc0 · 2018-05-21T16:30:03Z

GG @andriijas

gaearon · 2018-05-21T17:09:20Z

As usual for 2.x alphas, we'll post about new releases in #3815.
Subscribe to that issue.

I'm locking this one to reduce the notification noise. Thanks again to everyone!

facebook-github-bot added the CLA Signed label Feb 26, 2018

andriijas commented Feb 26, 2018
View reviewed changes

viankakrisna reviewed Feb 26, 2018
View reviewed changes

simonkberg reviewed Feb 26, 2018
View reviewed changes

Timer mentioned this pull request Feb 26, 2018
enable manifest plugin on dev #4014
Merged

andriijas mentioned this pull request Feb 26, 2018
add support for webpack4 shellscape/webpack-manifest-plugin#118
Merged

andriijas force-pushed the webpack4 branch 3 times, most recently from 670ecd9 to 3d93efdCompare February 28, 2018 13:05

Jinksi mentioned this pull request Mar 1, 2018
Use webpack v4 #4093
Closed

andriijas force-pushed the webpack4 branch from 3d93efd to 1652821Compare March 1, 2018 09:37

Hypnosphi mentioned this pull request Mar 3, 2018
Webpack 4 support? storybookjs/storybook#3044
Closed

Hypnosphi mentioned this pull request Mar 4, 2018
[BREAKING CHANGE] webpack 4 storybookjs/storybook#3148
Merged
4 tasks

Timer mentioned this pull request Mar 5, 2018
Deprecation warning Chrome 64 chrome.loadTimes() #4072
Closed

Timer added tag: bug fix tag: enhancement labels Mar 5, 2018

Timer added this to the 2.0.0 milestone Mar 5, 2018

andriijas force-pushed the webpack4 branch 2 times, most recently from c3436d1 to cd0f7f7Compare March 6, 2018 13:51

andriijas force-pushed the webpack4 branch from cd0f7f7 to 20e31b0Compare March 6, 2018 19:33

andriijas force-pushed the webpack4 branch from 29486d5 to 4f751adCompare May 14, 2018 06:53

andriijas force-pushed the webpack4 branch from 4f751ad to e6fd0d1Compare May 15, 2018 13:21

bugzpodder mentioned this pull request May 16, 2018
Fixes webpack-manifest-plugin issue andriijas/create-react-app#3
Closed

pelotom mentioned this pull request May 17, 2018
Webpack 4 cont'd #4481
Closed

bugzpodder mentioned this pull request May 20, 2018
Webpack4 #4490
Merged

gaearon merged commit d72678f into react:nextMay 20, 2018

bugzpodder mentioned this pull request May 20, 2018
Scope hoisting webpack 4 shellscape/webpack-manifest-plugin#151
Closed

andriijas deleted the webpack4 branch May 21, 2018 08:45

react locked as resolved and limited conversation to collaborators May 21, 2018

Uh oh!

Uh oh!

Conversation

andriijas commented Feb 26, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mnemanja commented Feb 26, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pmdarrow commented Feb 28, 2018

Uh oh!

pmdarrow commented Feb 28, 2018 via email

Uh oh!

langpavel commented Feb 28, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andriijas commented Mar 1, 2018

update

Uh oh!

miraage commented Mar 1, 2018

Uh oh!

AubreyHewes commented Mar 2, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andriijas commented Mar 2, 2018

Uh oh!

thephw commented Mar 4, 2018

Uh oh!

andriijas commented Mar 6, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update 6/3/18

Uh oh!

TheLarkInn commented May 12, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheLarkInn commented May 13, 2018

Uh oh!

TheLarkInn commented May 13, 2018

Uh oh!

andriijas commented May 13, 2018

Uh oh!

iansu commented May 13, 2018

Uh oh!

TheLarkInn commented May 13, 2018

Uh oh!

petetnt commented May 13, 2018

Uh oh!

bugzpodder commented May 13, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheLarkInn commented May 14, 2018 via email

Uh oh!

DanProudfoot commented May 15, 2018

Uh oh!

gaearon commented May 15, 2018

Uh oh!

andriijas commented May 15, 2018

Uh oh!

DanProudfoot commented May 15, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bugzpodder commented May 15, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

andriijas commented Feb 26, 2018•
edited
Loading

langpavel commented Feb 28, 2018•
edited
Loading

AubreyHewes commented Mar 2, 2018•
edited
Loading

andriijas commented Mar 6, 2018•
edited
Loading

TheLarkInn commented May 12, 2018•
edited
Loading

bugzpodder commented May 13, 2018•
edited
Loading

DanProudfoot commented May 15, 2018•
edited
Loading

bugzpodder commented May 15, 2018•
edited
Loading