Uh oh!
There was an error while loading. Please reload this page.
Fix e2e:docker script - #4454
Conversation
facebook-github-bot
commented
May 13, 2018
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
| @@ -0,0 +1,49 @@ | |||
| # | |||
| # This is the default config file. It allows all users to do anything, | |||
gaearon
commented
May 14, 2018
Thanks! |
iansu
commented
May 14, 2018
Did CI pass with these changes? |
@iansu both appveyor and travis are green |
gaearon
commented
May 14, 2018
Does CI even use this script? I thought it didn't. |
gaearon
commented
May 14, 2018
(Travis definitely passed, AppVeyor was failing during yarn fetch which was a common transient issue before so I ignored it) |
bugzpodder
commented
May 14, 2018
I ended up reverting the change in e2e-installs because running it locally was also failing at the same line. But alas I ran it now (after adding back the change) and it just passed. The CIs were indeed using the e2e-*.sh scripts |
gaearon
commented
May 14, 2018
Sorry, I got confused by description because I thought it's only relevant to |
iansu
commented
May 14, 2018
Thanks for the info guys. Our tests have been a bit flakey lately so I just wanted to make sure we were in a good state after these changes. |
yarn e2e:docker works locally with this change. Tested before after, before test fails at yarn publish. After yarn publish works as expected.
Checking CI builds.