Uh oh!
There was an error while loading. Please reload this page.
Make @typescript-eslint optional peerDependencies - #8376
Conversation
trollepierre
commented
Apr 7, 2020
@ThewBear : can you fix the failing job 🙏 ? |
ThewBear
commented
Apr 17, 2020
The test fails when using yarn PnP. |
| overrides: [ | ||
| { | ||
| // Lint tsx only if typescript is installed. |
There was a problem hiding this comment.
Probably it's not worth it since if you have ts files, you already have to install typescript:
dominicfraser
commented
Mar 2, 2021
This looks to be an alternative fix: #9310
|
smakosh
commented
Apr 6, 2021
Create an |
ThewBear
commented
Apr 7, 2021
Closing this now as it is too old. |
Problem
Currently
eslint-config-react-apprequires@typescript-eslintto be installed in every project even the project that doesn't use typescript. This lead to the warning of missingtypescript(#6834, #6859).
Solution
By making
@typescript-eslintan optional peerDependencies, non-typescript user doesn't need to installed@typescript-eslintand can get rid of the warning. User who use typescript can installedtypescriptalong with@typescript-eslint/eslint-pluginand@typescript-eslint/parser.