Fix @typescript-eslint typescript peer dependency warning

[ianschmitz]

Fixes#6834.

Bump @typescript-eslint packages to a newer version that have removed the typescript peer dependency.

[ianschmitz]

Doh. Not quite this simple. Still a couple warnings left it looks like when checking out the CI logs:

warning "react-scripts > @typescript-eslint/eslint-plugin > tsutils@3.10.0" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev".
warning "react-scripts > pnp-webpack-plugin > ts-pnp@1.1.1" has unmet peer dependency "typescript@*".

[iansu]

I don't think we want to ship an alpha version just to remove some warnings. Can we wait until this is stable and upgrade it after the 3.0 release?

[ianschmitz]

We can yes. This is a commit after their 1.7.0 release as they release automatically on commit to master.

[arcanis]

warning "react-scripts > pnp-webpack-plugin > ts-pnp@1.1.1" has unmet peer dependency "typescript@*".

I've published pnp-webpack-plugin@1.4.3 which should fix the problem (typescript is now an optional peer dependency of ts-pnp; we only were using it for the TS types).

[ianschmitz]

Alright looks like this might be the last one:

warning "react-scripts > @typescript-eslint/eslint-plugin > tsutils@3.10.0" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev".

[zarsky-broad]

@ianschmitz can this be moved ahead now that 1.8.0 (and indeed, up through 1.13.0) have been released? Just doing an audit of my project's install warning and came across this.

[ianschmitz]

@ianschmitz can this be moved ahead now that 1.8.0 (and indeed, up through 1.13.0) have been released? Just doing an audit of my project's install warning and came across this.

Still getting warnings :(

warning "react-scripts > @typescript-eslint/eslint-plugin > tsutils@3.14.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev".

[mrmckeb]

It's probably worth merging this for 3.1 anyway, what do you think @ianschmitz@iansu?

[arcanis]

Fwiw I don't think using an unsafe pattern known to break under some circumstances (omitting peer dependencies from the manifest) just to remove warnings is a good tradeoff, especially when those warning can already disappear for half the users by using the right feature (npm is also going to implement optional peer dependencies, btw) ...

I should probably bring this to the typescript-eslint project, but since I think they made the change based on CRA I wanted to raise it here as well 🙁

[iansu]

@arcanis thanks for the additional info. I think we should hold off on this since it doesn't actually solve the problem. If this is something that's going to be addressed directly by package managers then maybe we should just wait for that to happen.

[eddiemonge]

@ianschmitz this is outdated so can probably be closed

[laoshaw]

today is 2020.10.01 and I still got below from a fresh create-react-app project:

npm ERR! peer dep missing: typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta, required by tsutils@3.17.1
npm ERR! peer dep missing: typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta, required by tsutils@3.17.1

[ianschmitz]

@ianschmitz this is outdated so can probably be closed

Agreed. Webpack 5 also includes native pnp support AFAIK, so that will change things.