Uh oh!
There was an error while loading. Please reload this page.
Adopt OpenJDK11 - #2800
Conversation
✔️ Deploy Preview for react-native ready! 🔨 Explore the source changes: 29b5a04 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/61e803743420970007dfcff0 😎 Browse the preview: https://deploy-preview-2800--react-native.netlify.app |
cortinico
commented
Jan 12, 2022
@svbutko Can I ask you to rebase as this I believe is ready to land 👍 |
Simek
commented
Jan 12, 2022
The change has landed only on |
cortinico
commented
Jan 12, 2022
This change is backward compatible though. You can use JDK 11 to build previous version of RN without problems. With the upcoming version instead, it will become a requirement. |
kelset
commented
Jan 19, 2022
@Simek I think you meant to say 0.68? |
Simek
commented
Jan 19, 2022
Not exactly, I should write that we need to wait for the 0.67 docs cut merge, not only the cut. :) If we merge this now, for a while, the change will appear in |
kelset
commented
Jan 19, 2022
gotcha: so version 0.67 of react-native is not affected by this, so this PR can only be merged after this PR is merged: #2926 correct? |
cortinico
commented
Jan 19, 2022
Just to clarify: this specific change is making JDK 11 the "suggested" JDK versions. |
Simek
commented
Jan 19, 2022
@cortinico Thanks for the clarification! So we can merge it now, right? |
cortinico
commented
Jan 19, 2022
Essentially yes 👍 |
Simek
commented
Jan 19, 2022
To see this change in the |
kelset
commented
Jan 19, 2022
ok, let me rebase my branch on top of main for good measure and re-gen the docs |
kelset
commented
Jan 19, 2022
(done: #2926 (comment) ) |
Based on Gradle version upgrade it will be needed to install JDK 11:
react/react-native#32186