Skip to content

CI: bump react-native-android docker image to 5.0, includes JDK 11 - #32186

Closed
dulmandakh wants to merge 2 commits into
react:mainfrom
dulmandakh:jdk-11
Closed

CI: bump react-native-android docker image to 5.0, includes JDK 11#32186
dulmandakh wants to merge 2 commits into
react:mainfrom
dulmandakh:jdk-11

Conversation

@dulmandakh

@dulmandakhdulmandakh commented Sep 11, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Bump react-native-android docker image to 5.0, which includes JDK 11.

Changelog

[Internal] [Changed] - bump react-native-android docker image to 5.0, which includes JDK 11.

Test Plan

Android CI must be green

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Sep 11, 2021
@pull-bot

pull-bot commented Sep 11, 2021•
edited
Loading

Copy link
Copy Markdown
Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against c8cf4d1

@facebook-github-botfacebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Sep 11, 2021
@analysis-bot

analysis-bot commented Sep 11, 2021•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: 5518b6d
Branch: main

@facebook-github-bot

facebook-github-bot commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cortinico

cortinico commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

Seems like the CI is failing as we specify UseCGroupMemoryLimitForHeap and we should instead specify UseContainerSupport:

https://github.com/facebook/react-native/blob/1465c8f3874cdee8c325ab4a4916fda0b3e43bdb/.circleci/config.yml#L44

More on this here: https://support.circleci.com/hc/en-us/articles/360048152911

Don't you mind giving it a try?

@facebook-github-bot

facebook-github-bot commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@analysis-bot

analysis-bot commented Sep 15, 2021•
edited
Loading

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a8,477,943-26
androidhermesarmeabi-v7a7,775,189-25
androidhermesx868,947,093-26
androidhermesx86_648,894,003-28
androidjscarm64-v8a9,791,890+12
androidjscarmeabi-v7a8,752,625+23
androidjscx869,740,716+17
androidjscx86_6410,341,569+14

Base commit: a44962f
Branch: main

@dulmandakh

dulmandakh commented Sep 15, 2021

Copy link
Copy Markdown
ContributorAuthor

@cortinico this PR is not ready yet

@cortinico
cortinico marked this pull request as draft September 15, 2021 13:04
@cortinico

cortinico commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

@cortinico this PR is not ready yet

Thanks for pointing out. I've converted it to a draft PR. Feel free to ping me once you're ready to land this 👍

@cortinicocortinico mentioned this pull request Oct 4, 2021
Closed
@svbutkosvbutko mentioned this pull request Oct 4, 2021
Merged
@svbutko

svbutko commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

When it's going to be ready can it be possible to also bump AGP then to 7.0.2 with this PR?

@svbutkosvbutko mentioned this pull request Oct 7, 2021
Closed
10 tasks
@cortinicocortinico mentioned this pull request Oct 19, 2021
Merged
@dulmandakh
dulmandakh marked this pull request as ready for review November 12, 2021 16:18
@dulmandakhdulmandakh changed the title use JDK 11 in GradleCI: bump react-native-android docker image to 5.0Nov 12, 2021
@dulmandakh

dulmandakh commented Nov 12, 2021

Copy link
Copy Markdown
ContributorAuthor

@cortinico could you please look into CI failure with JDK 11. It's strange.

@dulmandakh

dulmandakh commented Nov 12, 2021

Copy link
Copy Markdown
ContributorAuthor

solved the CI issue 👍

@dulmandakhdulmandakh changed the title CI: bump react-native-android docker image to 5.0CI: bump react-native-android docker image to 5.0, includes JDK 11Nov 12, 2021
@facebook-github-bot

facebook-github-bot commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Nov 12, 2021
@facebook-github-bot

facebook-github-bot commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in 9e72235.

@dulmandakh
dulmandakh deleted the jdk-11 branch November 13, 2021 00:08
@mikehardymikehardy mentioned this pull request Nov 16, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hramoshramosAwaiting requested review from hramos

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.MergedThis PR has been merged.Shared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dulmandakh@pull-bot@analysis-bot@facebook-github-bot@cortinico@svbutko