Skip to content

[WebSocket] binaryType='arraybuffer' support - #1829

Closed
orktes wants to merge 1 commit into
react:masterfrom
Applifier:feature/ws_binaryType
Closed

[WebSocket] binaryType='arraybuffer' support#1829
orktes wants to merge 1 commit into
react:masterfrom
Applifier:feature/ws_binaryType

Conversation

@orktes

@orktesorktes commented Jul 1, 2015

Copy link
Copy Markdown

Support for binary websocket messages. Currently binary messages crash the application. More info in #1730

@facebook-github-bot

facebook-github-bot commented Jul 1, 2015

Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot

facebook-github-bot commented Jul 1, 2015

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-botfacebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2015
@apitaruapitaru mentioned this pull request Aug 19, 2015
Closed
@mikemintzmikemintz mentioned this pull request Sep 23, 2015
Open
@lindskogen

lindskogen commented Nov 11, 2015

Copy link
Copy Markdown
Contributor

@orktes, or someone? Would you take a look at this and see what's failing?

@facebook-github-bot

facebook-github-bot commented Nov 11, 2015

Copy link
Copy Markdown
Contributor

@orktes updated the pull request.

@lindskogen

lindskogen commented Nov 12, 2015

Copy link
Copy Markdown
Contributor

@orktes Looks like it's just the .flowconfig-file that needs to be brought up to latest version, mind taking a look at it?

@lindskogenlindskogen mentioned this pull request Dec 2, 2015
Closed
@satya164

satya164 commented Dec 22, 2015

Copy link
Copy Markdown
Contributor

Closing in favour of #4483

ghost pushed a commit that referenced this pull request Dec 23, 2015
@lindskogenfacebook-github-bot-3
Add support for binary type data (ArrayBuffer)
afbff9b
Summary:
Entirely based on #1829
I just updated the diff to be compatible with the current master branch.
Closes#4483
Reviewed By: svcscm
Differential Revision: D2783425
Pulled By: nicklockwood
fb-gh-sync-id: 1cc67c0741cff3b071530877d688f6b8c1061e3f
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tadeuzagallotadeuzagallo

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@orktes@facebook-github-bot@lindskogen@satya164@tadeuzagallo