Uh oh!
There was an error while loading. Please reload this page.
[WebSocket] Add support for binary type data (ArrayBuffer) - #4483
[WebSocket] Add support for binary type data (ArrayBuffer)#4483lindskogen wants to merge 1 commit into
Conversation
facebook-github-bot
commented
Dec 2, 2015
By analyzing the blame information on this pull request, we identified @satya164, @hharnisc and @tadeuzagallo to be potential reviewers. |
facebook-github-bot
commented
Dec 2, 2015
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
facebook-github-bot
commented
Dec 2, 2015
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
alexkrolick
commented
Dec 7, 2015
This just encodes the binary buffer as a string using base64. Unless the server is expecting base64-encoded data, this won't help. |
lindskogen
commented
Dec 7, 2015
Actually, it returns an |
alexkrolick
commented
Dec 7, 2015
Woops, 👍. Is it possible to extend this for
|
lindskogen
commented
Dec 8, 2015
@whokilledtheelectricmonk Does binary data make android crash too? |
nicklockwood
commented
Dec 22, 2015
@facebook-github-bot shipit |
facebook-github-bot
commented
Dec 22, 2015
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/946334525447643/int_phab to review. |
mkonicek
commented
Dec 22, 2015
This one has successfully landed internally. Will be closed once the export is fixed. |
…rayBuffer) This brings the same functionality that's already present on iOS, introduced in react#4483, to Android: convert binary payloads to base64 strings and send them to JS land that way, where they'll be turned into an ArrayBuffer.
Summary:This brings the same functionality that's already present on iOS, introduced in #4483, to Android: convert binary payloads to base64 strings and send them to JS land that way, where they'll be turned into an ArrayBuffer. **Test Plan:** Used test server from #6889 (in `--binary` mode) to send some binary data to the Android UIExplorer example (also from #6889). Verified it's received correctly as `ArrayBuffer`. Closes#6868 Differential Revision: D3184797 Pulled By: mkonicek fb-gh-sync-id: e78c640c43b3e41a75ddba79acc04e5eaab5667d fbshipit-source-id: e78c640c43b3e41a75ddba79acc04e5eaab5667d
Summary:This brings the same functionality that's already present on iOS, introduced in react#4483, to Android: convert binary payloads to base64 strings and send them to JS land that way, where they'll be turned into an ArrayBuffer. **Test Plan:** Used test server from react#6889 (in `--binary` mode) to send some binary data to the Android UIExplorer example (also from react#6889). Verified it's received correctly as `ArrayBuffer`. Closesreact#6868 Differential Revision: D3184797 Pulled By: mkonicek fb-gh-sync-id: e78c640c43b3e41a75ddba79acc04e5eaab5667d fbshipit-source-id: e78c640c43b3e41a75ddba79acc04e5eaab5667d
Summary:This brings the same functionality that's already present on iOS, introduced in react#4483, to Android: convert binary payloads to base64 strings and send them to JS land that way, where they'll be turned into an ArrayBuffer. **Test Plan:** Used test server from react#6889 (in `--binary` mode) to send some binary data to the Android UIExplorer example (also from react#6889). Verified it's received correctly as `ArrayBuffer`. Closesreact#6868 Differential Revision: D3184797 Pulled By: mkonicek fb-gh-sync-id: e78c640c43b3e41a75ddba79acc04e5eaab5667d fbshipit-source-id: e78c640c43b3e41a75ddba79acc04e5eaab5667d
saulshanabrook
commented
Jul 12, 2016
Did this add support for array buffers on android as well? |
Entirely based on #1829
I just updated the diff to be compatible with the current master branch.